* [PATCH wq/for-3.7] workqueue: remove spurious WARN_ON_ONCE(in_irq()) from try_to_grab_pending()
[not found] <20120920132548.GA26189@localhost>
@ 2012-09-20 17:06 ` Tejun Heo
0 siblings, 0 replies; only message in thread
From: Tejun Heo @ 2012-09-20 17:06 UTC (permalink / raw)
To: Fengguang Wu; +Cc: Jongman Heo, Lai Jiangshan, linux-kernel
>From 7c6e72e46c9ea4a88f3f8ba96edce9db4bd48726 Mon Sep 17 00:00:00 2001
From: Tejun Heo <tj@kernel.org>
Date: Thu, 20 Sep 2012 10:03:19 -0700
e0aecdd874 ("workqueue: use irqsafe timer for delayed_work") made
try_to_grab_pending() safe to use from irq context but forgot to
remove WARN_ON_ONCE(in_irq()). Remove it.
Signed-off-by: Tejun Heo <tj@kernel.org>
Reported-by: Fengguang Wu <fengguang.wu@intel.com>
---
kernel/workqueue.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/kernel/workqueue.c b/kernel/workqueue.c
index 4f5c61f..143fd8c 100644
--- a/kernel/workqueue.c
+++ b/kernel/workqueue.c
@@ -1070,8 +1070,6 @@ static int try_to_grab_pending(struct work_struct *work, bool is_dwork,
{
struct global_cwq *gcwq;
- WARN_ON_ONCE(in_irq());
-
local_irq_save(*flags);
/* try to steal the timer if it exists */
--
1.7.7.3
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2012-09-20 17:07 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20120920132548.GA26189@localhost>
2012-09-20 17:06 ` [PATCH wq/for-3.7] workqueue: remove spurious WARN_ON_ONCE(in_irq()) from try_to_grab_pending() Tejun Heo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).