* [patch] [SCSI] bfa: unlock on error in bfad_iocmd_cfg_trunk()
@ 2012-10-11 6:57 Dan Carpenter
0 siblings, 0 replies; only message in thread
From: Dan Carpenter @ 2012-10-11 6:57 UTC (permalink / raw)
To: Krishna C Gudipati
Cc: James E.J. Bottomley, linux-scsi, linux-kernel, kernel-janitors
We added a new return but forgot to drop the lock first.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
Bug introduced in e353546e "[SCSI] bfa: Add diagnostic port (D-Port)
support".
diff --git a/drivers/scsi/bfa/bfad_bsg.c b/drivers/scsi/bfa/bfad_bsg.c
index 555e7db..91465b2 100644
--- a/drivers/scsi/bfa/bfad_bsg.c
+++ b/drivers/scsi/bfa/bfad_bsg.c
@@ -2238,8 +2238,10 @@ bfad_iocmd_cfg_trunk(struct bfad_s *bfad, void *cmd, unsigned int v_cmd)
spin_lock_irqsave(&bfad->bfad_lock, flags);
- if (bfa_fcport_is_dport(&bfad->bfa))
+ if (bfa_fcport_is_dport(&bfad->bfa)) {
+ spin_unlock_irqrestore(&bfad->bfad_lock, flags);
return BFA_STATUS_DPORT_ERR;
+ }
if ((fcport->cfg.topology == BFA_PORT_TOPOLOGY_LOOP) ||
(fcport->topology == BFA_PORT_TOPOLOGY_LOOP))
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2012-10-11 6:58 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-10-11 6:57 [patch] [SCSI] bfa: unlock on error in bfad_iocmd_cfg_trunk() Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).