From: Dan Carpenter <dan.carpenter@oracle.com>
To: "K. Y. Srinivasan" <kys@microsoft.com>
Cc: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
devel@linuxdriverproject.org, olaf@aepfle.de, apw@canonical.com,
jasowang@redhat.com, Stable <stable@vger.kernel.org>
Subject: Re: [PATCH 2/3] Drivers: hv: Cleanup error handling in vmbus_open()
Date: Thu, 18 Oct 2012 12:46:25 +0300 [thread overview]
Message-ID: <20121018094625.GB5685@mwanda> (raw)
In-Reply-To: <1350073363-10614-2-git-send-email-kys@microsoft.com>
On Fri, Oct 12, 2012 at 01:22:42PM -0700, K. Y. Srinivasan wrote:
> -errorout:
> - hv_ringbuffer_cleanup(&newchannel->outbound);
> - hv_ringbuffer_cleanup(&newchannel->inbound);
> +error1:
> + spin_lock_irqsave(&vmbus_connection.channelmsg_lock, flags);
> + list_del(&open_info->msglistentry);
> + spin_unlock_irqrestore(&vmbus_connection.channelmsg_lock, flags);
> +
> +error0:
It's better to give the labels meaningful names like error_del and
error_pages instead of GW-BASIC numbers.
regards,
dan carpenter
next prev parent reply other threads:[~2012-10-18 9:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-12 20:22 [PATCH 0/3] Drivers: hv: vmbus K. Y. Srinivasan
2012-10-12 20:22 ` [PATCH 1/3] Drivers: hv: Get rid of unnecessary forward declarations K. Y. Srinivasan
2012-10-12 20:22 ` [PATCH 2/3] Drivers: hv: Cleanup error handling in vmbus_open() K. Y. Srinivasan
2012-10-18 9:46 ` Dan Carpenter [this message]
2012-10-12 20:22 ` [PATCH 3/3] Drivers: hv: Get rid of hv_ringbuffer_cleanup() K. Y. Srinivasan
2012-10-24 22:45 ` Greg KH
2012-10-25 14:13 ` KY Srinivasan
2012-10-17 6:10 ` [PATCH 0/3] Drivers: hv: vmbus Jason Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121018094625.GB5685@mwanda \
--to=dan.carpenter@oracle.com \
--cc=apw@canonical.com \
--cc=devel@linuxdriverproject.org \
--cc=gregkh@linuxfoundation.org \
--cc=jasowang@redhat.com \
--cc=kys@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=olaf@aepfle.de \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).