From: KY Srinivasan <kys@microsoft.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"devel@linuxdriverproject.org" <devel@linuxdriverproject.org>,
"olaf@aepfle.de" <olaf@aepfle.de>,
"apw@canonical.com" <apw@canonical.com>,
"jasowang@redhat.com" <jasowang@redhat.com>
Subject: RE: [PATCH 3/3] Drivers: hv: Get rid of hv_ringbuffer_cleanup()
Date: Thu, 25 Oct 2012 14:13:28 +0000 [thread overview]
Message-ID: <426367E2313C2449837CD2DE46E7EAF930A468BC@SN2PRD0310MB382.namprd03.prod.outlook.com> (raw)
In-Reply-To: <20121024224528.GA30009@kroah.com>
> -----Original Message-----
> From: Greg KH [mailto:gregkh@linuxfoundation.org]
> Sent: Wednesday, October 24, 2012 6:45 PM
> To: KY Srinivasan
> Cc: linux-kernel@vger.kernel.org; devel@linuxdriverproject.org; olaf@aepfle.de;
> apw@canonical.com; jasowang@redhat.com
> Subject: Re: [PATCH 3/3] Drivers: hv: Get rid of hv_ringbuffer_cleanup()
>
> On Fri, Oct 12, 2012 at 01:22:43PM -0700, K. Y. Srinivasan wrote:
> > hv_ringbuffer_cleanup() is an empty function; get rid of it.
> >
> > Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
> > Reviewed-by: Haiyang Zhang <haiyangz@microsoft.com>
> > Reported-by: Jason Wang <jasowang@redhat.com>
> > Acked-by: Jason Wang <jasowang@redhat.com>
> > ---
> > drivers/hv/channel.c | 4 ----
> > drivers/hv/hyperv_vmbus.h | 1 -
> > drivers/hv/ring_buffer.c | 11 -----------
> > 3 files changed, 0 insertions(+), 16 deletions(-)
>
> That's nice, but this patch causes build failures, so I can't accept it.
>
> Please test your patches better (hint, a simple 'git grep' would have
> worked here...)
Sorry about that. I am pretty sure I built (with this patch) both vmbus and the util drivers.
This function is a private function for the vmbus driver and in fact I went back and rebuilt the
drivers in the hv directory without any problem (with this patch applied) in the same tree where
I developed these patches (linux-next tree dated October 2, 2012). Specifically, what was
the build problem you ran into.
Regards,
K. Y
next prev parent reply other threads:[~2012-10-25 14:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-12 20:22 [PATCH 0/3] Drivers: hv: vmbus K. Y. Srinivasan
2012-10-12 20:22 ` [PATCH 1/3] Drivers: hv: Get rid of unnecessary forward declarations K. Y. Srinivasan
2012-10-12 20:22 ` [PATCH 2/3] Drivers: hv: Cleanup error handling in vmbus_open() K. Y. Srinivasan
2012-10-18 9:46 ` Dan Carpenter
2012-10-12 20:22 ` [PATCH 3/3] Drivers: hv: Get rid of hv_ringbuffer_cleanup() K. Y. Srinivasan
2012-10-24 22:45 ` Greg KH
2012-10-25 14:13 ` KY Srinivasan [this message]
2012-10-17 6:10 ` [PATCH 0/3] Drivers: hv: vmbus Jason Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=426367E2313C2449837CD2DE46E7EAF930A468BC@SN2PRD0310MB382.namprd03.prod.outlook.com \
--to=kys@microsoft.com \
--cc=apw@canonical.com \
--cc=devel@linuxdriverproject.org \
--cc=gregkh@linuxfoundation.org \
--cc=jasowang@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=olaf@aepfle.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).