linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Vivek Goyal <vgoyal@redhat.com>
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: Matthew Garrett <mjg@redhat.com>,
	Khalid Aziz <khalid@gonehiking.org>,
	kexec@lists.infradead.org, horms@verge.net.au,
	Dave Young <dyoung@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
	linux kernel mailing list <linux-kernel@vger.kernel.org>,
	Mimi Zohar <zohar@linux.vnet.ibm.com>,
	"Kasatkin, Dmitry" <dmitry.kasatkin@intel.com>
Subject: Re: [RFC] Kdump with signed images
Date: Wed, 24 Oct 2012 13:19:26 -0400	[thread overview]
Message-ID: <20121024171926.GD1821@redhat.com> (raw)
In-Reply-To: <87d309xhmc.fsf_-_@xmission.com>

On Tue, Oct 23, 2012 at 09:44:59AM -0700, Eric W. Biederman wrote:
> Matthew Garrett <mjg@redhat.com> writes:
> 
> > On Tue, Oct 23, 2012 at 10:59:20AM -0400, Vivek Goyal wrote:
> >
> >> But what about creation of a new program which can call kexec_load()
> >> and execute an unsigned kernel. Doesn't look like that will be
> >> prevented using IMA.
> >
> > Right. Trusting userspace would require a new system call that passes in 
> > a signature of the userspace binary, and the kernel would then have to 
> > verify the ELF object in memory in order to ensure that it 
> > matches the signature. Verifying that the copy on the filesystem is 
> > unmodified isn't adequate - an attacker could simply have paused the 
> > process and injected code. 
> 
> Verifying the copy on the filesystem at exec time is perfectly adequate
> for gating extra permissions.  Certainly that is the model everywhere
> else in the signed key chain.
> 
> Where IMA falls short is there is no offline signing capability in IMA
> itself.  I think EVM may fix that.

[ CCing lkml. I think it is a good idea to open discussion to wider
audience. Also CCing IMA/EVM folks ]

Based on reading following wiki page, looks like EVM also does not allow
offline signing capability. And EVM is protecting IMA data to protect
against offline attack. If we can assume that unisgned kernels can't be
booted on the platform, then EVM might not be a strict requirement in
this case.

So as you said, one of the main problem with IMA use to verify /sbin/kexec
is that IMA does not provide offline signing capability.

> 
> > Realistically, the only solution here is for 
> > the kernel to verify that the kernel it's about to boot is signed and 
> > for it not to take any untrusted executable code from userspace.
> 
> Hogwash.  The kernel verifing a signature of /sbin/kexec at exec time is
> perfectly reasonable, and realistic.  In fact finding a way to trust
> small bits of userspace even if root is compromised seems a far superior
> model to simply solving the signing problem for /sbin/kexec.
> 
> Although I do admit some part of the kexec process will need to verify
> keys on the images we decide to boot.

It should be an option, isn't it? Either /sbin/kexec can try to verify the
integrity of kernel or we extend try to extend kexec() system call to also
pass the signature of kernel and let kernel verify it (as you mentioned
previously).

Thanks
Vivek

  parent reply	other threads:[~2012-10-24 17:19 UTC|newest]

Thread overview: 49+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1350588121.30243.7.camel@rhapsody>
     [not found] ` <20121018193831.GD18147@redhat.com>
     [not found]   ` <874nlrv2ni.fsf@xmission.com>
     [not found]     ` <20121019020630.GA27052@redhat.com>
     [not found]       ` <877gqnnnf0.fsf@xmission.com>
     [not found]         ` <20121019143112.GB27052@redhat.com>
     [not found]           ` <871ugqb4gj.fsf@xmission.com>
     [not found]             ` <20121023131854.GA16496@redhat.com>
     [not found]               ` <20121023145920.GD16496@redhat.com>
     [not found]                 ` <87fw552mb4.fsf_-_@xmission.com>
2012-10-24 17:36                   ` Kdump with signed images Vivek Goyal
2012-10-25  6:10                     ` Mimi Zohar
2012-10-25 14:10                       ` Vivek Goyal
2012-10-25 18:40                         ` Mimi Zohar
2012-10-25 18:55                           ` Vivek Goyal
2012-10-26  1:15                             ` Mimi Zohar
2012-10-26  2:39                               ` Matthew Garrett
2012-10-26  3:30                                 ` Eric W. Biederman
2012-10-26 17:06                                 ` Vivek Goyal
2012-10-26 18:37                                   ` Mimi Zohar
2012-11-01 13:10                                     ` Vivek Goyal
2012-11-01 13:53                                       ` Vivek Goyal
2012-11-01 14:29                                         ` Mimi Zohar
2012-11-01 14:43                                           ` Vivek Goyal
2012-11-01 14:52                                             ` Matthew Garrett
2012-11-02 13:23                                               ` Vivek Goyal
2012-11-02 14:29                                                 ` Balbir Singh
2012-11-02 14:36                                                   ` Vivek Goyal
2012-11-03  3:02                                                     ` Balbir Singh
2012-11-02 21:34                                                   ` H. Peter Anvin
2012-11-02 21:32                                                 ` Eric W. Biederman
2012-11-05 18:03                                                   ` Vivek Goyal
2012-11-05 19:44                                                     ` Eric W. Biederman
2012-11-05 20:42                                                       ` Vivek Goyal
2012-11-05 23:01                                                         ` H. Peter Anvin
2012-11-06 19:34                                                       ` Vivek Goyal
2012-11-06 23:51                                                         ` Eric W. Biederman
2012-11-08 19:40                                                           ` Vivek Goyal
2012-11-08 19:45                                                             ` Vivek Goyal
2012-11-08 21:03                                                               ` Eric W. Biederman
2012-11-09 14:39                                                                 ` Vivek Goyal
2012-11-15  5:09                                                                   ` Eric W. Biederman
2012-11-15 12:56                                                                     ` Mimi Zohar
2012-11-08 20:46                                                             ` Mimi Zohar
2012-11-01 14:51                                           ` Vivek Goyal
2012-11-01 14:57                                             ` Matthew Garrett
2012-11-01 15:10                                               ` Khalid Aziz
2012-11-01 16:23                                                 ` Matthew Garrett
2012-11-02 16:57                                                   ` Khalid Aziz
2012-10-26 17:59                                 ` Mimi Zohar
2012-10-26 18:19                                   ` Matthew Garrett
2012-10-26 18:25                                     ` Mimi Zohar
     [not found]                 ` <20121023154123.GA30730@srcf.ucam.org>
     [not found]                   ` <87d309xhmc.fsf_-_@xmission.com>
2012-10-24 17:19                     ` Vivek Goyal [this message]
2012-10-25  5:43                       ` [RFC] " Mimi Zohar
2012-10-25  6:44                         ` Kees Cook
2012-10-25  7:01                           ` Mimi Zohar
2012-10-25 13:54                         ` Vivek Goyal
2012-10-25 19:06                           ` Mimi Zohar
2012-10-25 15:39                   ` [RFC] Kdump with UEFI secure boot (Re: [PATCH v2] kdump: pass acpi_rsdp= to 2nd kernel for efi booting) Vivek Goyal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121024171926.GD1821@redhat.com \
    --to=vgoyal@redhat.com \
    --cc=dmitry.kasatkin@intel.com \
    --cc=dyoung@redhat.com \
    --cc=ebiederm@xmission.com \
    --cc=horms@verge.net.au \
    --cc=hpa@zytor.com \
    --cc=kexec@lists.infradead.org \
    --cc=khalid@gonehiking.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mjg@redhat.com \
    --cc=zohar@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).