Re: [REGRESSION] uml: signal.c build errors

[Richard Weinberger <richard@nod.at>]

Am Wed, 24 Oct 2012 21:13:55 +0100
schrieb Matthew Leach <matthew@mattleach.net>:

> Richard Weinberger <richard@nod.at> writes:
> 
> > Am Wed, 24 Oct 2012 21:06:25 +0100
> > schrieb Matthew Leach <matthew@mattleach.net>:
> >
> >> Richard Weinberger <richard@nod.at> writes:
> >> > Am Wed, 24 Oct 2012 20:48:52 +0100
> >> > schrieb Matthew Leach <matthew@mattleach.net>:
> >> >
> >> >> 
> >> >> Richard Weinberger <richard@nod.at> writes:
> >> >> > Am Wed, 24 Oct 2012 00:18:34 +0100
> >> >> >> I have tracked this down to [1] where, indeed, the type of
> >> >> >> sig_info is different; the second parameter in signal.c is
> >> >> >> 'siginfo_t' where as in as-layout.h the second parameter's
> >> >> >> type is declared as 'struct siginfo'.
> >> >> >> 
> >> >> >> [1]: d3c1cfcdb43e023ab1b1c7a555cd9e929026500a
> >> >> >
> >> >> > Looks like we have to revert that commit.
> >> >> > Moving everything to siginfo_t requires a non-trivial header
> >> >> > cleanup and may introduce new regressions.
> >> >> >
> >> >> > Matthew, does the attached revert patch help?
> >> >> 
> >> >> The revert did remove the errors for the compilation of
> >> >> signal.c, so that seems fine. I still get the following errors,
> >> >> however:
> >> >> 
> >> >>   CC      arch/um/os-Linux/sigio.o
> >> >>   CC      arch/um/os-Linux/signal.o
> >> >>   CC      arch/um/os-Linux/start_up.o
> >> >> arch/um/os-Linux/start_up.c: In function ‘check_coredump_limit’:
> >> >> arch/um/os-Linux/start_up.c:338:16: error: storage size of ‘lim’
> >> >> isn’t known arch/um/os-Linux/start_up.c:339:2: error: implicit
> >> >> declaration of function
> >> >> ‘getrlimit’ [-Werror=implicit-function-declaration]
> >> >> arch/um/os-Linux/start_up.c:339:22: error: ‘RLIMIT_CORE’
> >> >> undeclared (first use in this function)
> >> >> arch/um/os-Linux/start_up.c:339:22: note: each undeclared
> >> >> identifier is reported only once for each function it appears
> >> >> in arch/um/os-Linux/start_up.c:347:22: error: ‘RLIM_INFINITY’
> >> >> undeclared (first use in this function)
> >> >> arch/um/os-Linux/start_up.c:338:16: warning: unused variable
> >> >> ‘lim’ [-Wunused-variable] cc1: some warnings being treated as
> >> >> errors make[1]: *** [arch/um/os-Linux/start_up.o] Error 1 make:
> >> >> *** [arch/um/os-Linux] Error 2
> >> >
> >> > Does adding
> >> > #include <sys/time.h>
> >> > #include <sys/resource.h>
> >> >
> >> > to arch/um/os-Linux/start_up.c help?
> >> 
> >> Adding the above includes and the revert commit did the trick!
> >
> > Thanks a lot for being my build bot. ;)
> 
> Not a problem :).
> 
> > I'm not able to reproduce the issue on any of my machines.
> 
> Strange - well I'm using a fully up-to-date Arch Linux x86_64 distro,
> if that helps.

I'm not using Arch. Can I get an up-to-date Arch images somewhere?

My systems run OpenSUSE, Fedora and Debian.
But also with gcc 4.7 and glibc 2.16...

Thanks,
//richard