linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Matthew Leach <matthew@mattleach.net>
To: Richard Weinberger <richard@nod.at>
Cc: linux-kernel@vger.kernel.org, "Martin Pärtel" <martin.partel@gmail.com>
Subject: Re: [REGRESSION] uml: signal.c build errors
Date: Wed, 24 Oct 2012 21:06:25 +0100	[thread overview]
Message-ID: <87hapj3a9q.fsf@mattleach.net> (raw)
In-Reply-To: <20121024215445.04d53d0d@spider.haslach.nod.at> (Richard Weinberger's message of "Wed, 24 Oct 2012 21:54:45 +0200")

Richard Weinberger <richard@nod.at> writes:
> Am Wed, 24 Oct 2012 20:48:52 +0100
> schrieb Matthew Leach <matthew@mattleach.net>:
>
>> 
>> Richard Weinberger <richard@nod.at> writes:
>> > Am Wed, 24 Oct 2012 00:18:34 +0100
>> >> I have tracked this down to [1] where, indeed, the type of
>> >> sig_info is different; the second parameter in signal.c is
>> >> 'siginfo_t' where as in as-layout.h the second parameter's type is
>> >> declared as 'struct siginfo'.
>> >> 
>> >> [1]: d3c1cfcdb43e023ab1b1c7a555cd9e929026500a
>> >
>> > Looks like we have to revert that commit.
>> > Moving everything to siginfo_t requires a non-trivial header cleanup
>> > and may introduce new regressions.
>> >
>> > Matthew, does the attached revert patch help?
>> 
>> The revert did remove the errors for the compilation of signal.c, so
>> that seems fine. I still get the following errors, however:
>> 
>>   CC      arch/um/os-Linux/sigio.o
>>   CC      arch/um/os-Linux/signal.o
>>   CC      arch/um/os-Linux/start_up.o
>> arch/um/os-Linux/start_up.c: In function ‘check_coredump_limit’:
>> arch/um/os-Linux/start_up.c:338:16: error: storage size of ‘lim’
>> isn’t known arch/um/os-Linux/start_up.c:339:2: error: implicit
>> declaration of function
>> ‘getrlimit’ [-Werror=implicit-function-declaration]
>> arch/um/os-Linux/start_up.c:339:22: error: ‘RLIMIT_CORE’ undeclared
>> (first use in this function) arch/um/os-Linux/start_up.c:339:22:
>> note: each undeclared identifier is reported only once for each
>> function it appears in arch/um/os-Linux/start_up.c:347:22: error:
>> ‘RLIM_INFINITY’ undeclared (first use in this function)
>> arch/um/os-Linux/start_up.c:338:16: warning: unused variable
>> ‘lim’ [-Wunused-variable] cc1: some warnings being treated as errors
>> make[1]: *** [arch/um/os-Linux/start_up.o] Error 1 make: ***
>> [arch/um/os-Linux] Error 2
>
> Does adding
> #include <sys/time.h>
> #include <sys/resource.h>
>
> to arch/um/os-Linux/start_up.c help?

Adding the above includes and the revert commit did the trick!

Thanks,
matt

  reply	other threads:[~2012-10-24 20:06 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-23 23:18 [REGRESSION] uml: signal.c build errors Matthew Leach
2012-10-24  8:08 ` Richard Weinberger
2012-10-24  8:10   ` Richard Weinberger
2012-10-24  9:09   ` Matthew Leach
2012-10-24  9:17     ` Richard Weinberger
2012-12-11 23:15   ` ryanvade
2012-10-24 19:39 ` Richard Weinberger
2012-10-24 19:48   ` Matthew Leach
2012-10-24 19:54     ` Richard Weinberger
2012-10-24 20:06       ` Matthew Leach [this message]
2012-10-24 20:09         ` Richard Weinberger
2012-10-24 20:13           ` Matthew Leach
2012-10-24 20:17             ` Richard Weinberger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87hapj3a9q.fsf@mattleach.net \
    --to=matthew@mattleach.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=martin.partel@gmail.com \
    --cc=richard@nod.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).