linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Re: [PATCH] w1-gpio: Pinctrl-fy
  2012-10-31 15:57 [PATCH] w1-gpio: Pinctrl-fy Pantelis Antoniou
@ 2012-10-30 18:26 ` Tony Lindgren
  2012-11-05 15:45   ` Evgeniy Polyakov
  0 siblings, 1 reply; 4+ messages in thread
From: Tony Lindgren @ 2012-10-30 18:26 UTC (permalink / raw)
  To: Pantelis Antoniou
  Cc: Evgeniy Polyakov, linux-kernel, Koen Kooi, Matt Porter,
	Russ Dill, linux-omap

* Pantelis Antoniou <panto@antoniou-consulting.com> [121030 11:17]:
> Enable pinctrl for w1-gpio.
>
> Signed-off-by: Pantelis Antoniou <panto@antoniou-consulting.com>

Acked-by: Tony Lindgren <tony@atomide.com>

> ---
>  drivers/w1/masters/w1-gpio.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/drivers/w1/masters/w1-gpio.c b/drivers/w1/masters/w1-gpio.c
> index 6012c4e..aec35bd 100644
> --- a/drivers/w1/masters/w1-gpio.c
> +++ b/drivers/w1/masters/w1-gpio.c
> @@ -16,6 +16,8 @@
>  #include <linux/gpio.h>
>  #include <linux/of_platform.h>
>  #include <linux/of_gpio.h>
> +#include <linux/pinctrl/consumer.h>
> +#include <linux/err.h>
>  
>  #include "../w1.h"
>  #include "../w1_int.h"
> @@ -85,8 +87,13 @@ static int __init w1_gpio_probe(struct platform_device *pdev)
>  {
>  	struct w1_bus_master *master;
>  	struct w1_gpio_platform_data *pdata;
> +	struct pinctrl *pinctrl;
>  	int err;
>  
> +	pinctrl = devm_pinctrl_get_select_default(&pdev->dev);
> +	if (IS_ERR(pinctrl))
> +		dev_warn(&pdev->dev, "unable to select pin group\n");
> +
>  	err = w1_gpio_probe_dt(pdev);
>  	if (err < 0)
>  		return err;
> -- 
> 1.7.12
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH] w1-gpio: Pinctrl-fy
@ 2012-10-31 15:57 Pantelis Antoniou
  2012-10-30 18:26 ` Tony Lindgren
  0 siblings, 1 reply; 4+ messages in thread
From: Pantelis Antoniou @ 2012-10-31 15:57 UTC (permalink / raw)
  To: Evgeniy Polyakov
  Cc: Pantelis Antoniou, linux-kernel, Koen Kooi, Matt Porter,
	Russ Dill, linux-omap

Enable pinctrl for w1-gpio.

Signed-off-by: Pantelis Antoniou <panto@antoniou-consulting.com>
---
 drivers/w1/masters/w1-gpio.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/drivers/w1/masters/w1-gpio.c b/drivers/w1/masters/w1-gpio.c
index 6012c4e..aec35bd 100644
--- a/drivers/w1/masters/w1-gpio.c
+++ b/drivers/w1/masters/w1-gpio.c
@@ -16,6 +16,8 @@
 #include <linux/gpio.h>
 #include <linux/of_platform.h>
 #include <linux/of_gpio.h>
+#include <linux/pinctrl/consumer.h>
+#include <linux/err.h>
 
 #include "../w1.h"
 #include "../w1_int.h"
@@ -85,8 +87,13 @@ static int __init w1_gpio_probe(struct platform_device *pdev)
 {
 	struct w1_bus_master *master;
 	struct w1_gpio_platform_data *pdata;
+	struct pinctrl *pinctrl;
 	int err;
 
+	pinctrl = devm_pinctrl_get_select_default(&pdev->dev);
+	if (IS_ERR(pinctrl))
+		dev_warn(&pdev->dev, "unable to select pin group\n");
+
 	err = w1_gpio_probe_dt(pdev);
 	if (err < 0)
 		return err;
-- 
1.7.12


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] w1-gpio: Pinctrl-fy
  2012-10-30 18:26 ` Tony Lindgren
@ 2012-11-05 15:45   ` Evgeniy Polyakov
  2012-11-05 16:13     ` Tony Lindgren
  0 siblings, 1 reply; 4+ messages in thread
From: Evgeniy Polyakov @ 2012-11-05 15:45 UTC (permalink / raw)
  To: Tony Lindgren
  Cc: Pantelis Antoniou, linux-kernel, Koen Kooi, Matt Porter,
	Russ Dill, linux-omap

Hi

On Tue, Oct 30, 2012 at 11:26:25AM -0700, Tony Lindgren (tony@atomide.com) wrote:
> * Pantelis Antoniou <panto@antoniou-consulting.com> [121030 11:17]:
> > Enable pinctrl for w1-gpio.
> >
> > Signed-off-by: Pantelis Antoniou <panto@antoniou-consulting.com>
> 
> Acked-by: Tony Lindgren <tony@atomide.com>

Acked-by: Evgeniy Polyakov <zbr@ioremap.net>

Please submit patches through the appropriate tree, or you want me to
push them upstream?

-- 
	Evgeniy Polyakov

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] w1-gpio: Pinctrl-fy
  2012-11-05 15:45   ` Evgeniy Polyakov
@ 2012-11-05 16:13     ` Tony Lindgren
  0 siblings, 0 replies; 4+ messages in thread
From: Tony Lindgren @ 2012-11-05 16:13 UTC (permalink / raw)
  To: Evgeniy Polyakov
  Cc: Pantelis Antoniou, linux-kernel, Koen Kooi, Matt Porter,
	Russ Dill, linux-omap

* Evgeniy Polyakov <zbr@ioremap.net> [121105 07:47]:
> Hi
> 
> On Tue, Oct 30, 2012 at 11:26:25AM -0700, Tony Lindgren (tony@atomide.com) wrote:
> > * Pantelis Antoniou <panto@antoniou-consulting.com> [121030 11:17]:
> > > Enable pinctrl for w1-gpio.
> > >
> > > Signed-off-by: Pantelis Antoniou <panto@antoniou-consulting.com>
> > 
> > Acked-by: Tony Lindgren <tony@atomide.com>
> 
> Acked-by: Evgeniy Polyakov <zbr@ioremap.net>
> 
> Please submit patches through the appropriate tree, or you want me to
> push them upstream?

I prefer you queue it.

Thanks,

Tony

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2012-11-05 16:14 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-10-31 15:57 [PATCH] w1-gpio: Pinctrl-fy Pantelis Antoniou
2012-10-30 18:26 ` Tony Lindgren
2012-11-05 15:45   ` Evgeniy Polyakov
2012-11-05 16:13     ` Tony Lindgren

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).