* [PATCH v2] mfd: Only unregister platform devices allocated by the mfd core
@ 2012-11-09 16:15 Charles Keepax
2012-11-09 16:40 ` Mark Brown
2012-11-19 0:20 ` Samuel Ortiz
0 siblings, 2 replies; 3+ messages in thread
From: Charles Keepax @ 2012-11-09 16:15 UTC (permalink / raw)
To: sameo; +Cc: linux-kernel, patches, broonie
mfd_remove_devices would iterate over all devices sharing a parent with
an mfd device regardless of whether they were allocated by the mfd core
or not. This especially caused problems when the device structure was
not contained within a platform_device, because to_platform_device is
used on each device pointer.
This patch defines a device_type for mfd devices and checks this is
present from mfd_remove_devices_fn before processing the device.
Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
---
drivers/mfd/mfd-core.c | 15 +++++++++++++--
1 files changed, 13 insertions(+), 2 deletions(-)
diff --git a/drivers/mfd/mfd-core.c b/drivers/mfd/mfd-core.c
index f8b7771..7604f4e 100644
--- a/drivers/mfd/mfd-core.c
+++ b/drivers/mfd/mfd-core.c
@@ -21,6 +21,10 @@
#include <linux/irqdomain.h>
#include <linux/of.h>
+static struct device_type mfd_dev_type = {
+ .name = "mfd_device",
+};
+
int mfd_cell_enable(struct platform_device *pdev)
{
const struct mfd_cell *cell = mfd_get_cell(pdev);
@@ -91,6 +95,7 @@ static int mfd_add_device(struct device *parent, int id,
goto fail_device;
pdev->dev.parent = parent;
+ pdev->dev.type = &mfd_dev_type;
if (parent->of_node && cell->of_compatible) {
for_each_child_of_node(parent->of_node, np) {
@@ -204,10 +209,16 @@ EXPORT_SYMBOL(mfd_add_devices);
static int mfd_remove_devices_fn(struct device *dev, void *c)
{
- struct platform_device *pdev = to_platform_device(dev);
- const struct mfd_cell *cell = mfd_get_cell(pdev);
+ struct platform_device *pdev;
+ const struct mfd_cell *cell;
atomic_t **usage_count = c;
+ if (dev->type != &mfd_dev_type)
+ return 0;
+
+ pdev = to_platform_device(dev);
+ cell = mfd_get_cell(pdev);
+
/* find the base address of usage_count pointers (for freeing) */
if (!*usage_count || (cell->usage_count < *usage_count))
*usage_count = cell->usage_count;
--
1.7.2.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] mfd: Only unregister platform devices allocated by the mfd core
2012-11-09 16:15 [PATCH v2] mfd: Only unregister platform devices allocated by the mfd core Charles Keepax
@ 2012-11-09 16:40 ` Mark Brown
2012-11-19 0:20 ` Samuel Ortiz
1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2012-11-09 16:40 UTC (permalink / raw)
To: Charles Keepax; +Cc: sameo, linux-kernel, patches
[-- Attachment #1: Type: text/plain, Size: 450 bytes --]
On Fri, Nov 09, 2012 at 04:15:28PM +0000, Charles Keepax wrote:
> mfd_remove_devices would iterate over all devices sharing a parent with
> an mfd device regardless of whether they were allocated by the mfd core
> or not. This especially caused problems when the device structure was
> not contained within a platform_device, because to_platform_device is
> used on each device pointer.
Reviewed-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] mfd: Only unregister platform devices allocated by the mfd core
2012-11-09 16:15 [PATCH v2] mfd: Only unregister platform devices allocated by the mfd core Charles Keepax
2012-11-09 16:40 ` Mark Brown
@ 2012-11-19 0:20 ` Samuel Ortiz
1 sibling, 0 replies; 3+ messages in thread
From: Samuel Ortiz @ 2012-11-19 0:20 UTC (permalink / raw)
To: Charles Keepax; +Cc: linux-kernel, patches, broonie
Hi Charles,
On Fri, Nov 09, 2012 at 04:15:28PM +0000, Charles Keepax wrote:
> mfd_remove_devices would iterate over all devices sharing a parent with
> an mfd device regardless of whether they were allocated by the mfd core
> or not. This especially caused problems when the device structure was
> not contained within a platform_device, because to_platform_device is
> used on each device pointer.
>
> This patch defines a device_type for mfd devices and checks this is
> present from mfd_remove_devices_fn before processing the device.
>
> Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
> ---
> drivers/mfd/mfd-core.c | 15 +++++++++++++--
> 1 files changed, 13 insertions(+), 2 deletions(-)
Thanks a lot, patch applied to my for-next branch.
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-11-19 0:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-11-09 16:15 [PATCH v2] mfd: Only unregister platform devices allocated by the mfd core Charles Keepax
2012-11-09 16:40 ` Mark Brown
2012-11-19 0:20 ` Samuel Ortiz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).