From: "Henrik Rydberg" <rydberg@euromail.se>
To: Benjamin Tissoires <benjamin.tissoires@gmail.com>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Jiri Kosina <jkosina@suse.cz>, Stephane Chatty <chatty@enac.fr>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 10/13] HID: hid-multitouch: fix Win 8 protocol
Date: Tue, 13 Nov 2012 17:31:38 +0100 [thread overview]
Message-ID: <20121113163138.GA707@polaris.bitmath.org> (raw)
In-Reply-To: <1352306256-12180-11-git-send-email-benjamin.tissoires@gmail.com>
Hi Benjamin,
> Win 8 specification is much more precise than the Win 7 one.
> Moreover devices that need to take certification must be submitted
> to Microsoft.
>
> The result is a better protocol support and we can rely on that to
> skip all the messy tests we used to do.
>
You could possibly start the commit message here..
> The protocol specify the fact that each valid touch must be reported
The win8 protocol...
> within a frame until it is released.
> So we can use the always_valid quirk and dismiss reports when we see
We can therefore...
> duplicates contact ID.
duplicate contacts.
>
> We recognize Win8 certified devices from their vendor feature 0xff0000c5
> where Microsoft put a signed blob in the report to check if the device
> passed the certification.
>
> Signed-off-by: Benjamin Tissoires <benjamin.tissoires@gmail.com>
> ---
> drivers/hid/hid-multitouch.c | 12 ++++++++++--
> 1 file changed, 10 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c
> index 351c814..b393c6c 100644
> --- a/drivers/hid/hid-multitouch.c
> +++ b/drivers/hid/hid-multitouch.c
> @@ -53,6 +53,7 @@ MODULE_LICENSE("GPL");
> #define MT_QUIRK_SLOT_IS_CONTACTID_MINUS_ONE (1 << 8)
> #define MT_QUIRK_NO_AREA (1 << 9)
> #define MT_QUIRK_IGNORE_DUPLICATES (1 << 10)
> +#define MT_QUIRK_WIN_8_CERTIFIED (1 << 11)
>
> struct mt_slot {
> __s32 x, y, cx, cy, p, w, h;
> @@ -293,6 +294,10 @@ static void mt_feature_mapping(struct hid_device *hdev,
> td->maxcontacts = td->mtclass.maxcontacts;
>
> break;
> + case 0xff0000c5:
> + if (field->report_count == 256 && field->report_size == 8)
> + td->mtclass.quirks |= MT_QUIRK_WIN_8_CERTIFIED;
> + break;
> }
> }
>
> @@ -679,14 +684,17 @@ static void mt_post_parse_default_settings(struct mt_device *td)
> {
> __s32 quirks = td->mtclass.quirks;
>
> - /* unknown serial device needs special quirks */
> - if (td->touches_by_report == 1) {
> + /* unknown serial devices or win8 ones need special quirks */
> + if (td->touches_by_report == 1 || (quirks & MT_QUIRK_WIN_8_CERTIFIED)) {
> quirks |= MT_QUIRK_ALWAYS_VALID;
> quirks &= ~MT_QUIRK_NOT_SEEN_MEANS_UP;
> quirks &= ~MT_QUIRK_VALID_IS_INRANGE;
Won't this line interfere with the hovering functionality?
> quirks &= ~MT_QUIRK_VALID_IS_CONFIDENCE;
> }
>
> + if (quirks & MT_QUIRK_WIN_8_CERTIFIED)
> + quirks |= MT_QUIRK_IGNORE_DUPLICATES;
> +
> td->mtclass.quirks = quirks;
> }
>
> --
> 1.7.11.7
>
Thanks,
Henrik
next prev parent reply other threads:[~2012-11-13 16:25 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-07 16:37 [PATCH v3 00/13] Win 8 support for digitizers Benjamin Tissoires
2012-11-07 16:37 ` [PATCH v3 01/13] HID: hid-input: export hidinput_calc_abs_res Benjamin Tissoires
2012-11-13 7:45 ` Jiri Kosina
2012-11-07 16:37 ` [PATCH v3 02/13] HID: hid-input: round return value of hidinput_calc_abs_res Benjamin Tissoires
2012-11-13 7:44 ` Jiri Kosina
2012-11-07 16:37 ` [PATCH v3 03/13] HID: core: fix unit exponent parsing Benjamin Tissoires
2012-11-13 7:43 ` Jiri Kosina
2012-11-07 16:37 ` [PATCH v3 04/13] HID: hid-input: add usage_index in struct hid_usage Benjamin Tissoires
2012-11-13 7:44 ` Jiri Kosina
2012-11-13 15:38 ` Henrik Rydberg
2012-11-07 16:37 ` [PATCH v3 05/13] HID: hid-multitouch: support arrays for the split of the touches in a report Benjamin Tissoires
2012-11-13 15:44 ` Henrik Rydberg
2012-11-07 16:37 ` [PATCH v3 06/13] HID: hid-multitouch: get maxcontacts also from logical_max value Benjamin Tissoires
2012-11-07 16:37 ` [PATCH v3 07/13] HID: hid-multitouch: support T and C for win8 devices Benjamin Tissoires
2012-11-13 15:56 ` Henrik Rydberg
2012-11-07 16:37 ` [PATCH v3 08/13] HID: hid-multitouch: move ALWAYS_VALID quirk check Benjamin Tissoires
2012-11-13 15:57 ` Henrik Rydberg
2012-11-07 16:37 ` [PATCH v3 09/13] HID: hid-multitouch: add MT_QUIRK_IGNORE_DUPLICATES Benjamin Tissoires
2012-11-13 16:25 ` Henrik Rydberg
2012-11-07 16:37 ` [PATCH v3 10/13] HID: hid-multitouch: fix Win 8 protocol Benjamin Tissoires
2012-11-13 16:31 ` Henrik Rydberg [this message]
2012-11-07 16:37 ` [PATCH v3 11/13] HID: hid-multitouch: support for hovering devices Benjamin Tissoires
2012-11-13 16:42 ` Henrik Rydberg
2012-11-13 17:29 ` Benjamin Tissoires
2012-11-13 18:04 ` Henrik Rydberg
2012-11-13 18:08 ` Benjamin Tissoires
2012-11-13 18:55 ` Henrik Rydberg
2012-11-07 16:37 ` [PATCH v3 12/13] HID: introduce Scan Time Benjamin Tissoires
2012-11-09 8:45 ` Dmitry Torokhov
2012-11-13 14:25 ` Benjamin Tissoires
2012-11-13 17:15 ` Henrik Rydberg
2012-11-07 16:37 ` [PATCH v3 13/13] HID: hid-multitouch: forwards ABS_SCAN_TIME Benjamin Tissoires
2012-11-13 14:30 ` Benjamin Tissoires
2012-11-13 17:27 ` Henrik Rydberg
2012-11-13 17:45 ` Benjamin Tissoires
2012-11-13 18:28 ` Henrik Rydberg
2012-11-13 18:43 ` Henrik Rydberg
2012-11-13 7:47 ` [PATCH v3 00/13] Win 8 support for digitizers Jiri Kosina
2012-11-13 8:12 ` Benjamin Tissoires
2012-11-13 17:33 ` Henrik Rydberg
2012-11-13 17:52 ` Benjamin Tissoires
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121113163138.GA707@polaris.bitmath.org \
--to=rydberg@euromail.se \
--cc=benjamin.tissoires@gmail.com \
--cc=chatty@enac.fr \
--cc=dmitry.torokhov@gmail.com \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).