* Re: WARNING: at drivers/tty/tty_buffer.c:476 flush_to_ldisc()
[not found] <20121113052026.GA26289@localhost>
@ 2012-11-13 19:55 ` Jiri Slaby
2012-11-14 13:52 ` Fengguang Wu
0 siblings, 1 reply; 6+ messages in thread
From: Jiri Slaby @ 2012-11-13 19:55 UTC (permalink / raw)
To: Fengguang Wu; +Cc: LKML
On 11/13/2012 06:20 AM, Fengguang Wu wrote:
> Hi Jiri,
Hi,
> I got the following warning
>
> cat: /proc/1/maps: No such file or directory
> [ 72.249806] ------------[ cut here ]------------
> [ 72.250807] WARNING: at /c/kernel-tests/src/tip/drivers/tty/tty_buffer.c:476 flush_to_ldisc+0x5a/0x1ad()
> [ 72.252674] tty is NULL
> [ 72.253182] Pid: 15, comm: kworker/0:1 Not tainted 3.7.0-rc4-05821-gdb38463 #166
> [ 72.253672] Call Trace:
> [ 72.253672] [<ffffffff8103ccee>] warn_slowpath_common+0x62/0x79
> [ 72.256297] [<ffffffff8103cd73>] warn_slowpath_fmt+0x46/0x48
> [ 72.257292] [<ffffffff811e66c3>] flush_to_ldisc+0x5a/0x1ad
> [ 72.258478] [<ffffffff81053a6d>] process_one_work+0x246/0x44f
> [ 72.259640] [<ffffffff810539da>] ? process_one_work+0x1b3/0x44f
> [ 72.260817] [<ffffffff811e6669>] ? tty_buffer_free+0x61/0x61
> [ 72.261820] [<ffffffff81053fd2>] worker_thread+0x1ed/0x2c8
> [ 72.262883] [<ffffffff81053de5>] ? rescuer_thread+0x140/0x140
> [ 72.263878] [<ffffffff81058556>] kthread+0xd4/0xdc
> [ 72.264980] [<ffffffff810625d7>] ? finish_task_switch.constprop.79+0x7a/0xbf
> [ 72.266150] [<ffffffff81058482>] ? __kthread_parkme+0x61/0x61
> [ 72.267145] [<ffffffff81533bea>] ret_from_fork+0x7a/0xb0
> [ 72.268361] [<ffffffff81058482>] ? __kthread_parkme+0x61/0x61
>
> and it's bisected to
>
> commit ecbbfd44a08fa80e0d664814efd4c187721b85f6
Yes, I know about this already. Can you reproducible that easily given
you bisected that? I would love to be able to reproduce that...
thanks,
--
js
suse labs
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: WARNING: at drivers/tty/tty_buffer.c:476 flush_to_ldisc()
2012-11-13 19:55 ` WARNING: at drivers/tty/tty_buffer.c:476 flush_to_ldisc() Jiri Slaby
@ 2012-11-14 13:52 ` Fengguang Wu
0 siblings, 0 replies; 6+ messages in thread
From: Fengguang Wu @ 2012-11-14 13:52 UTC (permalink / raw)
To: Jiri Slaby; +Cc: LKML
Hi Jiri,
On Tue, Nov 13, 2012 at 08:55:34PM +0100, Jiri Slaby wrote:
> On 11/13/2012 06:20 AM, Fengguang Wu wrote:
> > Hi Jiri,
>
> Hi,
>
> > I got the following warning
> >
> > cat: /proc/1/maps: No such file or directory
> > [ 72.249806] ------------[ cut here ]------------
> > [ 72.250807] WARNING: at /c/kernel-tests/src/tip/drivers/tty/tty_buffer.c:476 flush_to_ldisc+0x5a/0x1ad()
> > [ 72.252674] tty is NULL
> > [ 72.253182] Pid: 15, comm: kworker/0:1 Not tainted 3.7.0-rc4-05821-gdb38463 #166
> > [ 72.253672] Call Trace:
> > [ 72.253672] [<ffffffff8103ccee>] warn_slowpath_common+0x62/0x79
> > [ 72.256297] [<ffffffff8103cd73>] warn_slowpath_fmt+0x46/0x48
> > [ 72.257292] [<ffffffff811e66c3>] flush_to_ldisc+0x5a/0x1ad
> > [ 72.258478] [<ffffffff81053a6d>] process_one_work+0x246/0x44f
> > [ 72.259640] [<ffffffff810539da>] ? process_one_work+0x1b3/0x44f
> > [ 72.260817] [<ffffffff811e6669>] ? tty_buffer_free+0x61/0x61
> > [ 72.261820] [<ffffffff81053fd2>] worker_thread+0x1ed/0x2c8
> > [ 72.262883] [<ffffffff81053de5>] ? rescuer_thread+0x140/0x140
> > [ 72.263878] [<ffffffff81058556>] kthread+0xd4/0xdc
> > [ 72.264980] [<ffffffff810625d7>] ? finish_task_switch.constprop.79+0x7a/0xbf
> > [ 72.266150] [<ffffffff81058482>] ? __kthread_parkme+0x61/0x61
> > [ 72.267145] [<ffffffff81533bea>] ret_from_fork+0x7a/0xb0
> > [ 72.268361] [<ffffffff81058482>] ? __kthread_parkme+0x61/0x61
> >
> > and it's bisected to
> >
> > commit ecbbfd44a08fa80e0d664814efd4c187721b85f6
>
> Yes, I know about this already. Can you reproducible that easily given
> you bisected that? I would love to be able to reproduce that...
I checked the bisect log (attached in the original email) and it shows
that it may take several hundreds of boots to reproduce the error once.
So in the bisect, it regards 7540 repeated good boots as one success.
Thanks,
Fengguang
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: WARNING: at drivers/tty/tty_buffer.c:476 flush_to_ldisc()
2013-01-19 22:44 Sedat Dilek
2013-01-19 22:51 ` Eric Sandeen
@ 2013-01-20 0:14 ` Sedat Dilek
1 sibling, 0 replies; 6+ messages in thread
From: Sedat Dilek @ 2013-01-20 0:14 UTC (permalink / raw)
To: Dave Jones
Cc: Jiri Slaby, Greg Kroah-Hartman, Ilya Zykov, LKML, linux-next,
linux-serial, Stephen Rothwell, Jan Kara, Eric Sandeen,
Theodore Ts'o, linux-fsdevel
On Sat, Jan 19, 2013 at 11:44 PM, Sedat Dilek <sedat.dilek@gmail.com> wrote:
> Hi Dave,
>
> I suspected after initial testing a problem in TTY and applied two patches.
> After more testing the root cause was a problem in JBD2.
> A patch from Eric helped!
> Follow the thread in [1] for more details.
>
> If you are on Linux-Next (next-20130118) you need the following three patches.
>
> Ilya Zykov (2):
> tty: Correct tty buffer flush.
> tty: Add driver unthrottle in ioctl(...,TCFLSH,..).
>
> Eric Sandeen (1):
> jbd2: don't wake kjournald unnecessarily
>
> Hope this helps you.
>
> Regards,
> - Sedat -
>
> [0] http://marc.info/?t=135862023700004&r=1&w=2
> [1] http://marc.info/?l=linux-serial&m=135860500714909&w=2
> [2] http://git.kernel.org/?p=linux/kernel/git/gregkh/tty.git;a=commitdiff;h=a1bf9584429d61b7096f93ae09325e1ba538e9e8
> [3] http://patchwork.ozlabs.org/patch/207237/
I am awfully sorry to tell you that my (JBD2) problem still exist!
Not sure this is anymore related to TTY-NEXT, so better I shut up!
- Sedat -
[1] http://marc.info/?l=linux-kernel&m=135864041624404&w=2
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: WARNING: at drivers/tty/tty_buffer.c:476 flush_to_ldisc()
2013-01-19 22:51 ` Eric Sandeen
@ 2013-01-19 22:57 ` Sedat Dilek
0 siblings, 0 replies; 6+ messages in thread
From: Sedat Dilek @ 2013-01-19 22:57 UTC (permalink / raw)
To: Eric Sandeen
Cc: Dave Jones, Jiri Slaby, Greg Kroah-Hartman, Ilya Zykov, LKML,
linux-next, linux-serial, Stephen Rothwell, Jan Kara,
Theodore Ts'o, linux-fsdevel
On Sat, Jan 19, 2013 at 11:51 PM, Eric Sandeen <sandeen@redhat.com> wrote:
> On 1/19/13 4:44 PM, Sedat Dilek wrote:
>> Hi Dave,
>>
>> I suspected after initial testing a problem in TTY and applied two patches.
>> After more testing the root cause was a problem in JBD2.
>> A patch from Eric helped!
>
> oh, excellent ;)
>
> Helped what, exactly?
>
Fixed a call-trace which I could reproduce running pm_test/freezer
(see [1] "[C.1] TRY TO FORCE THE CALL-TRACE").
- Sedat -
[1] http://marc.info/?l=linux-kernel&m=135862010419101&w=2
>>
Follow the thread in [1] for more details.
>>
>> If you are on Linux-Next (next-20130118) you need the following three patches.
>>
>> Ilya Zykov (2):
>> tty: Correct tty buffer flush.
>> tty: Add driver unthrottle in ioctl(...,TCFLSH,..).
>>
>> Eric Sandeen (1):
>> jbd2: don't wake kjournald unnecessarily
>
> Hum, I would not have expected this to *matter*, I thought it was just a perf
> optimization. Hm. What do you think it fixed, exactly?
>
> (sorry, have not followed that thread, busy elsewhere ATM)
>
> -eric
>
>> Hope this helps you.
>>
>> Regards,
>> - Sedat -
>>
>> [0] http://marc.info/?t=135862023700004&r=1&w=2
>> [1] http://marc.info/?l=linux-serial&m=135860500714909&w=2
>> [2] http://git.kernel.org/?p=linux/kernel/git/gregkh/tty.git;a=commitdiff;h=a1bf9584429d61b7096f93ae09325e1ba538e9e8
>> [3] http://patchwork.ozlabs.org/patch/207237/
>>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: WARNING: at drivers/tty/tty_buffer.c:476 flush_to_ldisc()
2013-01-19 22:44 Sedat Dilek
@ 2013-01-19 22:51 ` Eric Sandeen
2013-01-19 22:57 ` Sedat Dilek
2013-01-20 0:14 ` Sedat Dilek
1 sibling, 1 reply; 6+ messages in thread
From: Eric Sandeen @ 2013-01-19 22:51 UTC (permalink / raw)
To: sedat.dilek
Cc: Dave Jones, Jiri Slaby, Greg Kroah-Hartman, Ilya Zykov, LKML,
linux-next, linux-serial, Stephen Rothwell, Jan Kara,
Theodore Ts'o, linux-fsdevel
On 1/19/13 4:44 PM, Sedat Dilek wrote:
> Hi Dave,
>
> I suspected after initial testing a problem in TTY and applied two patches.
> After more testing the root cause was a problem in JBD2.
> A patch from Eric helped!
oh, excellent ;)
Helped what, exactly?
> Follow the thread in [1] for more details.
>
> If you are on Linux-Next (next-20130118) you need the following three patches.
>
> Ilya Zykov (2):
> tty: Correct tty buffer flush.
> tty: Add driver unthrottle in ioctl(...,TCFLSH,..).
>
> Eric Sandeen (1):
> jbd2: don't wake kjournald unnecessarily
Hum, I would not have expected this to *matter*, I thought it was just a perf
optimization. Hm. What do you think it fixed, exactly?
(sorry, have not followed that thread, busy elsewhere ATM)
-eric
> Hope this helps you.
>
> Regards,
> - Sedat -
>
> [0] http://marc.info/?t=135862023700004&r=1&w=2
> [1] http://marc.info/?l=linux-serial&m=135860500714909&w=2
> [2] http://git.kernel.org/?p=linux/kernel/git/gregkh/tty.git;a=commitdiff;h=a1bf9584429d61b7096f93ae09325e1ba538e9e8
> [3] http://patchwork.ozlabs.org/patch/207237/
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: WARNING: at drivers/tty/tty_buffer.c:476 flush_to_ldisc()
@ 2013-01-19 22:44 Sedat Dilek
2013-01-19 22:51 ` Eric Sandeen
2013-01-20 0:14 ` Sedat Dilek
0 siblings, 2 replies; 6+ messages in thread
From: Sedat Dilek @ 2013-01-19 22:44 UTC (permalink / raw)
To: Dave Jones
Cc: Jiri Slaby, Greg Kroah-Hartman, Ilya Zykov, LKML, linux-next,
linux-serial, Stephen Rothwell, Jan Kara, Eric Sandeen,
Theodore Ts'o, linux-fsdevel
Hi Dave,
I suspected after initial testing a problem in TTY and applied two patches.
After more testing the root cause was a problem in JBD2.
A patch from Eric helped!
Follow the thread in [1] for more details.
If you are on Linux-Next (next-20130118) you need the following three patches.
Ilya Zykov (2):
tty: Correct tty buffer flush.
tty: Add driver unthrottle in ioctl(...,TCFLSH,..).
Eric Sandeen (1):
jbd2: don't wake kjournald unnecessarily
Hope this helps you.
Regards,
- Sedat -
[0] http://marc.info/?t=135862023700004&r=1&w=2
[1] http://marc.info/?l=linux-serial&m=135860500714909&w=2
[2] http://git.kernel.org/?p=linux/kernel/git/gregkh/tty.git;a=commitdiff;h=a1bf9584429d61b7096f93ae09325e1ba538e9e8
[3] http://patchwork.ozlabs.org/patch/207237/
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-01-20 0:14 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20121113052026.GA26289@localhost>
2012-11-13 19:55 ` WARNING: at drivers/tty/tty_buffer.c:476 flush_to_ldisc() Jiri Slaby
2012-11-14 13:52 ` Fengguang Wu
2013-01-19 22:44 Sedat Dilek
2013-01-19 22:51 ` Eric Sandeen
2013-01-19 22:57 ` Sedat Dilek
2013-01-20 0:14 ` Sedat Dilek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).