From: David Miller <davem@davemloft.net>
To: paolo.valente@unimore.it
Cc: jhs@mojatatu.com, shemminger@vyatta.com,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
rizzo@iet.unipi.it, fchecconi@gmail.com
Subject: Re: [PATCH] pkt_sched: QFQ Plus: fair-queueing service at DRR cost
Date: Mon, 19 Nov 2012 18:48:28 -0500 (EST) [thread overview]
Message-ID: <20121119.184828.628106002307042971.davem@davemloft.net> (raw)
In-Reply-To: <20121112164833.GA12970@paolo-ThinkPad-W520>
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: Text/Plain; charset=iso-8859-7, Size: 1034 bytes --]
From: Paolo Valente <paolo.valente@unimore.it>
Date: Mon, 12 Nov 2012 17:48:33 +0100
> [This patch received positive feedback from Stephen Hemminger ("put in
> net-next"), but no further feedback or decision. So I am (re)sending
> an updated version of it. The only differences with respect to the
> previous version are the support for TSO/GSO (taken from QFQ), and a
> hopefully improved description.]
Can you rearrange the logic so that the compiler doesn't emit this
warning?
In file included from net/sched/sch_qfq.c:18:0:
net/sched/sch_qfq.c: In function ¡qfq_dequeue¢:
include/net/sch_generic.h:480:15: warning: ¡skb¢ may be used uninitialized in this function [-Wmaybe-uninitialized]
net/sched/sch_qfq.c:1007:18: note: ¡skb¢ was declared here
You and I both know that SKB will be initialized at this point, but
the compiler can't see it clearly enough.
Thanks.
ÿôèº{.nÇ+·®+%Ëÿ±éݶ\x17¥wÿº{.nÇ+·¥{±þG«éÿ{ayº\x1dÊÚë,j\a¢f£¢·hïêÿêçz_è®\x03(éÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?¨èÚ&£ø§~á¶iOæ¬z·vØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?I¥
next prev parent reply other threads:[~2012-11-19 23:48 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-12 16:48 [PATCH] pkt_sched: QFQ Plus: fair-queueing service at DRR cost Paolo Valente
2012-11-19 23:48 ` David Miller [this message]
2012-11-20 17:45 ` Paolo Valente
2012-11-20 17:53 ` Stephen Hemminger
2012-11-20 18:02 ` David Miller
2012-11-20 18:09 ` Stephen Hemminger
2012-11-20 18:15 ` David Miller
2012-11-20 18:44 ` Stephen Hemminger
2012-11-20 18:00 ` David Miller
2012-11-20 17:45 Paolo Valente
2012-11-20 18:54 ` David Miller
2012-11-21 9:45 ` Paolo Valente
2012-11-21 17:04 ` David Miller
2012-11-22 16:56 Paolo Valente
2012-11-23 19:28 ` David Miller
2012-11-23 21:02 ` Paolo Valente
2012-11-23 21:03 Paolo Valente
2012-11-28 16:20 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121119.184828.628106002307042971.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=fchecconi@gmail.com \
--cc=jhs@mojatatu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=paolo.valente@unimore.it \
--cc=rizzo@iet.unipi.it \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).