From: Stephen Hemminger <shemminger@vyatta.com>
To: Paolo Valente <paolo.valente@unimore.it>
Cc: David Miller <davem@davemloft.net>,
jhs@mojatatu.com, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, rizzo@iet.unipi.it, fchecconi@gmail.com
Subject: Re: [PATCH] pkt_sched: QFQ Plus: fair-queueing service at DRR cost
Date: Tue, 20 Nov 2012 09:53:04 -0800 [thread overview]
Message-ID: <20121120095304.420ded7c@nehalam.linuxnetplumber.net> (raw)
In-Reply-To: <50ABC19E.9030209@unimore.it>
On Tue, 20 Nov 2012 18:45:02 +0100
Paolo Valente <paolo.valente@unimore.it> wrote:
> Il 20/11/2012 00:48, David Miller ha scritto:
> > From: Paolo Valente <paolo.valente@unimore.it>
> > Date: Mon, 12 Nov 2012 17:48:33 +0100
> >
> >> [This patch received positive feedback from Stephen Hemminger ("put in
> >> net-next"), but no further feedback or decision. So I am (re)sending
> >> an updated version of it. The only differences with respect to the
> >> previous version are the support for TSO/GSO (taken from QFQ), and a
> >> hopefully improved description.]
> >
> > Can you rearrange the logic so that the compiler doesn't emit this
> > warning?
> >
> > In file included from net/sched/sch_qfq.c:18:0:
> > net/sched/sch_qfq.c: In function ‘qfq_dequeue’:
> > include/net/sch_generic.h:480:15: warning: ‘skb’ may be used uninitialized in this function [-Wmaybe-uninitialized]
> > net/sched/sch_qfq.c:1007:18: note: ‘skb’ was declared here
> >
> > You and I both know that SKB will be initialized at this point, but
> > the compiler can't see it clearly enough.
> >
> Unfortunately I could not reproduce the warning (with
> gcc-4.7 -Wmaybe-uninitialized). I am however about to send a new version
> with skb initialized to NULL. I hope that this fix properly addresses
> this issue.
There are actually lots of bogus warnings than seem to only occur
because gcc 4.4 does a bad job of checking. Later versions are fixed
and don't generate warnings.
My preference is to not add the unnecessary initialization because
if you get in the habit of doing it. The whole purpose of the uninitialized
check is lost.
next prev parent reply other threads:[~2012-11-20 17:54 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-12 16:48 [PATCH] pkt_sched: QFQ Plus: fair-queueing service at DRR cost Paolo Valente
2012-11-19 23:48 ` David Miller
2012-11-20 17:45 ` Paolo Valente
2012-11-20 17:53 ` Stephen Hemminger [this message]
2012-11-20 18:02 ` David Miller
2012-11-20 18:09 ` Stephen Hemminger
2012-11-20 18:15 ` David Miller
2012-11-20 18:44 ` Stephen Hemminger
2012-11-20 18:00 ` David Miller
2012-11-20 17:45 Paolo Valente
2012-11-20 18:54 ` David Miller
2012-11-21 9:45 ` Paolo Valente
2012-11-21 17:04 ` David Miller
2012-11-22 16:56 Paolo Valente
2012-11-23 19:28 ` David Miller
2012-11-23 21:02 ` Paolo Valente
2012-11-23 21:03 Paolo Valente
2012-11-28 16:20 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121120095304.420ded7c@nehalam.linuxnetplumber.net \
--to=shemminger@vyatta.com \
--cc=davem@davemloft.net \
--cc=fchecconi@gmail.com \
--cc=jhs@mojatatu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=paolo.valente@unimore.it \
--cc=rizzo@iet.unipi.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).