From: Solomon Peachy <pizza@shaftnet.org>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Ming Lei <tom.leiming@gmail.com>,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH] [firmware_class] Fix compile with no builtin firmware
Date: Tue, 20 Nov 2012 13:12:03 -0500 [thread overview]
Message-ID: <20121120181203.GA7922@shaftnet.org> (raw)
In-Reply-To: <20121120163309.GB4990@kroah.com>
[-- Attachment #1: Type: text/plain, Size: 1320 bytes --]
On Tue, Nov 20, 2012 at 08:33:09AM -0800, Greg KH wrote:
> > The corresponding .config is attached. Note that it is for a uClinux
> > 3.3.0-uc0 kernel.
>
> Lots of things have changed in the firmware code since 3.3.0, can you
> retest this on the 3.7-rc6 tree?
Not easily; My employer is contracted to do some driver porting and
we're stuck with the kernel the client provided. However, the patch is
still relevant for upstream, because the underlying problem still
exists:
* The #ifdef wraps code that pertains solely to built-in firmware, (ie
CONFIG_FIRMWARE_IN_KERNEL) and has an #else path for when it's disabled.
* There is no point in a CONFIG_FW_LOADER test inside firmware_class.c
when the file isn't even compiled unless CONFIG_FW_LOADER is defined.
Perhaps the compile problem is solved in newer kernels (by always
generating an empty builtin firmware list?) but the #ifdef is still
incorrect.
> Also, when sending patches, please cc: the proper maintainers (the
> scripts/get_maintainers.pl tool can help you with that.)
Ooops, sorry. I'll double-check that next time.
- Solomon
--
Solomon Peachy pizza at shaftnet dot org
Melbourne, FL ^^ (mail/jabber/gtalk) ^^
Quidquid latine dictum sit, altum viditur.
[-- Attachment #2: Type: application/pgp-signature, Size: 190 bytes --]
next prev parent reply other threads:[~2012-11-20 18:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-20 14:45 [PATCH] [firmware_class] Fix compile with no builtin firmware Solomon Peachy
2012-11-20 16:01 ` Ming Lei
2012-11-20 16:10 ` Solomon Peachy
2012-11-20 16:33 ` Greg KH
2012-11-20 18:12 ` Solomon Peachy [this message]
2012-11-21 1:35 ` Ming Lei
2012-11-21 14:01 ` Solomon Peachy
2012-11-22 1:45 ` Ming Lei
2012-11-22 2:15 ` Solomon Peachy
2012-11-22 2:42 ` Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121120181203.GA7922@shaftnet.org \
--to=pizza@shaftnet.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=tom.leiming@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).