linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ming Lei <tom.leiming@gmail.com>
To: Solomon Peachy <pizza@shaftnet.org>
Cc: Greg KH <gregkh@linuxfoundation.org>,
	linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH] [firmware_class] Fix compile with no builtin firmware
Date: Wed, 21 Nov 2012 09:35:28 +0800	[thread overview]
Message-ID: <20121121093528.4fe11c26@tom-ThinkPad-T410> (raw)
In-Reply-To: <20121120181203.GA7922@shaftnet.org>

On Tue, 20 Nov 2012 13:12:03 -0500
Solomon Peachy <pizza@shaftnet.org> wrote:

> On Tue, Nov 20, 2012 at 08:33:09AM -0800, Greg KH wrote:
> > > The corresponding .config is attached.  Note that it is for a uClinux 
> > > 3.3.0-uc0 kernel.
> > 
> > Lots of things have changed in the firmware code since 3.3.0, can you
> > retest this on the 3.7-rc6 tree?

Solomon, I can't duplicate the build failure with your .config on 3.7-rc5-next.

> 
> Not easily; My employer is contracted to do some driver porting and 
> we're stuck with the kernel the client provided.  However, the patch is 
> still relevant for upstream, because the underlying problem still 
> exists:
>  
>  * The #ifdef wraps code that pertains solely to built-in firmware, (ie 
>    CONFIG_FIRMWARE_IN_KERNEL) and has an #else path for when it's disabled.
>  * There is no point in a CONFIG_FW_LOADER test inside firmware_class.c 
>    when the file isn't even compiled unless CONFIG_FW_LOADER is defined.

Enabling CONFIG_EXTRA_FIRMWARE still can make one firmware built in kernel
even though CONFIG_FIRMWARE_IN_KERNEL isn't defined, so your patch will break
this case.

> 
> Perhaps the compile problem is solved in newer kernels (by always 
> generating an empty builtin firmware list?) but the #ifdef is still 
> incorrect.

Looks the problem hasn't been reported before.


Thanks,
-- 
Ming Lei

  reply	other threads:[~2012-11-21  1:35 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-20 14:45 [PATCH] [firmware_class] Fix compile with no builtin firmware Solomon Peachy
2012-11-20 16:01 ` Ming Lei
2012-11-20 16:10   ` Solomon Peachy
2012-11-20 16:33     ` Greg KH
2012-11-20 18:12       ` Solomon Peachy
2012-11-21  1:35         ` Ming Lei [this message]
2012-11-21 14:01           ` Solomon Peachy
2012-11-22  1:45             ` Ming Lei
2012-11-22  2:15               ` Solomon Peachy
2012-11-22  2:42                 ` Ming Lei

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121121093528.4fe11c26@tom-ThinkPad-T410 \
    --to=tom.leiming@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pizza@shaftnet.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).