* [PATCH] Revert "serial: omap: fix software flow control"
@ 2012-10-16 14:09 Felipe Balbi
2012-10-16 15:13 ` Tony Lindgren
2012-11-07 9:56 ` Andreas Bießmann
0 siblings, 2 replies; 7+ messages in thread
From: Felipe Balbi @ 2012-10-16 14:09 UTC (permalink / raw)
To: Greg KH
Cc: Linux Kernel Mailing List, Linux ARM Kernel Mailing List,
Linux OMAP Mailing List, linux, Santosh Shilimkar, Felipe Balbi
This reverts commit 957ee7270d632245b43f6feb0e70d9a5e9ea6cf6
(serial: omap: fix software flow control).
As Russell has pointed out, that commit isn't fixing
Software Flow Control at all, and it actually makes
it even more broken.
It was agreed to revert this commit and use Russell's
latest UART patches instead.
Cc: Russell King <linux@arm.linux.org.uk>
Signed-off-by: Felipe Balbi <balbi@ti.com>
---
Hi Greg,
you might prefer to do the revert yourself, in that case just
revert commit 957ee7270d632245b43f6feb0e70d9a5e9ea6cf6.
thanks
arch/arm/plat-omap/include/plat/omap-serial.h | 4 ++--
drivers/tty/serial/omap-serial.c | 12 ++++++------
2 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/arch/arm/plat-omap/include/plat/omap-serial.h b/arch/arm/plat-omap/include/plat/omap-serial.h
index f4a4cd0..1957a85 100644
--- a/arch/arm/plat-omap/include/plat/omap-serial.h
+++ b/arch/arm/plat-omap/include/plat/omap-serial.h
@@ -40,10 +40,10 @@
#define OMAP_UART_WER_MOD_WKUP 0X7F
/* Enable XON/XOFF flow control on output */
-#define OMAP_UART_SW_TX 0x8
+#define OMAP_UART_SW_TX 0x04
/* Enable XON/XOFF flow control on input */
-#define OMAP_UART_SW_RX 0x2
+#define OMAP_UART_SW_RX 0x04
#define OMAP_UART_SYSC_RESET 0X07
#define OMAP_UART_TCR_TRIG 0X0F
diff --git a/drivers/tty/serial/omap-serial.c b/drivers/tty/serial/omap-serial.c
index 6ede6fd..6d3d26a 100644
--- a/drivers/tty/serial/omap-serial.c
+++ b/drivers/tty/serial/omap-serial.c
@@ -671,19 +671,19 @@ serial_omap_configure_xonxoff
/*
* IXON Flag:
- * Flow control for OMAP.TX
- * OMAP.RX should listen for XON/XOFF
+ * Enable XON/XOFF flow control on output.
+ * Transmit XON1, XOFF1
*/
if (termios->c_iflag & IXON)
- up->efr |= OMAP_UART_SW_RX;
+ up->efr |= OMAP_UART_SW_TX;
/*
* IXOFF Flag:
- * Flow control for OMAP.RX
- * OMAP.TX should send XON/XOFF
+ * Enable XON/XOFF flow control on input.
+ * Receiver compares XON1, XOFF1.
*/
if (termios->c_iflag & IXOFF)
- up->efr |= OMAP_UART_SW_TX;
+ up->efr |= OMAP_UART_SW_RX;
serial_out(up, UART_EFR, up->efr | UART_EFR_ECB);
serial_out(up, UART_LCR, UART_LCR_CONF_MODE_A);
--
1.8.0.rc0
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] Revert "serial: omap: fix software flow control"
2012-10-16 14:09 [PATCH] Revert "serial: omap: fix software flow control" Felipe Balbi
@ 2012-10-16 15:13 ` Tony Lindgren
2012-10-24 10:02 ` Felipe Balbi
2012-11-07 9:56 ` Andreas Bießmann
1 sibling, 1 reply; 7+ messages in thread
From: Tony Lindgren @ 2012-10-16 15:13 UTC (permalink / raw)
To: Felipe Balbi
Cc: Greg KH, Linux Kernel Mailing List,
Linux ARM Kernel Mailing List, Linux OMAP Mailing List, linux,
Santosh Shilimkar
* Felipe Balbi <balbi@ti.com> [121016 07:16]:
> This reverts commit 957ee7270d632245b43f6feb0e70d9a5e9ea6cf6
> (serial: omap: fix software flow control).
>
> As Russell has pointed out, that commit isn't fixing
> Software Flow Control at all, and it actually makes
> it even more broken.
>
> It was agreed to revert this commit and use Russell's
> latest UART patches instead.
>
> Cc: Russell King <linux@arm.linux.org.uk>
> Signed-off-by: Felipe Balbi <balbi@ti.com>
This seems like the best way to go for the -rc series:
Acked-by: Tony Lindgren <tony@atomide.com>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] Revert "serial: omap: fix software flow control"
2012-10-16 15:13 ` Tony Lindgren
@ 2012-10-24 10:02 ` Felipe Balbi
2012-10-24 18:57 ` Greg KH
0 siblings, 1 reply; 7+ messages in thread
From: Felipe Balbi @ 2012-10-24 10:02 UTC (permalink / raw)
To: Tony Lindgren
Cc: Felipe Balbi, Greg KH, Linux Kernel Mailing List,
Linux ARM Kernel Mailing List, Linux OMAP Mailing List, linux,
Santosh Shilimkar
[-- Attachment #1: Type: text/plain, Size: 776 bytes --]
Hi Greg,
On Tue, Oct 16, 2012 at 08:13:59AM -0700, Tony Lindgren wrote:
> * Felipe Balbi <balbi@ti.com> [121016 07:16]:
> > This reverts commit 957ee7270d632245b43f6feb0e70d9a5e9ea6cf6
> > (serial: omap: fix software flow control).
> >
> > As Russell has pointed out, that commit isn't fixing
> > Software Flow Control at all, and it actually makes
> > it even more broken.
> >
> > It was agreed to revert this commit and use Russell's
> > latest UART patches instead.
> >
> > Cc: Russell King <linux@arm.linux.org.uk>
> > Signed-off-by: Felipe Balbi <balbi@ti.com>
>
> This seems like the best way to go for the -rc series:
>
> Acked-by: Tony Lindgren <tony@atomide.com>
Any chance you can pick this one up for v3.7-rc3 ?
cheers
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] Revert "serial: omap: fix software flow control"
2012-10-24 18:57 ` Greg KH
@ 2012-10-24 18:53 ` Felipe Balbi
0 siblings, 0 replies; 7+ messages in thread
From: Felipe Balbi @ 2012-10-24 18:53 UTC (permalink / raw)
To: Greg KH
Cc: Felipe Balbi, Tony Lindgren, Linux Kernel Mailing List,
Linux ARM Kernel Mailing List, Linux OMAP Mailing List, linux,
Santosh Shilimkar
[-- Attachment #1: Type: text/plain, Size: 1050 bytes --]
On Wed, Oct 24, 2012 at 11:57:42AM -0700, Greg KH wrote:
> On Wed, Oct 24, 2012 at 01:02:55PM +0300, Felipe Balbi wrote:
> > Hi Greg,
> >
> > On Tue, Oct 16, 2012 at 08:13:59AM -0700, Tony Lindgren wrote:
> > > * Felipe Balbi <balbi@ti.com> [121016 07:16]:
> > > > This reverts commit 957ee7270d632245b43f6feb0e70d9a5e9ea6cf6
> > > > (serial: omap: fix software flow control).
> > > >
> > > > As Russell has pointed out, that commit isn't fixing
> > > > Software Flow Control at all, and it actually makes
> > > > it even more broken.
> > > >
> > > > It was agreed to revert this commit and use Russell's
> > > > latest UART patches instead.
> > > >
> > > > Cc: Russell King <linux@arm.linux.org.uk>
> > > > Signed-off-by: Felipe Balbi <balbi@ti.com>
> > >
> > > This seems like the best way to go for the -rc series:
> > >
> > > Acked-by: Tony Lindgren <tony@atomide.com>
> >
> > Any chance you can pick this one up for v3.7-rc3 ?
>
> Now queued up, sorry for the delay.
no problems, thanks a lot.
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] Revert "serial: omap: fix software flow control"
2012-10-24 10:02 ` Felipe Balbi
@ 2012-10-24 18:57 ` Greg KH
2012-10-24 18:53 ` Felipe Balbi
0 siblings, 1 reply; 7+ messages in thread
From: Greg KH @ 2012-10-24 18:57 UTC (permalink / raw)
To: Felipe Balbi
Cc: Tony Lindgren, Linux Kernel Mailing List,
Linux ARM Kernel Mailing List, Linux OMAP Mailing List, linux,
Santosh Shilimkar
On Wed, Oct 24, 2012 at 01:02:55PM +0300, Felipe Balbi wrote:
> Hi Greg,
>
> On Tue, Oct 16, 2012 at 08:13:59AM -0700, Tony Lindgren wrote:
> > * Felipe Balbi <balbi@ti.com> [121016 07:16]:
> > > This reverts commit 957ee7270d632245b43f6feb0e70d9a5e9ea6cf6
> > > (serial: omap: fix software flow control).
> > >
> > > As Russell has pointed out, that commit isn't fixing
> > > Software Flow Control at all, and it actually makes
> > > it even more broken.
> > >
> > > It was agreed to revert this commit and use Russell's
> > > latest UART patches instead.
> > >
> > > Cc: Russell King <linux@arm.linux.org.uk>
> > > Signed-off-by: Felipe Balbi <balbi@ti.com>
> >
> > This seems like the best way to go for the -rc series:
> >
> > Acked-by: Tony Lindgren <tony@atomide.com>
>
> Any chance you can pick this one up for v3.7-rc3 ?
Now queued up, sorry for the delay.
greg k-h
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] Revert "serial: omap: fix software flow control"
2012-10-16 14:09 [PATCH] Revert "serial: omap: fix software flow control" Felipe Balbi
2012-10-16 15:13 ` Tony Lindgren
@ 2012-11-07 9:56 ` Andreas Bießmann
2012-11-21 20:21 ` Greg KH
1 sibling, 1 reply; 7+ messages in thread
From: Andreas Bießmann @ 2012-11-07 9:56 UTC (permalink / raw)
To: Felipe Balbi
Cc: Greg KH, linux, Linux Kernel Mailing List, Santosh Shilimkar,
Linux OMAP Mailing List, Linux ARM Kernel Mailing List, stable
On 16.10.2012 16:09, Felipe Balbi wrote:
> This reverts commit 957ee7270d632245b43f6feb0e70d9a5e9ea6cf6
> (serial: omap: fix software flow control).
>
> As Russell has pointed out, that commit isn't fixing
> Software Flow Control at all, and it actually makes
> it even more broken.
>
> It was agreed to revert this commit and use Russell's
> latest UART patches instead.
>
> Cc: Russell King <linux@arm.linux.org.uk>
> Signed-off-by: Felipe Balbi <balbi@ti.com>
since 957ee7270d632245b43f6feb0e70d9a5e9ea6cf6 made it into stable (at
least 3.4) I think it would be good decision to also apply this revert
to stable until a working solution exists.
Best regards
Andreas Bießmann
> ---
>
> Hi Greg,
>
> you might prefer to do the revert yourself, in that case just
> revert commit 957ee7270d632245b43f6feb0e70d9a5e9ea6cf6.
>
> thanks
>
> arch/arm/plat-omap/include/plat/omap-serial.h | 4 ++--
> drivers/tty/serial/omap-serial.c | 12 ++++++------
> 2 files changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/arch/arm/plat-omap/include/plat/omap-serial.h b/arch/arm/plat-omap/include/plat/omap-serial.h
> index f4a4cd0..1957a85 100644
> --- a/arch/arm/plat-omap/include/plat/omap-serial.h
> +++ b/arch/arm/plat-omap/include/plat/omap-serial.h
> @@ -40,10 +40,10 @@
> #define OMAP_UART_WER_MOD_WKUP 0X7F
>
> /* Enable XON/XOFF flow control on output */
> -#define OMAP_UART_SW_TX 0x8
> +#define OMAP_UART_SW_TX 0x04
>
> /* Enable XON/XOFF flow control on input */
> -#define OMAP_UART_SW_RX 0x2
> +#define OMAP_UART_SW_RX 0x04
>
> #define OMAP_UART_SYSC_RESET 0X07
> #define OMAP_UART_TCR_TRIG 0X0F
> diff --git a/drivers/tty/serial/omap-serial.c b/drivers/tty/serial/omap-serial.c
> index 6ede6fd..6d3d26a 100644
> --- a/drivers/tty/serial/omap-serial.c
> +++ b/drivers/tty/serial/omap-serial.c
> @@ -671,19 +671,19 @@ serial_omap_configure_xonxoff
>
> /*
> * IXON Flag:
> - * Flow control for OMAP.TX
> - * OMAP.RX should listen for XON/XOFF
> + * Enable XON/XOFF flow control on output.
> + * Transmit XON1, XOFF1
> */
> if (termios->c_iflag & IXON)
> - up->efr |= OMAP_UART_SW_RX;
> + up->efr |= OMAP_UART_SW_TX;
>
> /*
> * IXOFF Flag:
> - * Flow control for OMAP.RX
> - * OMAP.TX should send XON/XOFF
> + * Enable XON/XOFF flow control on input.
> + * Receiver compares XON1, XOFF1.
> */
> if (termios->c_iflag & IXOFF)
> - up->efr |= OMAP_UART_SW_TX;
> + up->efr |= OMAP_UART_SW_RX;
>
> serial_out(up, UART_EFR, up->efr | UART_EFR_ECB);
> serial_out(up, UART_LCR, UART_LCR_CONF_MODE_A);
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] Revert "serial: omap: fix software flow control"
2012-11-07 9:56 ` Andreas Bießmann
@ 2012-11-21 20:21 ` Greg KH
0 siblings, 0 replies; 7+ messages in thread
From: Greg KH @ 2012-11-21 20:21 UTC (permalink / raw)
To: Andreas Bießmann
Cc: Felipe Balbi, linux, Linux Kernel Mailing List,
Santosh Shilimkar, Linux OMAP Mailing List,
Linux ARM Kernel Mailing List, stable
On Wed, Nov 07, 2012 at 10:56:59AM +0100, Andreas Bießmann wrote:
> On 16.10.2012 16:09, Felipe Balbi wrote:
> > This reverts commit 957ee7270d632245b43f6feb0e70d9a5e9ea6cf6
> > (serial: omap: fix software flow control).
> >
> > As Russell has pointed out, that commit isn't fixing
> > Software Flow Control at all, and it actually makes
> > it even more broken.
> >
> > It was agreed to revert this commit and use Russell's
> > latest UART patches instead.
> >
> > Cc: Russell King <linux@arm.linux.org.uk>
> > Signed-off-by: Felipe Balbi <balbi@ti.com>
>
> since 957ee7270d632245b43f6feb0e70d9a5e9ea6cf6 made it into stable (at
> least 3.4) I think it would be good decision to also apply this revert
> to stable until a working solution exists.
Now queued up for the stable releases, thanks.
greg k-h
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2012-11-21 20:21 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-10-16 14:09 [PATCH] Revert "serial: omap: fix software flow control" Felipe Balbi
2012-10-16 15:13 ` Tony Lindgren
2012-10-24 10:02 ` Felipe Balbi
2012-10-24 18:57 ` Greg KH
2012-10-24 18:53 ` Felipe Balbi
2012-11-07 9:56 ` Andreas Bießmann
2012-11-21 20:21 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).