* Re: [PATCH] serial: ifx6x60: Add modem power off function in the platform reboot process
2012-11-22 11:19 [PATCH] serial: ifx6x60: Add modem power off function in the platform reboot process Jun Chen
@ 2012-11-22 11:08 ` Alan Cox
2012-11-23 11:14 ` Jun Chen
0 siblings, 1 reply; 4+ messages in thread
From: Alan Cox @ 2012-11-22 11:08 UTC (permalink / raw)
To: Jun Chen; +Cc: Bi Chao, serial, Linux Kernel, russ.gorby
On Thu, 22 Nov 2012 06:19:23 -0500
Jun Chen <jun.d.chen@intel.com> wrote:
>
> This patch add modem power off function in the reboot process
> according registering reboot callback to the reboot_notifier_list.
> Also realizing the spi shutdown function.
Need to unregister the reboot notifier in the ifx_spi_exit path. If the
driver module is unloaded you leave the callback present and the kernel
will call into freed memory.
Alan
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] serial: ifx6x60: Add modem power off function in the platform reboot process
@ 2012-11-22 11:19 Jun Chen
2012-11-22 11:08 ` Alan Cox
0 siblings, 1 reply; 4+ messages in thread
From: Jun Chen @ 2012-11-22 11:19 UTC (permalink / raw)
To: Alan Cox; +Cc: Bi Chao, Jun Chen, serial, Linux Kernel, russ.gorby
This patch add modem power off function in the reboot process according registering
reboot callback to the reboot_notifier_list. Also realizing the spi shutdown function.
Signed-off-by: Bi Chao <chao.bi@intel.com>
Signed-off-by: Chen Jun <jun.d.chen@intel.com>
---
drivers/tty/serial/ifx6x60.c | 39 +++++++++++++++++++++++++++++++++++++++
1 files changed, 39 insertions(+), 0 deletions(-)
diff --git a/drivers/tty/serial/ifx6x60.c b/drivers/tty/serial/ifx6x60.c
index 5b9bc19..a91f4cb 100644
--- a/drivers/tty/serial/ifx6x60.c
+++ b/drivers/tty/serial/ifx6x60.c
@@ -60,6 +60,7 @@
#include <linux/pm_runtime.h>
#include <linux/spi/ifx_modem.h>
#include <linux/delay.h>
+#include <linux/reboot.h>
#include "ifx6x60.h"
@@ -72,8 +73,14 @@
#define IFX_SPI_HEADER_0 (-1)
#define IFX_SPI_HEADER_F (-2)
+#define PO_POST_DELAY 200
+#define IFX_MDM_RST_PMU 4
+
/* forward reference */
static void ifx_spi_handle_srdy(struct ifx_spi_device *ifx_dev);
+static int ifx_modem_reboot_callback(struct notifier_block *nfb,
+ unsigned long event, void *data);
+static int ifx_modem_power_off(struct ifx_spi_device *ifx_dev);
/* local variables */
static int spi_bpw = 16; /* 8, 16 or 32 bit word length */
@@ -81,6 +88,29 @@ static struct tty_driver *tty_drv;
static struct ifx_spi_device *saved_ifx_dev;
static struct lock_class_key ifx_spi_key;
+static struct notifier_block ifx_modem_reboot_notifier_block = {
+ .notifier_call = ifx_modem_reboot_callback,
+};
+
+static int ifx_modem_power_off(struct ifx_spi_device *ifx_dev)
+{
+ gpio_set_value(IFX_MDM_RST_PMU, 1);
+ msleep(PO_POST_DELAY);
+
+ return 0;
+}
+
+static int ifx_modem_reboot_callback(struct notifier_block *nfb,
+ unsigned long event, void *data)
+{
+ if (saved_ifx_dev)
+ ifx_modem_power_off(saved_ifx_dev);
+ else
+ pr_warn("no ifx modem active \n");
+
+ return NOTIFY_OK;
+}
+
/* GPIO/GPE settings */
/**
@@ -1219,6 +1249,9 @@ static int ifx_spi_spi_remove(struct spi_device *spi)
static void ifx_spi_spi_shutdown(struct spi_device *spi)
{
+ struct ifx_spi_device *ifx_dev = spi_get_drvdata(spi);
+
+ ifx_modem_power_off(ifx_dev);
}
/*
@@ -1368,6 +1401,7 @@ static void __exit ifx_spi_exit(void)
static int __init ifx_spi_init(void)
{
int result;
+ int ret;
tty_drv = alloc_tty_driver(1);
if (!tty_drv) {
@@ -1399,6 +1433,11 @@ static int __init ifx_spi_init(void)
DRVNAME, result);
tty_unregister_driver(tty_drv);
}
+
+ ret = register_reboot_notifier(&ifx_modem_reboot_notifier_block);
+ if (ret)
+ pr_err("cannot register reboot notifier (err=%d)\n", ret);
+
return result;
}
--
1.7.4.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] serial: ifx6x60: Add modem power off function in the platform reboot process
2012-11-22 11:08 ` Alan Cox
@ 2012-11-23 11:14 ` Jun Chen
0 siblings, 0 replies; 4+ messages in thread
From: Jun Chen @ 2012-11-23 11:14 UTC (permalink / raw)
To: Alan Cox; +Cc: Bi Chao, serial, Linux Kernel, russ.gorby
On Thu, 2012-11-22 at 11:08 +0000, Alan Cox wrote:
> On Thu, 22 Nov 2012 06:19:23 -0500
> Jun Chen <jun.d.chen@intel.com> wrote:
>
> >
> > This patch add modem power off function in the reboot process
> > according registering reboot callback to the reboot_notifier_list.
> > Also realizing the spi shutdown function.
>
> Need to unregister the reboot notifier in the ifx_spi_exit path. If the
> driver module is unloaded you leave the callback present and the kernel
> will call into freed memory.
>
> Alan
Yes,thanks! I will update this patch again.
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] serial: ifx6x60: Add modem power off function in the platform reboot process
@ 2012-11-23 11:07 Jun Chen
0 siblings, 0 replies; 4+ messages in thread
From: Jun Chen @ 2012-11-23 11:07 UTC (permalink / raw)
To: Alan Cox; +Cc: Jun Chen, Linux Kernel, russ.gorby, serial, Bi Chao
This patch add modem power off function in the reboot process according registering
reboot callback to the reboot_notifier_list. Also realizing the spi shutdown function.
Signed-off-by: Bi Chao <chao.bi@intel.com>
Signed-off-by: Chen Jun <jun.d.chen@intel.com>
---
drivers/tty/serial/ifx6x60.c | 56 +++++++++++++++++++++++++++++++++++++++--
1 files changed, 53 insertions(+), 3 deletions(-)
diff --git a/drivers/tty/serial/ifx6x60.c b/drivers/tty/serial/ifx6x60.c
index 5b9bc19..f3c54e9 100644
--- a/drivers/tty/serial/ifx6x60.c
+++ b/drivers/tty/serial/ifx6x60.c
@@ -60,6 +60,7 @@
#include <linux/pm_runtime.h>
#include <linux/spi/ifx_modem.h>
#include <linux/delay.h>
+#include <linux/reboot.h>
#include "ifx6x60.h"
@@ -72,8 +73,14 @@
#define IFX_SPI_HEADER_0 (-1)
#define IFX_SPI_HEADER_F (-2)
+#define PO_POST_DELAY 200
+#define IFX_MDM_RST_PMU 4
+
/* forward reference */
static void ifx_spi_handle_srdy(struct ifx_spi_device *ifx_dev);
+static int ifx_modem_reboot_callback(struct notifier_block *nfb,
+ unsigned long event, void *data);
+static int ifx_modem_power_off(struct ifx_spi_device *ifx_dev);
/* local variables */
static int spi_bpw = 16; /* 8, 16 or 32 bit word length */
@@ -81,6 +88,29 @@ static struct tty_driver *tty_drv;
static struct ifx_spi_device *saved_ifx_dev;
static struct lock_class_key ifx_spi_key;
+static struct notifier_block ifx_modem_reboot_notifier_block = {
+ .notifier_call = ifx_modem_reboot_callback,
+};
+
+static int ifx_modem_power_off(struct ifx_spi_device *ifx_dev)
+{
+ gpio_set_value(IFX_MDM_RST_PMU, 1);
+ msleep(PO_POST_DELAY);
+
+ return 0;
+}
+
+static int ifx_modem_reboot_callback(struct notifier_block *nfb,
+ unsigned long event, void *data)
+{
+ if (saved_ifx_dev)
+ ifx_modem_power_off(saved_ifx_dev);
+ else
+ pr_warn("no ifx modem active;\n");
+
+ return NOTIFY_OK;
+}
+
/* GPIO/GPE settings */
/**
@@ -1219,6 +1249,9 @@ static int ifx_spi_spi_remove(struct spi_device *spi)
static void ifx_spi_spi_shutdown(struct spi_device *spi)
{
+ struct ifx_spi_device *ifx_dev = spi_get_drvdata(spi);
+
+ ifx_modem_power_off(ifx_dev);
}
/*
@@ -1354,7 +1387,9 @@ static void __exit ifx_spi_exit(void)
{
/* unregister */
tty_unregister_driver(tty_drv);
+ put_tty_driver(tty_drv);
spi_unregister_driver((void *)&ifx_spi_driver);
+ unregister_reboot_notifier(&ifx_modem_reboot_notifier_block);
}
/**
@@ -1389,16 +1424,31 @@ static int __init ifx_spi_init(void)
if (result) {
pr_err("%s: tty_register_driver failed(%d)",
DRVNAME, result);
- put_tty_driver(tty_drv);
- return result;
+ goto err_free_tty;
}
result = spi_register_driver((void *)&ifx_spi_driver);
if (result) {
pr_err("%s: spi_register_driver failed(%d)",
DRVNAME, result);
- tty_unregister_driver(tty_drv);
+ goto err_unreg_tty;
+ }
+
+ result = register_reboot_notifier(&ifx_modem_reboot_notifier_block);
+ if (result) {
+ pr_err("%s: register ifx modem reboot notifier failed(%d)",
+ DRVNAME, result);
+ goto err_unreg_spi;
}
+
+ return 0;
+err_unreg_spi:
+ spi_unregister_driver((void *)&ifx_spi_driver);
+err_unreg_tty:
+ tty_unregister_driver(tty_drv);
+err_free_tty:
+ put_tty_driver(tty_drv);
+
return result;
}
--
1.7.4.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-11-23 3:11 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-11-22 11:19 [PATCH] serial: ifx6x60: Add modem power off function in the platform reboot process Jun Chen
2012-11-22 11:08 ` Alan Cox
2012-11-23 11:14 ` Jun Chen
2012-11-23 11:07 Jun Chen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).