From: Lee Jones <lee.jones@linaro.org>
To: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Cc: arnd@arndb.de, linus.walleij@stericsson.com,
Jonas Aaberg <jonas.aberg@stericsson.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
linux-input@vger.kernel.org,
Philippe Langlais <philippe.langlais@linaro.org>
Subject: Re: [PATCH 2/2] input: gpio-keys: Add runtime support
Date: Thu, 22 Nov 2012 14:51:53 +0000 [thread overview]
Message-ID: <20121122145153.GB10986@gmail.com> (raw)
In-Reply-To: <1353590617-11466-2-git-send-email-lee.jones@linaro.org>
Ignore this.
I've just rebased and the API has changed slightly.
Will fixup and resend.
> From: Jonas Aaberg <jonas.aberg@stericsson.com>
>
> Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> Cc: linux-input@vger.kernel.org
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
> Signed-off-by: Jonas Aaberg <jonas.aberg@stericsson.com>
> Signed-off-by: Philippe Langlais <philippe.langlais@linaro.org>
> Reviewed-by: Bengt Jonsson <bengt.g.jonsson@stericsson.com>
> ---
> drivers/input/keyboard/gpio_keys.c | 17 +++++++++++++----
> 1 file changed, 13 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/input/keyboard/gpio_keys.c b/drivers/input/keyboard/gpio_keys.c
> index 2cf6757..cff548c 100644
> --- a/drivers/input/keyboard/gpio_keys.c
> +++ b/drivers/input/keyboard/gpio_keys.c
> @@ -29,6 +29,7 @@
> #include <linux/of_platform.h>
> #include <linux/of_gpio.h>
> #include <linux/spinlock.h>
> +#include <linux/pm_runtime.h>
>
> struct gpio_button_data {
> const struct gpio_keys_button *button;
> @@ -533,6 +534,7 @@ static int gpio_keys_open(struct input_dev *input)
> struct gpio_keys_drvdata *ddata = input_get_drvdata(input);
> const struct gpio_keys_platform_data *pdata = ddata->pdata;
>
> + pm_runtime_get_sync(input->dev.parent);
> ddata->enabled = true;
>
> return pdata->enable ? pdata->enable(input->dev.parent) : 0;
> @@ -547,6 +549,8 @@ static void gpio_keys_close(struct input_dev *input)
>
> if (pdata->disable)
> pdata->disable(input->dev.parent);
> +
> + pm_runtime_put(input->dev.parent);
> }
>
> /*
> @@ -708,6 +712,8 @@ static int __devinit gpio_keys_probe(struct platform_device *pdev)
> input->id.product = 0x0001;
> input->id.version = 0x0100;
>
> + pm_runtime_enable(&pdev->dev);
> +
> /* Enable auto repeat feature of Linux input subsystem */
> if (pdata->rep)
> __set_bit(EV_REP, input->evbit);
> @@ -773,6 +779,8 @@ static int __devexit gpio_keys_remove(struct platform_device *pdev)
> struct input_dev *input = ddata->input;
> int i;
>
> + pm_runtime_disable(&pdev->dev);
> +
> sysfs_remove_group(&pdev->dev.kobj, &gpio_keys_attr_group);
>
> device_init_wakeup(&pdev->dev, 0);
> @@ -805,8 +813,8 @@ static int gpio_keys_suspend(struct device *dev)
> }
> } else {
> ddata->enable_after_suspend = ddata->enabled;
> - if (ddata->enabled)
> - gpio_keys_close(ddata->input);
> + if (ddata->enabled && ddata->disable)
> + ddata->disable(dev);
> }
>
> return 0;
> @@ -826,8 +834,9 @@ static int gpio_keys_resume(struct device *dev)
> gpio_keys_gpio_report_event(bdata);
> }
>
> - if (!device_may_wakeup(dev) && ddata->enable_after_suspend)
> - gpio_keys_open(ddata->input);
> + if (!device_may_wakeup(dev) && ddata->enable_after_suspend
> + && ddata->enable)
> + ddata->enable(dev);
>
> input_sync(ddata->input);
>
> --
> 1.7.9.5
>
--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2012-11-22 18:56 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-22 13:23 [PATCH 1/2] input: gpio-keys: Disable hardware on suspend Lee Jones
2012-11-22 13:23 ` [PATCH 2/2] input: gpio-keys: Add runtime support Lee Jones
2012-11-22 14:51 ` Lee Jones [this message]
2012-11-25 8:32 ` [PATCH 1/2] input: gpio-keys: Disable hardware on suspend Dmitry Torokhov
2012-11-26 9:05 ` Lee Jones
2012-11-26 9:32 ` Dmitry Torokhov
2012-12-01 17:01 ` Linus Walleij
-- strict thread matches above, loose matches on Subject: below --
2012-10-11 14:15 Lee Jones
2012-10-11 14:15 ` [PATCH 2/2] input: gpio-keys: Add runtime support Lee Jones
2012-10-11 14:22 ` Shubhrajyoti Datta
2012-10-11 15:21 ` Lee Jones
2012-10-12 21:09 ` Linus Walleij
2012-10-25 7:57 ` Lee Jones
2012-10-25 8:01 ` Linus Walleij
2012-10-25 8:21 ` Lee Jones
2012-10-25 8:30 ` Dmitry Torokhov
2012-10-25 9:47 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121122145153.GB10986@gmail.com \
--to=lee.jones@linaro.org \
--cc=arnd@arndb.de \
--cc=dmitry.torokhov@gmail.com \
--cc=jonas.aberg@stericsson.com \
--cc=linus.walleij@stericsson.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=philippe.langlais@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).