linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] USB: chipidea: promote error code from ci_role_start() start instead of returning -ENODEV
@ 2012-11-22  9:11 Lothar Waßmann
  2012-11-23  7:01 ` Peter Chen
  0 siblings, 1 reply; 2+ messages in thread
From: Lothar Waßmann @ 2012-11-22  9:11 UTC (permalink / raw)
  To: Alexander Shishkin
  Cc: Greg Kroah-Hartman, linux-kernel, linux-usb, Lothar Waßmann


Signed-off-by: Lothar Waßmann <LW@KARO-electronics.de>
---
 drivers/usb/chipidea/core.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/drivers/usb/chipidea/core.c b/drivers/usb/chipidea/core.c
index b726c49..bd6e7a4 100644
--- a/drivers/usb/chipidea/core.c
+++ b/drivers/usb/chipidea/core.c
@@ -479,7 +479,6 @@ static int __devinit ci_hdrc_probe(struct platform_device *pdev)
 	ret = ci_role_start(ci, ci->role);
 	if (ret) {
 		dev_err(dev, "can't start %s role\n", ci_role(ci)->name);
-		ret = -ENODEV;
 		goto rm_wq;
 	}
 
-- 
1.7.2.5


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] USB: chipidea: promote error code from ci_role_start() start instead of returning -ENODEV
  2012-11-22  9:11 [PATCH] USB: chipidea: promote error code from ci_role_start() start instead of returning -ENODEV Lothar Waßmann
@ 2012-11-23  7:01 ` Peter Chen
  0 siblings, 0 replies; 2+ messages in thread
From: Peter Chen @ 2012-11-23  7:01 UTC (permalink / raw)
  To: Lothar Waßmann
  Cc: Alexander Shishkin, Greg Kroah-Hartman, linux-kernel, linux-usb

On Thu, Nov 22, 2012 at 10:11:31AM +0100, Lothar Waßmann wrote:
> 
> Signed-off-by: Lothar Waßmann <LW@KARO-electronics.de>
> ---
>  drivers/usb/chipidea/core.c |    3 +--
>  1 files changed, 1 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/usb/chipidea/core.c b/drivers/usb/chipidea/core.c
> index b726c49..bd6e7a4 100644
> --- a/drivers/usb/chipidea/core.c
> +++ b/drivers/usb/chipidea/core.c
> @@ -479,7 +479,6 @@ static int __devinit ci_hdrc_probe(struct platform_device *pdev)
>  	ret = ci_role_start(ci, ci->role);
>  	if (ret) {
>  		dev_err(dev, "can't start %s role\n", ci_role(ci)->name);
> -		ret = -ENODEV;
>  		goto rm_wq;
>  	}
Any reasons?
>  
> -- 
> 1.7.2.5
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-usb" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

-- 

Best Regards,
Peter Chen


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2012-11-23  7:01 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-11-22  9:11 [PATCH] USB: chipidea: promote error code from ci_role_start() start instead of returning -ENODEV Lothar Waßmann
2012-11-23  7:01 ` Peter Chen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).