From: Lee Jones <lee.jones@linaro.org>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: sameo@linux.intel.com, devicetree-discuss@lists.ozlabs.org,
linux-kernel@vger.kernel.org, spear-devel@list.st.com,
Vipul Kumar Samar <vipulkumar.samar@st.com>
Subject: Re: [PATCH V2 2/2] mfd: stmpe: Extend DT support in stmpe driver
Date: Fri, 23 Nov 2012 09:39:31 +0000 [thread overview]
Message-ID: <20121123093931.GE17471@gmail.com> (raw)
In-Reply-To: <CAKohpo=7NRGH+XcgY3Adb8pestDLCnFiTJ-B3P61QAHN4Y_Kvg@mail.gmail.com>
On Fri, 23 Nov 2012, Viresh Kumar wrote:
> On 22 November 2012 16:54, Lee Jones <lee.jones@linaro.org> wrote:
> >> diff --git a/Documentation/devicetree/bindings/mfd/stmpe.txt b/Documentation/devicetree/bindings/mfd/stmpe.txt
> >> +Optional properties:
> >> +- irq-trigger: IRQ trigger to use for the interrupt to the host
> >> +- irq-invert-polarity: bool, IRQ line is connected with reversed polarity
> >
> > Are these new?
> >
> > When adding new bindings, ask yourself:
>
> I was trying to get information of these two bindings from other sources,
> but couldn't find. The only other place can be the interrupts field, right?
Bingo. Continue along this thread.
> Because interrupts field depends on the interrupt controller, which can
> be a wide variety of controllers in our case, we can't use that. Also,
> the cells of interrupts field will have something that is required to be
> programmed in the interrupt controller and not in the user of IC.
>
> But here we are talking about programming stmpe and so these bindings
> are very much required in stmpe only.
Not true.
Hint: `git grep triggered -- Documentation/devicetree/`
--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2012-11-23 9:39 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-22 5:10 [PATCH V2 1/2] mfd: stmpe: Use devm_*() routines Viresh Kumar
2012-11-22 5:10 ` [PATCH V2 2/2] mfd: stmpe: Extend DT support in stmpe driver Viresh Kumar
2012-11-22 11:24 ` Lee Jones
2012-11-22 13:54 ` Viresh Kumar
2012-11-22 15:46 ` Lee Jones
2012-11-22 17:01 ` Viresh Kumar
2012-11-23 3:45 ` Shiraz Hashim
2012-11-23 9:33 ` Lee Jones
2012-11-23 9:23 ` Lee Jones
2012-11-22 18:31 ` Viresh Kumar
2012-11-23 9:39 ` Lee Jones [this message]
2012-11-23 4:29 ` Viresh Kumar
2012-11-23 9:36 ` Lee Jones
2012-11-23 12:39 ` Viresh Kumar
2012-11-23 15:43 ` Lee Jones
2012-11-23 15:45 ` Viresh Kumar
2012-11-22 10:27 ` [PATCH V2 1/2] mfd: stmpe: Use devm_*() routines Lee Jones
2012-11-22 10:30 ` Viresh Kumar
2012-11-22 17:10 ` Viresh Kumar
2012-11-23 9:40 ` Lee Jones
2012-11-23 9:42 ` Lee Jones
2012-11-23 9:44 ` Viresh Kumar
2012-11-23 11:03 ` Samuel Ortiz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121123093931.GE17471@gmail.com \
--to=lee.jones@linaro.org \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sameo@linux.intel.com \
--cc=spear-devel@list.st.com \
--cc=vipulkumar.samar@st.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).