* [PATCH] regulator: max8973: provide enable/disable if external control disabled
@ 2012-11-23 8:37 Laxman Dewangan
2012-11-23 12:17 ` Mark Brown
0 siblings, 1 reply; 2+ messages in thread
From: Laxman Dewangan @ 2012-11-23 8:37 UTC (permalink / raw)
To: broonie, lrg; +Cc: linux-kernel, Laxman Dewangan
If external control is enabled then do not provide regulator
enable/disable apis.
Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
---
drivers/regulator/max8973-regulator.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/regulator/max8973-regulator.c b/drivers/regulator/max8973-regulator.c
index 140ff9d..3ee2638 100644
--- a/drivers/regulator/max8973-regulator.c
+++ b/drivers/regulator/max8973-regulator.c
@@ -398,7 +398,7 @@ static int __devinit max8973_probe(struct i2c_client *client,
max->desc.uV_step = MAX8973_VOLATGE_STEP;
max->desc.n_voltages = MAX8973_BUCK_N_VOLTAGE;
- if (pdata->enable_ext_control) {
+ if (!pdata->enable_ext_control) {
max->desc.enable_reg = MAX8973_VOUT;
max->desc.enable_mask = MAX8973_VOUT_ENABLE;
max8973_dcdc_ops.enable = regulator_enable_regmap;
--
1.7.1.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] regulator: max8973: provide enable/disable if external control disabled
2012-11-23 8:37 [PATCH] regulator: max8973: provide enable/disable if external control disabled Laxman Dewangan
@ 2012-11-23 12:17 ` Mark Brown
0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2012-11-23 12:17 UTC (permalink / raw)
To: Laxman Dewangan; +Cc: lrg, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 169 bytes --]
On Fri, Nov 23, 2012 at 02:07:42PM +0530, Laxman Dewangan wrote:
> If external control is enabled then do not provide regulator
> enable/disable apis.
Applied, thanks.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-11-23 12:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-11-23 8:37 [PATCH] regulator: max8973: provide enable/disable if external control disabled Laxman Dewangan
2012-11-23 12:17 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).