* [PATCH] staging: line6: Fix checkpatch.pl switch - case issue
@ 2012-11-29 11:21 Laurent Navet [Mali]
2012-11-30 2:08 ` Greg KH
0 siblings, 1 reply; 3+ messages in thread
From: Laurent Navet [Mali] @ 2012-11-29 11:21 UTC (permalink / raw)
To: devel; +Cc: linux-kernel, gregkh, Laurent Navet [Mali]
From: "Laurent Navet [Mali]" <laurent.navet@gmail.com>
delete old commentted code to avoid this checkpatch error :
line6/pcm.c:423: ERROR: switch and case should be at the same indent
Signed-off-by: Laurent Navet [Mali] <laurent.navet@gmail.com>
---
drivers/staging/line6/pcm.c | 8 --------
1 file changed, 8 deletions(-)
diff --git a/drivers/staging/line6/pcm.c b/drivers/staging/line6/pcm.c
index 6c1e313..a0ce781 100644
--- a/drivers/staging/line6/pcm.c
+++ b/drivers/staging/line6/pcm.c
@@ -455,14 +455,6 @@ int line6_init_pcm(struct usb_line6 *line6,
ep_write = 0x01;
break;
- /* this is for interface_number == 1:
- case LINE6_DEVID_TONEPORT_UX2:
- case LINE6_DEVID_PODSTUDIO_UX2:
- ep_read = 0x87;
- ep_write = 0x00;
- break;
- */
-
default:
MISSING_CASE;
}
--
1.7.10.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: line6: Fix checkpatch.pl switch - case issue
2012-11-29 11:21 [PATCH] staging: line6: Fix checkpatch.pl switch - case issue Laurent Navet [Mali]
@ 2012-11-30 2:08 ` Greg KH
[not found] ` <CAH7P7NhO1Qg=g7VKOFcO5jCQc+u5CPoH9L-y2S=q3BtMFYghkQ@mail.gmail.com>
0 siblings, 1 reply; 3+ messages in thread
From: Greg KH @ 2012-11-30 2:08 UTC (permalink / raw)
To: Laurent Navet [Mali]; +Cc: devel, linux-kernel
On Thu, Nov 29, 2012 at 12:21:22PM +0100, Laurent Navet [Mali] wrote:
> From: "Laurent Navet [Mali]" <laurent.navet@gmail.com>
>
> delete old commentted code to avoid this checkpatch error :
> line6/pcm.c:423: ERROR: switch and case should be at the same indent
>
> Signed-off-by: Laurent Navet [Mali] <laurent.navet@gmail.com>
What is the [Mali] thing for?
> ---
> drivers/staging/line6/pcm.c | 8 --------
> 1 file changed, 8 deletions(-)
>
> diff --git a/drivers/staging/line6/pcm.c b/drivers/staging/line6/pcm.c
> index 6c1e313..a0ce781 100644
> --- a/drivers/staging/line6/pcm.c
> +++ b/drivers/staging/line6/pcm.c
> @@ -455,14 +455,6 @@ int line6_init_pcm(struct usb_line6 *line6,
> ep_write = 0x01;
> break;
>
> - /* this is for interface_number == 1:
> - case LINE6_DEVID_TONEPORT_UX2:
> - case LINE6_DEVID_PODSTUDIO_UX2:
> - ep_read = 0x87;
> - ep_write = 0x00;
> - break;
> - */
Why not properly indent it to keep the comment around instead?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: line6: Fix checkpatch.pl switch - case issue
[not found] ` <20121130144823.GA1985@kroah.com>
@ 2012-11-30 20:36 ` Laurent Navet
0 siblings, 0 replies; 3+ messages in thread
From: Laurent Navet @ 2012-11-30 20:36 UTC (permalink / raw)
To: Greg KH, devel; +Cc: linux-kernel
> 2012/11/30, Greg KH <gregkh@linuxfoundation.org>:
> For some reason you sent this only to me, which is a bit rude to
> everyone else on the mailing list. I'll be glad to respond if you
> resend it to everyone.
Sorry, seem's i've reply instead of reply to all.
Anyway, it's maybe not the better idea i've had this day, but i've
started a new thread with a new patch[1], aggregating the two first
ones [2][3].
[1] http://driverdev.linuxdriverproject.org/pipermail/devel/2012-November/033700.html
[2] http://driverdev.linuxdriverproject.org/pipermail/devel/2012-November/033607.html
[3] http://driverdev.linuxdriverproject.org/pipermail/devel/2012-November/033629.html
Regards,
Laurent.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-11-30 20:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-11-29 11:21 [PATCH] staging: line6: Fix checkpatch.pl switch - case issue Laurent Navet [Mali]
2012-11-30 2:08 ` Greg KH
[not found] ` <CAH7P7NhO1Qg=g7VKOFcO5jCQc+u5CPoH9L-y2S=q3BtMFYghkQ@mail.gmail.com>
[not found] ` <20121130144823.GA1985@kroah.com>
2012-11-30 20:36 ` Laurent Navet
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).