[PATCH] drivers:staging: fix compilation warning

[PATCH] drivers:staging: fix compilation warning

[Cong Ding]

We do not allow old-style function definition.  Always spell foo(void) if
a function does not take any parameters.

Signed-off-by: Cong Ding <dinggnu@gmail.com>
---
 drivers/staging/telephony/ixj.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/staging/telephony/ixj.c b/drivers/staging/telephony/ixj.c
index 1cfa0b0..6233f19 100644
--- a/drivers/staging/telephony/ixj.c
+++ b/drivers/staging/telephony/ixj.c
@@ -318,7 +318,7 @@ static IXJ *ixj[IXJMAX];
  *	Allocate a free IXJ device
  */
 
-static IXJ *ixj_alloc()
+static IXJ *ixj_alloc(void)
 {
 	for(cnt=0; cnt<IXJMAX; cnt++)
 	{
-- 
1.7.4.5

Re: [PATCH] drivers:staging: fix compilation warning

[Dan Carpenter]

On Mon, Dec 03, 2012 at 10:34:08AM +0000, Cong Ding wrote:
> We do not allow old-style function definition.  Always spell foo(void) if
> a function does not take any parameters.
> 

You should be working against linux-next.  This driver has been
deleted in linux-next.

The subject should have been:
[PATCH] Staging: telephony/ixj: fix sparse warning
or something like that.  "drivers" is not useful.  And Staging by
itself is too broad.

I think it's a Sparse warning, not a compile warning?  Copy and
paste the warning into the commit message.

Anyway, since this was deleted it doesn't matter.

regards,
dan carpenter

Re: [PATCH] drivers:staging: fix compilation warning

[Cong Ding]

On Mon, Dec 03, 2012 at 01:56:09PM +0300, Dan Carpenter wrote:
> On Mon, Dec 03, 2012 at 10:34:08AM +0000, Cong Ding wrote:
> > We do not allow old-style function definition.  Always spell foo(void) if
> > a function does not take any parameters.
> > 
> 
> You should be working against linux-next.  This driver has been
> deleted in linux-next.
> 
> The subject should have been:
> [PATCH] Staging: telephony/ixj: fix sparse warning
> or something like that.  "drivers" is not useful.  And Staging by
> itself is too broad.
> 
> I think it's a Sparse warning, not a compile warning?  Copy and
> paste the warning into the commit message.
sure, thanks for the suggestions. 

- cong

> 
> Anyway, since this was deleted it doesn't matter.
> 
> regards,
> dan carpenter
> 

Re: [PATCH] drivers:staging: fix compilation warning

[Greg Kroah-Hartman]

On Mon, Dec 03, 2012 at 10:34:08AM +0000, Cong Ding wrote:
> We do not allow old-style function definition.  Always spell foo(void) if
> a function does not take any parameters.
> 
> Signed-off-by: Cong Ding <dinggnu@gmail.com>
> ---
>  drivers/staging/telephony/ixj.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)

As Dan pointed out, you have to work against linux-next, otherwise you
waste time fixing things that might not even be in the tree anymore,
like this code.

sorry,

greg k-h