* [PATCH resend] async_tx: fix checking of dma_wait_for_async_tx() return value
@ 2012-12-05 11:25 Bartlomiej Zolnierkiewicz
0 siblings, 0 replies; only message in thread
From: Bartlomiej Zolnierkiewicz @ 2012-12-05 11:25 UTC (permalink / raw)
To: Vinod Koul; +Cc: linux-kernel, Dan Williams, Tomasz Figa, Kyungmin Park
From: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Subject: [PATCH] async_tx: fix checking of dma_wait_for_async_tx() return value
dma_wait_for_async_tx() can also return DMA_PAUSED (which
should be considered as error).
Cc: Vinod Koul <vinod.koul@intel.com>
Cc: Dan Williams <djbw@fb.com>
Cc: Tomasz Figa <t.figa@samsung.com>
Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
---
crypto/async_tx/async_tx.c | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
Index: b/crypto/async_tx/async_tx.c
===================================================================
--- a/crypto/async_tx/async_tx.c 2012-11-07 16:30:47.940875970 +0100
+++ b/crypto/async_tx/async_tx.c 2012-11-07 16:31:34.888875965 +0100
@@ -128,8 +128,8 @@ async_tx_channel_switch(struct dma_async
}
device->device_issue_pending(chan);
} else {
- if (dma_wait_for_async_tx(depend_tx) == DMA_ERROR)
- panic("%s: DMA_ERROR waiting for depend_tx\n",
+ if (dma_wait_for_async_tx(depend_tx) != DMA_SUCCESS)
+ panic("%s: DMA error waiting for depend_tx\n",
__func__);
tx->tx_submit(tx);
}
@@ -280,8 +280,9 @@ void async_tx_quiesce(struct dma_async_t
* we are referring to the correct operation
*/
BUG_ON(async_tx_test_ack(*tx));
- if (dma_wait_for_async_tx(*tx) == DMA_ERROR)
- panic("DMA_ERROR waiting for transaction\n");
+ if (dma_wait_for_async_tx(*tx) != DMA_SUCCESS)
+ panic("%s: DMA error waiting for transaction\n",
+ __func__);
async_tx_ack(*tx);
*tx = NULL;
}
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2012-12-05 11:26 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-12-05 11:25 [PATCH resend] async_tx: fix checking of dma_wait_for_async_tx() return value Bartlomiej Zolnierkiewicz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).