From: Borislav Petkov <bp@alien8.de>
To: "Ortiz, Lance E" <lance.oritz@hp.com>
Cc: "bhelgaas@google.com" <bhelgaas@google.com>,
"lance_ortiz@hotmail.com" <lance_ortiz@hotmail.com>,
"jiang.liu@huawei.com" <jiang.liu@huawei.com>,
"tony.luck@intel.com" <tony.luck@intel.com>,
"rostedt@goodmis.org" <rostedt@goodmis.org>,
"mchehab@redhat.com" <mchehab@redhat.com>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v7 2/3] aerdrv: Enhanced AER logging
Date: Wed, 5 Dec 2012 17:30:19 +0100 [thread overview]
Message-ID: <20121205163019.GC28556@liondog.tnic> (raw)
In-Reply-To: <A961433CDFF2F640A2866803152E61F9516F279F@G4W3219.americas.hpqcorp.net>
On Wed, Dec 05, 2012 at 04:14:14PM +0000, Ortiz, Lance E wrote:
> I removed the prefix argument because it was never used by its caller
> and never set. The reason I added the prefix variable and set it to
> NULL was to help in breaking up the patch and adding it would help the
> intermittent patch build without changing too much code. I knew I was
> actually going to use the variable in patch 3.
No, the correct way to do that is to keep all changes that belong
logically together in a single patch for ease of reviewing and avoid
breakages. And in your case this should be pretty easy: simply move all
the 'prefix' touching code to patch #3 and you're done, AFAICT.
Thanks.
--
Regards/Gruss,
Boris.
next prev parent reply other threads:[~2012-12-05 16:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-04 21:03 [PATCH v7 1/3] aerdrv: Trace Event for AER Lance Ortiz
2012-12-04 21:03 ` [PATCH v7 2/3] aerdrv: Enhanced AER logging Lance Ortiz
2012-12-05 14:32 ` Borislav Petkov
2012-12-05 16:14 ` Ortiz, Lance E
2012-12-05 16:30 ` Borislav Petkov [this message]
2012-12-27 1:33 ` Bjorn Helgaas
2012-12-04 21:03 ` [PATCH v7 3/3] aerdrv: Cleanup log output for CPER based AER Lance Ortiz
2012-12-05 14:41 ` Mauro Carvalho Chehab
2012-12-05 14:50 ` Borislav Petkov
2012-12-05 16:16 ` Ortiz, Lance E
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121205163019.GC28556@liondog.tnic \
--to=bp@alien8.de \
--cc=bhelgaas@google.com \
--cc=jiang.liu@huawei.com \
--cc=lance.oritz@hp.com \
--cc=lance_ortiz@hotmail.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mchehab@redhat.com \
--cc=rostedt@goodmis.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).