From: "Ortiz, Lance E" <lance.oritz@hp.com>
To: Borislav Petkov <bp@alien8.de>
Cc: "bhelgaas@google.com" <bhelgaas@google.com>,
"lance_ortiz@hotmail.com" <lance_ortiz@hotmail.com>,
"jiang.liu@huawei.com" <jiang.liu@huawei.com>,
"tony.luck@intel.com" <tony.luck@intel.com>,
"rostedt@goodmis.org" <rostedt@goodmis.org>,
"mchehab@redhat.com" <mchehab@redhat.com>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v7 2/3] aerdrv: Enhanced AER logging
Date: Wed, 5 Dec 2012 16:14:14 +0000 [thread overview]
Message-ID: <A961433CDFF2F640A2866803152E61F9516F279F@G4W3219.americas.hpqcorp.net> (raw)
In-Reply-To: <20121205143202.GD2364@liondog.tnic>
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 836 bytes --]
> > + char *prefix = NULL;
>
> What are you doing here? You dropped the 'prefix' argument being passed
> down in this function and are defining a local variable of the same
> name
> which is used in the function later:
>
> printk("%s""aer_status: 0x%08x, aer_mask: 0x%08x\n",
> prefix, status, mask);
>
Boris,
I removed the prefix argument because it was never used by its caller and never set. The reason I added the prefix variable and set it to NULL was to help in breaking up the patch and adding it would help the intermittent patch build without changing too much code. I knew I was actually going to use the variable in patch 3.
Lance
ÿôèº{.nÇ+‰·Ÿ®‰†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a¢f£¢·hšïêÿ‘êçz_è®\x03(階ŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨èÚ&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥
next prev parent reply other threads:[~2012-12-05 16:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-04 21:03 [PATCH v7 1/3] aerdrv: Trace Event for AER Lance Ortiz
2012-12-04 21:03 ` [PATCH v7 2/3] aerdrv: Enhanced AER logging Lance Ortiz
2012-12-05 14:32 ` Borislav Petkov
2012-12-05 16:14 ` Ortiz, Lance E [this message]
2012-12-05 16:30 ` Borislav Petkov
2012-12-27 1:33 ` Bjorn Helgaas
2012-12-04 21:03 ` [PATCH v7 3/3] aerdrv: Cleanup log output for CPER based AER Lance Ortiz
2012-12-05 14:41 ` Mauro Carvalho Chehab
2012-12-05 14:50 ` Borislav Petkov
2012-12-05 16:16 ` Ortiz, Lance E
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=A961433CDFF2F640A2866803152E61F9516F279F@G4W3219.americas.hpqcorp.net \
--to=lance.oritz@hp.com \
--cc=bhelgaas@google.com \
--cc=bp@alien8.de \
--cc=jiang.liu@huawei.com \
--cc=lance_ortiz@hotmail.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mchehab@redhat.com \
--cc=rostedt@goodmis.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).