* [patch 1/2] staging: line6: delete an unused function
@ 2012-12-05 18:43 Dan Carpenter
2012-12-06 5:18 ` Stefan Hajnoczi
0 siblings, 1 reply; 3+ messages in thread
From: Dan Carpenter @ 2012-12-05 18:43 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Stefan Hajnoczi, Markus Grabner, Johannes Thumshirn, devel,
linux-kernel, kernel-janitors
line6_send_sysex_message_async() isn't called from anywhere.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/staging/line6/driver.h b/drivers/staging/line6/driver.h
index f0be5a2..1dd768c2 100644
--- a/drivers/staging/line6/driver.h
+++ b/drivers/staging/line6/driver.h
@@ -208,8 +208,6 @@ extern int line6_send_raw_message_async(struct usb_line6 *line6,
const char *buffer, int size);
extern int line6_send_sysex_message(struct usb_line6 *line6,
const char *buffer, int size);
-extern int line6_send_sysex_message_async(struct usb_line6 *line6,
- const char *buffer, int size);
extern ssize_t line6_set_raw(struct device *dev, struct device_attribute *attr,
const char *buf, size_t count);
extern void line6_start_timer(struct timer_list *timer, unsigned int msecs,
diff --git a/drivers/staging/line6/driver.c b/drivers/staging/line6/driver.c
index 1e4ce500..8a5d89e 100644
--- a/drivers/staging/line6/driver.c
+++ b/drivers/staging/line6/driver.c
@@ -333,17 +333,6 @@ int line6_send_sysex_message(struct usb_line6 *line6, const char *buffer,
}
/*
- Send sysex message in pieces of wMaxPacketSize bytes.
-*/
-int line6_send_sysex_message_async(struct usb_line6 *line6, const char *buffer,
- int size)
-{
- return line6_send_raw_message_async(line6, buffer,
- size + SYSEX_EXTRA_SIZE) -
- SYSEX_EXTRA_SIZE;
-}
-
-/*
Allocate buffer for sysex message and prepare header.
@param code sysex message code
@param size number of bytes between code and sysex end
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [patch 1/2] staging: line6: delete an unused function
2012-12-05 18:43 [patch 1/2] staging: line6: delete an unused function Dan Carpenter
@ 2012-12-06 5:18 ` Stefan Hajnoczi
2012-12-06 9:34 ` johannes thumshirn
0 siblings, 1 reply; 3+ messages in thread
From: Stefan Hajnoczi @ 2012-12-06 5:18 UTC (permalink / raw)
To: Dan Carpenter
Cc: Greg Kroah-Hartman, Markus Grabner, Johannes Thumshirn, devel,
linux-kernel, kernel-janitors
On Wed, Dec 5, 2012 at 7:43 PM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> line6_send_sysex_message_async() isn't called from anywhere.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Stefan Hajnoczi <stefanha@gmail.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [patch 1/2] staging: line6: delete an unused function
2012-12-06 5:18 ` Stefan Hajnoczi
@ 2012-12-06 9:34 ` johannes thumshirn
0 siblings, 0 replies; 3+ messages in thread
From: johannes thumshirn @ 2012-12-06 9:34 UTC (permalink / raw)
To: Stefan Hajnoczi
Cc: Dan Carpenter, Greg Kroah-Hartman, Markus Grabner,
Johannes Thumshirn, devel, linux-kernel, kernel-janitors
On Thu, Dec 6, 2012 at 6:18 AM, Stefan Hajnoczi <stefanha@gmail.com> wrote:
> On Wed, Dec 5, 2012 at 7:43 PM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
>> line6_send_sysex_message_async() isn't called from anywhere.
>>
>> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> Reviewed-by: Stefan Hajnoczi <stefanha@gmail.com>
Reviewed-by: Johannes Thumshirn <morbidrsa@googlemail.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-12-06 9:34 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-12-05 18:43 [patch 1/2] staging: line6: delete an unused function Dan Carpenter
2012-12-06 5:18 ` Stefan Hajnoczi
2012-12-06 9:34 ` johannes thumshirn
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).