linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] pwm: i.MX: eliminate build warning
@ 2012-12-05 15:34 Lothar Waßmann
  2012-12-06  7:42 ` Sascha Hauer
  2012-12-06  7:52 ` Thierry Reding
  0 siblings, 2 replies; 3+ messages in thread
From: Lothar Waßmann @ 2012-12-05 15:34 UTC (permalink / raw)
  To: Thierry Reding
  Cc: Sascha Hauer, linux-arm-kernel, linux-kernel, Lothar Waßmann

compiling the i.MX pwm driver produces the following warning:
|drivers/pwm/pwm-imx.c: In function 'imx_pwm_probe':
|drivers/pwm/pwm-imx.c:281:7: warning: assignment discards qualifiers from pointer target type

Apply a 'const' attribute to the affected variable declaration.

Signed-off-by: Lothar Waßmann <LW@KARO-electronics.de>
---
 drivers/pwm/pwm-imx.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/pwm/pwm-imx.c b/drivers/pwm/pwm-imx.c
index 8f26e9f..65a86bd 100644
--- a/drivers/pwm/pwm-imx.c
+++ b/drivers/pwm/pwm-imx.c
@@ -235,7 +235,7 @@ static int imx_pwm_probe(struct platform_device *pdev)
 {
 	const struct of_device_id *of_id =
 			of_match_device(imx_pwm_dt_ids, &pdev->dev);
-	struct imx_pwm_data *data;
+	const struct imx_pwm_data *data;
 	struct imx_chip *imx;
 	struct resource *r;
 	int ret = 0;
-- 
1.7.2.5


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] pwm: i.MX: eliminate build warning
  2012-12-05 15:34 [PATCH] pwm: i.MX: eliminate build warning Lothar Waßmann
@ 2012-12-06  7:42 ` Sascha Hauer
  2012-12-06  7:52 ` Thierry Reding
  1 sibling, 0 replies; 3+ messages in thread
From: Sascha Hauer @ 2012-12-06  7:42 UTC (permalink / raw)
  To: Lothar Waßmann; +Cc: Thierry Reding, linux-arm-kernel, linux-kernel

On Wed, Dec 05, 2012 at 04:34:41PM +0100, Lothar Waßmann wrote:
> compiling the i.MX pwm driver produces the following warning:
> |drivers/pwm/pwm-imx.c: In function 'imx_pwm_probe':
> |drivers/pwm/pwm-imx.c:281:7: warning: assignment discards qualifiers from pointer target type
> 
> Apply a 'const' attribute to the affected variable declaration.
> 
> Signed-off-by: Lothar Waßmann <LW@KARO-electronics.de>

Acked-by: Sascha Hauer <s.hauer@pengutronix.de>

Sascha

> ---
>  drivers/pwm/pwm-imx.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/pwm/pwm-imx.c b/drivers/pwm/pwm-imx.c
> index 8f26e9f..65a86bd 100644
> --- a/drivers/pwm/pwm-imx.c
> +++ b/drivers/pwm/pwm-imx.c
> @@ -235,7 +235,7 @@ static int imx_pwm_probe(struct platform_device *pdev)
>  {
>  	const struct of_device_id *of_id =
>  			of_match_device(imx_pwm_dt_ids, &pdev->dev);
> -	struct imx_pwm_data *data;
> +	const struct imx_pwm_data *data;
>  	struct imx_chip *imx;
>  	struct resource *r;
>  	int ret = 0;
> -- 
> 1.7.2.5
> 
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] pwm: i.MX: eliminate build warning
  2012-12-05 15:34 [PATCH] pwm: i.MX: eliminate build warning Lothar Waßmann
  2012-12-06  7:42 ` Sascha Hauer
@ 2012-12-06  7:52 ` Thierry Reding
  1 sibling, 0 replies; 3+ messages in thread
From: Thierry Reding @ 2012-12-06  7:52 UTC (permalink / raw)
  To: Lothar Waßmann; +Cc: Sascha Hauer, linux-arm-kernel, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 450 bytes --]

On Wed, Dec 05, 2012 at 04:34:41PM +0100, Lothar Waßmann wrote:
> compiling the i.MX pwm driver produces the following warning:
> |drivers/pwm/pwm-imx.c: In function 'imx_pwm_probe':
> |drivers/pwm/pwm-imx.c:281:7: warning: assignment discards qualifiers from pointer target type
> 
> Apply a 'const' attribute to the affected variable declaration.
> 
> Signed-off-by: Lothar Waßmann <LW@KARO-electronics.de>

Applied, thanks.

Thierry

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2012-12-06  7:53 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-12-05 15:34 [PATCH] pwm: i.MX: eliminate build warning Lothar Waßmann
2012-12-06  7:42 ` Sascha Hauer
2012-12-06  7:52 ` Thierry Reding

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).