From: Kent Yoder <key@linux.vnet.ibm.com>
To: "Peter Hüwe" <PeterHuewe@gmx.de>
Cc: Mathias LEBLANC <Mathias.LEBLANC@st.com>,
Jean-Luc BLANC <jean-luc.blanc@st.com>,
"Sirrix@jasper.es" <Sirrix@jasper.es>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Rajiv Andrade <mail@srajiv.net>,
"tpmdd-devel@lists.sourceforge.net"
<tpmdd-devel@lists.sourceforge.net>,
Kent Yoder <shpedoikal@gmail.com>
Subject: Re: [tpmdd-devel] [PATCH 1/1] TPM: STMicroelectronics ST33 I2C KERNEL 3.x.x
Date: Thu, 6 Dec 2012 09:06:45 -0600 [thread overview]
Message-ID: <20121206150645.GA27430@ennui.austin.ibm.com> (raw)
In-Reply-To: <201212060110.32227.PeterHuewe@gmx.de>
On Thu, Dec 06, 2012 at 01:10:32AM +0100, Peter Hüwe wrote:
> Am Donnerstag, 6. Dezember 2012, 00:09:41 schrieb Kent Yoder:
> > >
> > > > static int tpm_st33_i2c_pm_suspend(struct i2c_client *client,
> > > > pm_message_t mesg)
> > > >
> > > >...
> > > >
> > > > static int tpm_st33_i2c_pm_resume(struct i2c_client *client)
> > > >
> > > >,,,
> > > >static struct i2c_driver tpm_st33_i2c_driver = {
> > > >
> > > > .driver = {
> > > >
> > > > .owner = THIS_MODULE,
> > > > .name = TPM_ST33_I2C,
> > > > },
> > > >
> > > > .probe = tpm_st33_i2c_probe,
> > > > .remove = tpm_st33_i2c_remove,
> > > > .resume = tpm_st33_i2c_pm_resume,
> > > > .suspend = tpm_st33_i2c_pm_suspend,
> > > > .id_table = tpm_st33_i2c_id
> > > >
> > > >};
> > >
> > > Please convert resume/suspend to .driver.pm
> > >
> > > It's pretty easy.
> > > See this post for details
> > > http://sourceforge.net/mailarchive/message.php?msg_id=29516784
> > > Rafael did spent quite a lot of effort to convert almost every driver
> > > back then, so we should 'fix' new ones.
> >
> > Not sure how easy this will be considering these routines are
> > i2c-specific -- they don't just call the tpm_tpm_* functions like the
> > other drivers.
>
> Why are they really i2c-specific?
> The only i2c specific part is the i2c_get_clientdata - which calls
> get_dev_drvdata internally.
> And I since we already get the correct struct device we don't need to use
> TPM_VPRIV in order to access the platform data.
I was referring to the power mgmt stuff. Those functions take struct
device, not a i2c_client *.
Kent
> I'll send a patch - see next email.
> @Matthias: can you please test this? As I cannot do this.
>
>
> Thanks,
> Peter
>
>
next prev parent reply other threads:[~2012-12-06 15:07 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-19 22:15 [PATCH 1/1] TPM: STMicroelectronics ST33 I2C KERNEL 3.x.x Mathias Leblanc
2012-11-19 22:15 ` [PATCH 1/1] TPM: STMicroelectronics ST33 I2C KERNEL 2.6 Mathias Leblanc
2012-11-26 17:46 ` [PATCH 1/1] TPM: STMicroelectronics ST33 I2C KERNEL 3.x.x Kent Yoder
2012-11-27 8:44 ` Mathias LEBLANC
2012-11-27 14:48 ` [tpmdd-devel] " Kent Yoder
2012-11-28 8:54 ` Mathias LEBLANC
2012-11-28 15:31 ` Kent Yoder
2012-11-28 17:48 ` Mathias LEBLANC
2012-11-28 19:04 ` Kent Yoder
2012-11-29 0:04 ` Peter Hüwe
2012-12-05 16:11 ` Mathias LEBLANC
2012-12-05 17:13 ` Kent Yoder
2012-12-05 17:45 ` Kent Yoder
2012-12-05 18:07 ` Kent Yoder
2012-12-05 20:20 ` Peter Hüwe
2012-12-05 21:00 ` Kent Yoder
2012-12-05 21:39 ` Peter Hüwe
2012-12-05 21:14 ` Peter Hüwe
2012-12-05 23:09 ` Kent Yoder
2012-12-06 0:10 ` Peter Hüwe
2012-12-06 15:06 ` Kent Yoder [this message]
2012-12-08 4:00 ` [tpmdd-devel] [PATCH 1/1] TPM: STMicroelectronics ST33 I2C KERNEL 3.x.x OOPS! Peter Hüwe
[not found] ` <20130108172053.GA11223@ennui.austin.ibm.com>
2013-01-09 14:31 ` Mathias LEBLANC
2013-01-09 19:41 ` Peter Hüwe
2013-01-22 23:30 ` Kent Yoder
2012-12-06 0:20 ` [PATCH] char/tpm: Use struct dev_pm_ops for power management Peter Huewe
2012-12-06 15:07 ` Kent Yoder
2012-12-10 18:11 ` Mathias LEBLANC
2012-12-06 16:27 ` Kent Yoder
2012-12-08 3:55 ` Peter Hüwe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121206150645.GA27430@ennui.austin.ibm.com \
--to=key@linux.vnet.ibm.com \
--cc=Mathias.LEBLANC@st.com \
--cc=PeterHuewe@gmx.de \
--cc=Sirrix@jasper.es \
--cc=jean-luc.blanc@st.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mail@srajiv.net \
--cc=shpedoikal@gmail.com \
--cc=tpmdd-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).