From: Mathias LEBLANC <Mathias.LEBLANC@st.com>
To: Kent Yoder <key@linux.vnet.ibm.com>, Peter Huewe <peterhuewe@gmx.de>
Cc: Jean-Luc BLANC <jean-luc.blanc@st.com>,
"Sirrix@jasper.es" <Sirrix@jasper.es>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Rajiv Andrade <mail@srajiv.net>,
"tpmdd-devel@lists.sourceforge.net"
<tpmdd-devel@lists.sourceforge.net>,
Kent Yoder <shpedoikal@gmail.com>
Subject: RE: [PATCH] char/tpm: Use struct dev_pm_ops for power management
Date: Mon, 10 Dec 2012 19:11:30 +0100 [thread overview]
Message-ID: <35286B1AE75A7C47BFF0870081A31B4B3A9CDB2F99@SAFEX1MAIL4.st.com> (raw)
In-Reply-To: <20121206150735.GB27430@ennui.austin.ibm.com>
Hi Kent, Peter,
I am never in my office Thursday and Friday, I just saw your emails today.
I will transfer the tpm_i2c_stm_st33.h code to tpm_i2c_stm_st33.c
@Peter: I tested your patch and activate the CONFIG_PM_SLEEP in the kernel compilation.
Thanks Peter!
About:
"Not sure how easy this will be considering these routines are
> > i2c-specific -- they don't just call the tpm_tpm_* functions like
> > the other drivers."
We have created another function similar to the tpm_* functions, to ensure the good work of the tpm on each platform for each case.
But anyway , we use the tpm_* function in them.
Thanks,
Mathias Leblanc
-----Original Message-----
From: Kent Yoder [mailto:key@linux.vnet.ibm.com]
Sent: 06 December, 2012 16:08
To: Peter Huewe
Cc: Mathias LEBLANC; Jean-Luc BLANC; Sirrix@jasper.es; linux-kernel@vger.kernel.org; Rajiv Andrade; tpmdd-devel@lists.sourceforge.net; Kent Yoder
Subject: Re: [PATCH] char/tpm: Use struct dev_pm_ops for power management
On Thu, Dec 06, 2012 at 01:20:51AM +0100, Peter Huewe wrote:
> This patch converts the suspend and resume functions for
> tpm_i2c_stm_st33 to the new dev_pm_ops.
Ignore my last mail. I'll take a look at this.
Thanks,
Kent
> Signed-off-by: Peter Huewe <peterhuewe@gmx.de>
> ---
> Note:
> I'm sending this patch on behalf of myself only and nobody else,
> especially not my employer - and I'm doing this in my spare time.
> I have to inform you that I'm working for a direct competitor of the
> driver author, but I'm not using any knowledge that is considered secret in any way.
> I have a personal interest in the TPM subsystem and want to keep it as clean as possible.
>
>
> drivers/char/tpm/tpm_i2c_stm_st33.c | 25 ++++++++++---------------
> 1 files changed, 10 insertions(+), 15 deletions(-)
>
> diff --git a/drivers/char/tpm/tpm_i2c_stm_st33.c
> b/drivers/char/tpm/tpm_i2c_stm_st33.c
> index b11201f..ecbb81e 100644
> --- a/drivers/char/tpm/tpm_i2c_stm_st33.c
> +++ b/drivers/char/tpm/tpm_i2c_stm_st33.c
> @@ -826,12 +826,10 @@ static __devexit int tpm_st33_i2c_remove(struct i2c_client *client)
> * @param: mesg, the power management message.
> * @return: 0 in case of success.
> */
> -static int tpm_st33_i2c_pm_suspend(struct i2c_client *client,
> pm_message_t mesg)
> +static int tpm_st33_i2c_pm_suspend(struct device *dev)
> {
> - struct tpm_chip *chip =
> - (struct tpm_chip *)i2c_get_clientdata(client);
> - struct st33zp24_platform_data *pin_infos =
> - ((struct i2c_client *)TPM_VPRIV(chip))->dev.platform_data;
> + struct tpm_chip *chip = dev_get_drvdata(dev);
> + struct st33zp24_platform_data *pin_infos = dev->platform_data;
> int ret = 0;
>
> if (power_mgt)
> @@ -839,7 +837,7 @@ static int tpm_st33_i2c_pm_suspend(struct i2c_client *client, pm_message_t mesg)
> else{
> if (chip->data_buffer == NULL)
> chip->data_buffer = pin_infos->tpm_i2c_buffer[0];
> - ret = tpm_pm_suspend(&client->dev);
> + ret = tpm_pm_suspend(dev);
> }
> return ret;
> } /* tpm_st33_i2c_suspend() */
> @@ -849,12 +847,10 @@ static int tpm_st33_i2c_pm_suspend(struct i2c_client *client, pm_message_t mesg)
> * @param: client, the i2c_client drescription (TPM I2C description).
> * @return: 0 in case of success.
> */
> -static int tpm_st33_i2c_pm_resume(struct i2c_client *client)
> +static int tpm_st33_i2c_pm_resume(struct device *dev)
> {
> - struct tpm_chip *chip =
> - (struct tpm_chip *)i2c_get_clientdata(client);
> - struct st33zp24_platform_data *pin_infos =
> - ((struct i2c_client *)TPM_VPRIV(chip))->dev.platform_data;
> + struct tpm_chip *chip = dev_get_drvdata(dev);
> + struct st33zp24_platform_data *pin_infos = dev->platform_data;
>
> int ret = 0;
>
> @@ -867,7 +863,7 @@ static int tpm_st33_i2c_pm_resume(struct i2c_client *client)
> } else{
> if (chip->data_buffer == NULL)
> chip->data_buffer = pin_infos->tpm_i2c_buffer[0];
> - ret = tpm_pm_resume(&client->dev);
> + ret = tpm_pm_resume(dev);
> if (!ret)
> tpm_do_selftest(chip);
> }
> @@ -880,16 +876,15 @@ static const struct i2c_device_id
> tpm_st33_i2c_id[] = { };
>
> MODULE_DEVICE_TABLE(i2c, tpm_st33_i2c_id);
> -
> +static SIMPLE_DEV_PM_OPS(tpm_st33_i2c_ops, tpm_st33_i2c_pm_suspend,
> +tpm_st33_i2c_pm_resume);
> static struct i2c_driver tpm_st33_i2c_driver = {
> .driver = {
> .owner = THIS_MODULE,
> .name = TPM_ST33_I2C,
> + .pm = &tpm_st33_i2c_ops,
> },
> .probe = tpm_st33_i2c_probe,
> .remove = tpm_st33_i2c_remove,
> - .resume = tpm_st33_i2c_pm_resume,
> - .suspend = tpm_st33_i2c_pm_suspend,
> .id_table = tpm_st33_i2c_id
> };
>
> --
> 1.7.8.6
>
next prev parent reply other threads:[~2012-12-10 18:13 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-19 22:15 [PATCH 1/1] TPM: STMicroelectronics ST33 I2C KERNEL 3.x.x Mathias Leblanc
2012-11-19 22:15 ` [PATCH 1/1] TPM: STMicroelectronics ST33 I2C KERNEL 2.6 Mathias Leblanc
2012-11-26 17:46 ` [PATCH 1/1] TPM: STMicroelectronics ST33 I2C KERNEL 3.x.x Kent Yoder
2012-11-27 8:44 ` Mathias LEBLANC
2012-11-27 14:48 ` [tpmdd-devel] " Kent Yoder
2012-11-28 8:54 ` Mathias LEBLANC
2012-11-28 15:31 ` Kent Yoder
2012-11-28 17:48 ` Mathias LEBLANC
2012-11-28 19:04 ` Kent Yoder
2012-11-29 0:04 ` Peter Hüwe
2012-12-05 16:11 ` Mathias LEBLANC
2012-12-05 17:13 ` Kent Yoder
2012-12-05 17:45 ` Kent Yoder
2012-12-05 18:07 ` Kent Yoder
2012-12-05 20:20 ` Peter Hüwe
2012-12-05 21:00 ` Kent Yoder
2012-12-05 21:39 ` Peter Hüwe
2012-12-05 21:14 ` Peter Hüwe
2012-12-05 23:09 ` Kent Yoder
2012-12-06 0:10 ` Peter Hüwe
2012-12-06 15:06 ` Kent Yoder
2012-12-08 4:00 ` [tpmdd-devel] [PATCH 1/1] TPM: STMicroelectronics ST33 I2C KERNEL 3.x.x OOPS! Peter Hüwe
[not found] ` <20130108172053.GA11223@ennui.austin.ibm.com>
2013-01-09 14:31 ` Mathias LEBLANC
2013-01-09 19:41 ` Peter Hüwe
2013-01-22 23:30 ` Kent Yoder
2012-12-06 0:20 ` [PATCH] char/tpm: Use struct dev_pm_ops for power management Peter Huewe
2012-12-06 15:07 ` Kent Yoder
2012-12-10 18:11 ` Mathias LEBLANC [this message]
2012-12-06 16:27 ` Kent Yoder
2012-12-08 3:55 ` Peter Hüwe
-- strict thread matches above, loose matches on Subject: below --
2012-08-03 20:38 [PATCH] char/tpm: Fix compile error if CONFIG_PM is not set in tpm_i2c_infineon Kent Yoder
2012-08-06 7:58 ` [PATCH] char/tpm: Use struct dev_pm_ops for power management Peter Huewe
2012-08-06 19:29 ` Kent Yoder
2012-08-07 7:30 ` Peter.Huewe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=35286B1AE75A7C47BFF0870081A31B4B3A9CDB2F99@SAFEX1MAIL4.st.com \
--to=mathias.leblanc@st.com \
--cc=Sirrix@jasper.es \
--cc=jean-luc.blanc@st.com \
--cc=key@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mail@srajiv.net \
--cc=peterhuewe@gmx.de \
--cc=shpedoikal@gmail.com \
--cc=tpmdd-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).