linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Cong Ding <dinggnu@gmail.com>
To: Bin Wang <wbin00@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-kernel@vger.kernel.org, torvalds@linux-foundation.org
Subject: [PATCH RFC -next] Fix the trailing blank space issue
Date: Thu, 6 Dec 2012 15:42:20 +0000	[thread overview]
Message-ID: <20121206154219.GA24788@gmail.com> (raw)
In-Reply-To: <1354784936-5647-1-git-send-email-wbin00@gmail.com>

On Thu, Dec 06, 2012 at 05:08:56PM +0800, Bin Wang wrote:
> This patch removes the trailing white space in fs/sysfs/mount.c.
> 
> Signed-off-by: Bin Wang <wbin00@gmail.com>
> ---
>  fs/sysfs/mount.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
Hi Greg,

I am not sure it is really necessary to remove all the trailing blank spaces
in the project. I have done a try by this shell command
$ find . -iname '*.[ch]' | xargs sed 's/\s\+$//g' -i
and find there are 2812 files/31712 lines with this issue. 

If necessary, I think it's better to run this shell code by yourself in the
whole linux-next tree and commit it. Nevertheless, the patch file of my try is
available from gist: https://gist.github.com/4225286

Even the diff summary is very large, hence I attach a simple version diff
result and commit information here. 

- cong

---
>From 30ed9bb0e6f7c8866447d27c86f466c44749116e Mon Sep 17 00:00:00 2001
From: Cong Ding <dinggnu@gmail.com>
Date: Thu, 6 Dec 2012 15:58:15 +0100
Subject: [PATCH RFC -next] remove all the trailing blank space

clean all the trailing blank space by using shell command
$ find . -iname '*.[ch]' | xargs sed 's/\s\+$//g' -i

I have manually checked a random set of all the changes, and find no error.
I also compiled the whole system and tested many times by randconfig.

Signed-off-by: Cong Ding <dinggnu@gmail.com>
---
 2812 files changed, 31712 insertions(+), 31712 deletions(-)

  reply	other threads:[~2012-12-06 15:42 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-06  9:08 [PATCH 1/1] sysfs: Fixed a trailing white space error Bin Wang
2012-12-06 15:42 ` Cong Ding [this message]
2012-12-06 16:06   ` [PATCH RFC -next] Fix the trailing blank space issue Greg Kroah-Hartman
2012-12-06 16:31     ` Cong Ding
2012-12-06 16:59       ` Greg Kroah-Hartman
2013-01-14 14:07         ` Bin Wang
2012-12-06 19:54       ` Alan Cox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121206154219.GA24788@gmail.com \
    --to=dinggnu@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    --cc=wbin00@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).