From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Cong Ding <dinggnu@gmail.com>
Cc: Bin Wang <wbin00@gmail.com>,
linux-kernel@vger.kernel.org, torvalds@linux-foundation.org
Subject: Re: [PATCH RFC -next] Fix the trailing blank space issue
Date: Thu, 6 Dec 2012 08:59:58 -0800 [thread overview]
Message-ID: <20121206165958.GA9301@kroah.com> (raw)
In-Reply-To: <20121206163138.GC2510@gmail.com>
On Thu, Dec 06, 2012 at 04:31:39PM +0000, Cong Ding wrote:
> On Thu, Dec 06, 2012 at 08:06:06AM -0800, Greg Kroah-Hartman wrote:
> > On Thu, Dec 06, 2012 at 03:42:20PM +0000, Cong Ding wrote:
> > > On Thu, Dec 06, 2012 at 05:08:56PM +0800, Bin Wang wrote:
> > > > This patch removes the trailing white space in fs/sysfs/mount.c.
> > > >
> > > > Signed-off-by: Bin Wang <wbin00@gmail.com>
> > > > ---
> > > > fs/sysfs/mount.c | 2 +-
> > > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > > >
> > > Hi Greg,
> > >
> > > I am not sure it is really necessary to remove all the trailing blank spaces
> > > in the project. I have done a try by this shell command
> > > $ find . -iname '*.[ch]' | xargs sed 's/\s\+$//g' -i
> > > and find there are 2812 files/31712 lines with this issue.
> >
> > That's very true, why would you want to do this?
> >
> > This comes up every 6 months or so on the linux-kernel mailing list,
> > please see the archives for previous responses to the topic.
> >
> > If you want, just slowly send patches to the different subsystem
> > maintainers, to clean the issue up.
> sorry for forgetting press "reply all" in the former email...
>
> Sending them slowly to different subsystem maintainers is a very bad idea,
> because it wastes lots of time for both me and them. But the current situation
> is that there are some people send this kind of patches in random time which
> also is a kind of wasting their time.
>
> I think we'd better to find a solution, not only for the blank space issue,
> but also all the coding style issues able to be fixed by scripts.
>
> I would suggest to write a series of scripts. And then announce a date
> (preferably some holiday like Xmas) to run these scripts. The announce is to
> avoid conflicts with other developers. It will save both developers' and
> subsystem maintains' time, do you agree?
No I do not, it's not a big issue at all. As I said, look in the
archives, this comes up every six months or so.
greg k-h
next prev parent reply other threads:[~2012-12-06 17:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-06 9:08 [PATCH 1/1] sysfs: Fixed a trailing white space error Bin Wang
2012-12-06 15:42 ` [PATCH RFC -next] Fix the trailing blank space issue Cong Ding
2012-12-06 16:06 ` Greg Kroah-Hartman
2012-12-06 16:31 ` Cong Ding
2012-12-06 16:59 ` Greg Kroah-Hartman [this message]
2013-01-14 14:07 ` Bin Wang
2012-12-06 19:54 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121206165958.GA9301@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=dinggnu@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=wbin00@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).