linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] pcmcia/vrc4171: Add missing spinlock init
@ 2012-12-16 21:00 Jean Delvare
  0 siblings, 0 replies; only message in thread
From: Jean Delvare @ 2012-12-16 21:00 UTC (permalink / raw)
  To: Bill Pemberton, Greg Kroah-Hartman; +Cc: linux-pcmcia, linux-kernel

It doesn't seem this spinlock was properly initialized. This bug was
introduced by commit 7a410e8d4d97457c8c381e2de9cdc7bd3306badc.

Signed-off-by: Jean Delvare <khali@linux-fr.org>
---
I can't even build-test this. Already sent on:
 * 2012-09-06

 drivers/pcmcia/vrc4171_card.c |    1 +
 1 file changed, 1 insertion(+)

--- linux-3.6-rc4.orig/drivers/pcmcia/vrc4171_card.c	2012-07-21 22:58:29.000000000 +0200
+++ linux-3.6-rc4/drivers/pcmcia/vrc4171_card.c	2012-09-06 14:07:40.976007788 +0200
@@ -246,6 +246,7 @@ static int pccard_init(struct pcmcia_soc
 	socket = &vrc4171_sockets[slot];
 	socket->csc_irq = search_nonuse_irq();
 	socket->io_irq = search_nonuse_irq();
+	spin_lock_init(&socket->lock);
 
 	return 0;
 }


-- 
Jean Delvare

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2012-12-16 21:01 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-12-16 21:00 [PATCH] pcmcia/vrc4171: Add missing spinlock init Jean Delvare

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).