* [PATCH -resend 1/1] fcoe: use continue instead of goto+label
@ 2015-10-06 12:27 Jiri Slaby
2015-10-06 12:29 ` Johannes Thumshirn
2015-10-06 22:34 ` Vasu Dev
0 siblings, 2 replies; 3+ messages in thread
From: Jiri Slaby @ 2015-10-06 12:27 UTC (permalink / raw)
To: akpm
Cc: JBottomley, kxie, linux-scsi, linux-kernel, Jiri Slaby,
Robert Love, fcoe-devel
There is a label pointing to the start of a while loop and a goto
nested only in the loop. The goto jumps to the label in some cases.
Replace the goto and the label by simple continue.
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Cc: Robert Love <robert.w.love@intel.com>
Cc: fcoe-devel@open-fcoe.org
---
Sent on:
May 5
drivers/scsi/fcoe/fcoe.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/scsi/fcoe/fcoe.c b/drivers/scsi/fcoe/fcoe.c
index d3eb80c46bbe..d187ba9b361d 100644
--- a/drivers/scsi/fcoe/fcoe.c
+++ b/drivers/scsi/fcoe/fcoe.c
@@ -1873,7 +1873,6 @@ static int fcoe_percpu_receive_thread(void *arg)
set_user_nice(current, MIN_NICE);
-retry:
while (!kthread_should_stop()) {
spin_lock_bh(&p->fcoe_rx_list.lock);
@@ -1883,7 +1882,7 @@ retry:
set_current_state(TASK_INTERRUPTIBLE);
spin_unlock_bh(&p->fcoe_rx_list.lock);
schedule();
- goto retry;
+ continue;
}
spin_unlock_bh(&p->fcoe_rx_list.lock);
--
2.6.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH -resend 1/1] fcoe: use continue instead of goto+label
2015-10-06 12:27 [PATCH -resend 1/1] fcoe: use continue instead of goto+label Jiri Slaby
@ 2015-10-06 12:29 ` Johannes Thumshirn
2015-10-06 22:34 ` Vasu Dev
1 sibling, 0 replies; 3+ messages in thread
From: Johannes Thumshirn @ 2015-10-06 12:29 UTC (permalink / raw)
To: Jiri Slaby
Cc: akpm, JBottomley, kxie, linux-scsi, linux-kernel, Robert Love,
fcoe-devel
On Tuesday 06 October 2015 14:27:45 Jiri Slaby wrote:
> There is a label pointing to the start of a while loop and a goto
> nested only in the loop. The goto jumps to the label in some cases.
> Replace the goto and the label by simple continue.
>
> Signed-off-by: Jiri Slaby <jslaby@suse.cz>
> Cc: Robert Love <robert.w.love@intel.com>
> Cc: fcoe-devel@open-fcoe.org
> ---
> Sent on:
> May 5
>
> drivers/scsi/fcoe/fcoe.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/scsi/fcoe/fcoe.c b/drivers/scsi/fcoe/fcoe.c
> index d3eb80c46bbe..d187ba9b361d 100644
> --- a/drivers/scsi/fcoe/fcoe.c
> +++ b/drivers/scsi/fcoe/fcoe.c
> @@ -1873,7 +1873,6 @@ static int fcoe_percpu_receive_thread(void *arg)
>
> set_user_nice(current, MIN_NICE);
>
> -retry:
> while (!kthread_should_stop()) {
>
> spin_lock_bh(&p->fcoe_rx_list.lock);
> @@ -1883,7 +1882,7 @@ retry:
> set_current_state(TASK_INTERRUPTIBLE);
> spin_unlock_bh(&p->fcoe_rx_list.lock);
> schedule();
> - goto retry;
> + continue;
> }
>
> spin_unlock_bh(&p->fcoe_rx_list.lock);
Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
--
Johannes Thumshirn Storage
jthumshirn@suse.de +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -resend 1/1] fcoe: use continue instead of goto+label
2015-10-06 12:27 [PATCH -resend 1/1] fcoe: use continue instead of goto+label Jiri Slaby
2015-10-06 12:29 ` Johannes Thumshirn
@ 2015-10-06 22:34 ` Vasu Dev
1 sibling, 0 replies; 3+ messages in thread
From: Vasu Dev @ 2015-10-06 22:34 UTC (permalink / raw)
To: Jiri Slaby
Cc: akpm, JBottomley, kxie, linux-scsi, linux-kernel, Robert Love,
fcoe-devel
On Tue, 2015-10-06 at 14:27 +0200, Jiri Slaby wrote:
> There is a label pointing to the start of a while loop and a goto
> nested only in the loop. The goto jumps to the label in some cases.
> Replace the goto and the label by simple continue.
>
> Signed-off-by: Jiri Slaby <jslaby@suse.cz>
> Cc: Robert Love <robert.w.love@intel.com>
> Cc: fcoe-devel@open-fcoe.org
> ---
> Sent on:
> May 5
>
> drivers/scsi/fcoe/fcoe.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/scsi/fcoe/fcoe.c b/drivers/scsi/fcoe/fcoe.c
> index d3eb80c46bbe..d187ba9b361d 100644
> --- a/drivers/scsi/fcoe/fcoe.c
> +++ b/drivers/scsi/fcoe/fcoe.c
> @@ -1873,7 +1873,6 @@ static int fcoe_percpu_receive_thread(void *arg)
>
> set_user_nice(current, MIN_NICE);
>
> -retry:
> while (!kthread_should_stop()) {
>
> spin_lock_bh(&p->fcoe_rx_list.lock);
> @@ -1883,7 +1882,7 @@ retry:
> set_current_state(TASK_INTERRUPTIBLE);
> spin_unlock_bh(&p->fcoe_rx_list.lock);
> schedule();
> - goto retry;
> + continue;
> }
>
> spin_unlock_bh(&p->fcoe_rx_list.lock);
Acked-by: Vasu Dev <vasu.dev@intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-10-06 22:34 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-10-06 12:27 [PATCH -resend 1/1] fcoe: use continue instead of goto+label Jiri Slaby
2015-10-06 12:29 ` Johannes Thumshirn
2015-10-06 22:34 ` Vasu Dev
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).