* Remove noisy warning from default_send_IPI_mask_logical
@ 2013-01-18 17:58 Dave Jones
2013-01-24 20:07 ` [tip:x86/apic] x86/apic: Remove noisy zero-mask warning from default_send_IPI_mask_logical() tip-bot for Dave Jones
0 siblings, 1 reply; 2+ messages in thread
From: Dave Jones @ 2013-01-18 17:58 UTC (permalink / raw)
To: x86; +Cc: Linux Kernel
Since circa 3.5, we've had dozens of reports of people hitting this warning.
Forwarded reports have been met with silence, so just remove the warning
if no-one cares.
Example reports:
https://bugzilla.redhat.com/show_bug.cgi?id=797687
https://bugzilla.redhat.com/show_bug.cgi?id=867174
https://bugzilla.redhat.com/show_bug.cgi?id=894865
Signed-off-by: Dave Jones <davej@redhat.com>
diff --git a/arch/x86/kernel/apic/ipi.c b/arch/x86/kernel/apic/ipi.c
index cce91bf..7434d85 100644
--- a/arch/x86/kernel/apic/ipi.c
+++ b/arch/x86/kernel/apic/ipi.c
@@ -106,7 +106,7 @@ void default_send_IPI_mask_logical(const struct cpumask *cpumask, int vector)
unsigned long mask = cpumask_bits(cpumask)[0];
unsigned long flags;
- if (WARN_ONCE(!mask, "empty IPI mask"))
+ if (!mask)
return;
local_irq_save(flags);
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [tip:x86/apic] x86/apic: Remove noisy zero-mask warning from default_send_IPI_mask_logical()
2013-01-18 17:58 Remove noisy warning from default_send_IPI_mask_logical Dave Jones
@ 2013-01-24 20:07 ` tip-bot for Dave Jones
0 siblings, 0 replies; 2+ messages in thread
From: tip-bot for Dave Jones @ 2013-01-24 20:07 UTC (permalink / raw)
To: linux-tip-commits; +Cc: linux-kernel, hpa, mingo, akpm, davej, tglx
Commit-ID: e3f0f36ddf1b2743a0d4ea312996536a9c37e1c7
Gitweb: http://git.kernel.org/tip/e3f0f36ddf1b2743a0d4ea312996536a9c37e1c7
Author: Dave Jones <davej@redhat.com>
AuthorDate: Fri, 18 Jan 2013 12:58:47 -0500
Committer: Ingo Molnar <mingo@kernel.org>
CommitDate: Thu, 24 Jan 2013 12:12:42 +0100
x86/apic: Remove noisy zero-mask warning from default_send_IPI_mask_logical()
Since circa 3.5, we've had dozens of reports of people hitting
this warning. Forwarded reports have been met with silence, so
just remove the warning if no-one cares.
Example reports:
https://bugzilla.redhat.com/show_bug.cgi?id=797687
https://bugzilla.redhat.com/show_bug.cgi?id=867174
https://bugzilla.redhat.com/show_bug.cgi?id=894865
Signed-off-by: Dave Jones <davej@redhat.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Link: http://lkml.kernel.org/r/20130118175847.GA27662@redhat.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
arch/x86/kernel/apic/ipi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/kernel/apic/ipi.c b/arch/x86/kernel/apic/ipi.c
index cce91bf..7434d85 100644
--- a/arch/x86/kernel/apic/ipi.c
+++ b/arch/x86/kernel/apic/ipi.c
@@ -106,7 +106,7 @@ void default_send_IPI_mask_logical(const struct cpumask *cpumask, int vector)
unsigned long mask = cpumask_bits(cpumask)[0];
unsigned long flags;
- if (WARN_ONCE(!mask, "empty IPI mask"))
+ if (!mask)
return;
local_irq_save(flags);
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-01-24 20:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-01-18 17:58 Remove noisy warning from default_send_IPI_mask_logical Dave Jones
2013-01-24 20:07 ` [tip:x86/apic] x86/apic: Remove noisy zero-mask warning from default_send_IPI_mask_logical() tip-bot for Dave Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).