* [PATCH] workqueue: un-GPL function delayed_work_timer_fn()
@ 2013-01-24 12:36 Konstantin Khlebnikov
2013-01-24 18:43 ` Tejun Heo
0 siblings, 1 reply; 2+ messages in thread
From: Konstantin Khlebnikov @ 2013-01-24 12:36 UTC (permalink / raw)
To: linux-kernel; +Cc: Tejun Heo, stable
commit d8e794dfd51c368ed3f686b7f4172830b60ae47b ("workqueue: set
delayed_work->timer function on initialization") exports function
delayed_work_timer_fn() only for GPL modules. This makes delayed-works
unusable for non-GPL modules, because initialization macro now requires
GPL symbol. For example schedule_delayed_work() available for non-GPL.
Signed-off-by: Konstantin Khlebnikov <khlebnikov@openvz.org>
Cc: Tejun Heo <tj@kernel.org>
Cc: stable@vger.kernel.org # 3.7
---
kernel/workqueue.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/workqueue.c b/kernel/workqueue.c
index fbc6576..033ad5b 100644
--- a/kernel/workqueue.c
+++ b/kernel/workqueue.c
@@ -1352,7 +1352,7 @@ void delayed_work_timer_fn(unsigned long __data)
/* should have been called from irqsafe timer with irq already off */
__queue_work(dwork->cpu, cwq->wq, &dwork->work);
}
-EXPORT_SYMBOL_GPL(delayed_work_timer_fn);
+EXPORT_SYMBOL(delayed_work_timer_fn);
static void __queue_delayed_work(int cpu, struct workqueue_struct *wq,
struct delayed_work *dwork, unsigned long delay)
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] workqueue: un-GPL function delayed_work_timer_fn()
2013-01-24 12:36 [PATCH] workqueue: un-GPL function delayed_work_timer_fn() Konstantin Khlebnikov
@ 2013-01-24 18:43 ` Tejun Heo
0 siblings, 0 replies; 2+ messages in thread
From: Tejun Heo @ 2013-01-24 18:43 UTC (permalink / raw)
To: Konstantin Khlebnikov; +Cc: linux-kernel, stable
On Thu, Jan 24, 2013 at 04:36:31PM +0400, Konstantin Khlebnikov wrote:
> commit d8e794dfd51c368ed3f686b7f4172830b60ae47b ("workqueue: set
> delayed_work->timer function on initialization") exports function
> delayed_work_timer_fn() only for GPL modules. This makes delayed-works
> unusable for non-GPL modules, because initialization macro now requires
> GPL symbol. For example schedule_delayed_work() available for non-GPL.
>
> Signed-off-by: Konstantin Khlebnikov <khlebnikov@openvz.org>
> Cc: Tejun Heo <tj@kernel.org>
> Cc: stable@vger.kernel.org # 3.7
Applied to wq/for-3.8-fixes. Thanks.
--
tejun
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-01-24 18:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-01-24 12:36 [PATCH] workqueue: un-GPL function delayed_work_timer_fn() Konstantin Khlebnikov
2013-01-24 18:43 ` Tejun Heo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).