* [PATCH] CONFIG_PANIC_ON_OOPS should be shown if DEBUG_KERNEL
@ 2013-01-22 19:21 Kyle McMartin
2013-01-23 22:04 ` Andrew Morton
0 siblings, 1 reply; 4+ messages in thread
From: Kyle McMartin @ 2013-01-22 19:21 UTC (permalink / raw)
To: linux-kernel; +Cc: mingo
CONFIG_EXPERT is a bit silly a place for this, and hides it
unnecessarily. CONFIG_DEBUG_KERNEL makes much more sense.
Signed-off-by: Kyle McMartin <kyle@redhat.com>
--- a/lib/Kconfig.debug
+++ b/lib/Kconfig.debug
@@ -243,7 +243,7 @@ config BOOTPARAM_SOFTLOCKUP_PANIC_VALUE
default 1 if BOOTPARAM_SOFTLOCKUP_PANIC
config PANIC_ON_OOPS
- bool "Panic on Oops" if EXPERT
+ bool "Panic on Oops" if DEBUG_KERNEL
default n
help
Say Y here to enable the kernel to panic when it oopses. This
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] CONFIG_PANIC_ON_OOPS should be shown if DEBUG_KERNEL
2013-01-22 19:21 [PATCH] CONFIG_PANIC_ON_OOPS should be shown if DEBUG_KERNEL Kyle McMartin
@ 2013-01-23 22:04 ` Andrew Morton
2013-01-24 10:18 ` Ingo Molnar
0 siblings, 1 reply; 4+ messages in thread
From: Andrew Morton @ 2013-01-23 22:04 UTC (permalink / raw)
To: Kyle McMartin; +Cc: linux-kernel, mingo
On Tue, 22 Jan 2013 14:21:03 -0500
Kyle McMartin <kyle@redhat.com> wrote:
> CONFIG_EXPERT is a bit silly a place for this, and hides it
> unnecessarily. CONFIG_DEBUG_KERNEL makes much more sense.
>
> Signed-off-by: Kyle McMartin <kyle@redhat.com>
>
> --- a/lib/Kconfig.debug
> +++ b/lib/Kconfig.debug
> @@ -243,7 +243,7 @@ config BOOTPARAM_SOFTLOCKUP_PANIC_VALUE
> default 1 if BOOTPARAM_SOFTLOCKUP_PANIC
>
> config PANIC_ON_OOPS
> - bool "Panic on Oops" if EXPERT
> + bool "Panic on Oops" if DEBUG_KERNEL
> default n
> help
> Say Y here to enable the kernel to panic when it oopses. This
hm, I'm not sure that it should depend on anything. Where's the benefit?
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] CONFIG_PANIC_ON_OOPS should be shown if DEBUG_KERNEL
2013-01-23 22:04 ` Andrew Morton
@ 2013-01-24 10:18 ` Ingo Molnar
2013-01-24 19:43 ` [PATCH] unhide CONFIG_PANIC_ON_OOPS Kyle McMartin
0 siblings, 1 reply; 4+ messages in thread
From: Ingo Molnar @ 2013-01-24 10:18 UTC (permalink / raw)
To: Andrew Morton; +Cc: Kyle McMartin, linux-kernel, mingo
* Andrew Morton <akpm@linux-foundation.org> wrote:
> On Tue, 22 Jan 2013 14:21:03 -0500
> Kyle McMartin <kyle@redhat.com> wrote:
>
> > CONFIG_EXPERT is a bit silly a place for this, and hides it
> > unnecessarily. CONFIG_DEBUG_KERNEL makes much more sense.
> >
> > Signed-off-by: Kyle McMartin <kyle@redhat.com>
> >
> > --- a/lib/Kconfig.debug
> > +++ b/lib/Kconfig.debug
> > @@ -243,7 +243,7 @@ config BOOTPARAM_SOFTLOCKUP_PANIC_VALUE
> > default 1 if BOOTPARAM_SOFTLOCKUP_PANIC
> >
> > config PANIC_ON_OOPS
> > - bool "Panic on Oops" if EXPERT
> > + bool "Panic on Oops" if DEBUG_KERNEL
> > default n
> > help
> > Say Y here to enable the kernel to panic when it oopses. This
>
> hm, I'm not sure that it should depend on anything. Where's the benefit?
Agreed.
(The 'default n' is superfuous as well, while at it.)
Thanks,
Ingo
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] unhide CONFIG_PANIC_ON_OOPS
2013-01-24 10:18 ` Ingo Molnar
@ 2013-01-24 19:43 ` Kyle McMartin
0 siblings, 0 replies; 4+ messages in thread
From: Kyle McMartin @ 2013-01-24 19:43 UTC (permalink / raw)
To: Ingo Molnar; +Cc: Andrew Morton, linux-kernel
CONFIG_EXPERT doesn't really make sense, and hides it unintentionally.
Remove superfluous "default n" pointed out by Ingo as well.
Signed-off-by: Kyle McMartin <kyle@redhat.com>
--- a/lib/Kconfig.debug
+++ b/lib/Kconfig.debug
@@ -243,8 +243,7 @@ config BOOTPARAM_SOFTLOCKUP_PANIC_VALUE
default 1 if BOOTPARAM_SOFTLOCKUP_PANIC
config PANIC_ON_OOPS
- bool "Panic on Oops" if EXPERT
- default n
+ bool "Panic on Oops"
help
Say Y here to enable the kernel to panic when it oopses. This
has the same effect as setting oops=panic on the kernel command
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-01-24 19:43 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-01-22 19:21 [PATCH] CONFIG_PANIC_ON_OOPS should be shown if DEBUG_KERNEL Kyle McMartin
2013-01-23 22:04 ` Andrew Morton
2013-01-24 10:18 ` Ingo Molnar
2013-01-24 19:43 ` [PATCH] unhide CONFIG_PANIC_ON_OOPS Kyle McMartin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).