* [PATCH v2 1/2] usb: ehci-s5p/ohci-exynos: Fix compatible strings for the device
2013-01-24 13:45 [PATCH v2 0/2] usb: exynos: Fix compatible strings used for device Vivek Gautam
@ 2013-01-24 13:45 ` Vivek Gautam
2013-01-24 16:27 ` Alan Stern
2013-01-25 2:01 ` Jingoo Han
2013-01-24 13:45 ` [PATCH v2 2/2] usb: dwc3-exynos: " Vivek Gautam
` (2 subsequent siblings)
3 siblings, 2 replies; 9+ messages in thread
From: Vivek Gautam @ 2013-01-24 13:45 UTC (permalink / raw)
To: linux-usb
Cc: devicetree-discuss, linux-kernel, linux-samsung-soc, gregkh,
balbi, stern, kgene.kim, thomas.abraham, rob.herring,
grant.likely, sylvester.nawrocki, dianders, jg1.han, cpgs
Using specific chip in compatible strings. Newer SOCs can claim
device by using older string in the compatible list.
Signed-off-by: Vivek Gautam <gautam.vivek@samsung.com>
Acked-by: Grant Likely <grant.likely@secretlab.ca>
Reviewed-by: Doug Anderson <dianders@chromium.org>
---
drivers/usb/host/ehci-s5p.c | 2 +-
drivers/usb/host/ohci-exynos.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/host/ehci-s5p.c b/drivers/usb/host/ehci-s5p.c
index 319dcfa..f18e6ac 100644
--- a/drivers/usb/host/ehci-s5p.c
+++ b/drivers/usb/host/ehci-s5p.c
@@ -266,7 +266,7 @@ static const struct dev_pm_ops s5p_ehci_pm_ops = {
#ifdef CONFIG_OF
static const struct of_device_id exynos_ehci_match[] = {
- { .compatible = "samsung,exynos-ehci" },
+ { .compatible = "samsung,exynos4210-ehci" },
{},
};
MODULE_DEVICE_TABLE(of, exynos_ehci_match);
diff --git a/drivers/usb/host/ohci-exynos.c b/drivers/usb/host/ohci-exynos.c
index aa3b884..77f2017 100644
--- a/drivers/usb/host/ohci-exynos.c
+++ b/drivers/usb/host/ohci-exynos.c
@@ -267,7 +267,7 @@ static const struct dev_pm_ops exynos_ohci_pm_ops = {
#ifdef CONFIG_OF
static const struct of_device_id exynos_ohci_match[] = {
- { .compatible = "samsung,exynos-ohci" },
+ { .compatible = "samsung,exynos4210-ohci" },
{},
};
MODULE_DEVICE_TABLE(of, exynos_ohci_match);
--
1.7.6.5
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH v2 1/2] usb: ehci-s5p/ohci-exynos: Fix compatible strings for the device
2013-01-24 13:45 ` [PATCH v2 1/2] usb: ehci-s5p/ohci-exynos: Fix compatible strings for the device Vivek Gautam
@ 2013-01-24 16:27 ` Alan Stern
2013-01-25 2:01 ` Jingoo Han
1 sibling, 0 replies; 9+ messages in thread
From: Alan Stern @ 2013-01-24 16:27 UTC (permalink / raw)
To: Vivek Gautam
Cc: linux-usb, devicetree-discuss, linux-kernel, linux-samsung-soc,
gregkh, balbi, kgene.kim, thomas.abraham, rob.herring,
grant.likely, sylvester.nawrocki, dianders, jg1.han, cpgs
On Thu, 24 Jan 2013, Vivek Gautam wrote:
> Using specific chip in compatible strings. Newer SOCs can claim
> device by using older string in the compatible list.
>
> Signed-off-by: Vivek Gautam <gautam.vivek@samsung.com>
> Acked-by: Grant Likely <grant.likely@secretlab.ca>
> Reviewed-by: Doug Anderson <dianders@chromium.org>
Acked-by: Alan Stern <stern@rowland.harvard.edu>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2 1/2] usb: ehci-s5p/ohci-exynos: Fix compatible strings for the device
2013-01-24 13:45 ` [PATCH v2 1/2] usb: ehci-s5p/ohci-exynos: Fix compatible strings for the device Vivek Gautam
2013-01-24 16:27 ` Alan Stern
@ 2013-01-25 2:01 ` Jingoo Han
1 sibling, 0 replies; 9+ messages in thread
From: Jingoo Han @ 2013-01-25 2:01 UTC (permalink / raw)
To: 'Vivek Gautam', linux-usb
Cc: devicetree-discuss, linux-kernel, linux-samsung-soc, gregkh,
balbi, stern, kgene.kim, thomas.abraham, rob.herring,
grant.likely, sylvester.nawrocki, dianders, cpgs,
'Jingoo Han'
On Thursday, January 24, 2013 10:45 PM, Vivek Gautam wrote
>
> Using specific chip in compatible strings. Newer SOCs can claim
> device by using older string in the compatible list.
>
> Signed-off-by: Vivek Gautam <gautam.vivek@samsung.com>
> Acked-by: Grant Likely <grant.likely@secretlab.ca>
> Reviewed-by: Doug Anderson <dianders@chromium.org>
Acked-by: Jingoo Han <jg1.han@samsung.com>
Best regards,
Jingoo Han
> ---
> drivers/usb/host/ehci-s5p.c | 2 +-
> drivers/usb/host/ohci-exynos.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH v2 2/2] usb: dwc3-exynos: Fix compatible strings for the device
2013-01-24 13:45 [PATCH v2 0/2] usb: exynos: Fix compatible strings used for device Vivek Gautam
2013-01-24 13:45 ` [PATCH v2 1/2] usb: ehci-s5p/ohci-exynos: Fix compatible strings for the device Vivek Gautam
@ 2013-01-24 13:45 ` Vivek Gautam
2013-01-24 21:32 ` Greg KH
2013-01-24 14:01 ` [PATCH v2 0/2] usb: exynos: Fix compatible strings used for device Vivek Gautam
2013-01-25 18:01 ` Kukjin Kim
3 siblings, 1 reply; 9+ messages in thread
From: Vivek Gautam @ 2013-01-24 13:45 UTC (permalink / raw)
To: linux-usb
Cc: devicetree-discuss, linux-kernel, linux-samsung-soc, gregkh,
balbi, stern, kgene.kim, thomas.abraham, rob.herring,
grant.likely, sylvester.nawrocki, dianders, jg1.han, cpgs
Using specific chip in compatible strings. Newer SOCs can claim
device by using older string in the compatible list.
Signed-off-by: Vivek Gautam <gautam.vivek@samsung.com>
Acked-by: Grant Likely <grant.likely@secretlab.ca>
Reviewed-by: Doug Anderson <dianders@chromium.org>
---
drivers/usb/dwc3/dwc3-exynos.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/usb/dwc3/dwc3-exynos.c b/drivers/usb/dwc3/dwc3-exynos.c
index aae5328..e2207a6 100644
--- a/drivers/usb/dwc3/dwc3-exynos.c
+++ b/drivers/usb/dwc3/dwc3-exynos.c
@@ -188,7 +188,7 @@ static int dwc3_exynos_remove(struct platform_device *pdev)
#ifdef CONFIG_OF
static const struct of_device_id exynos_dwc3_match[] = {
- { .compatible = "samsung,exynos-dwc3" },
+ { .compatible = "samsung,exynos5250-dwusb3" },
{},
};
MODULE_DEVICE_TABLE(of, exynos_dwc3_match);
--
1.7.6.5
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH v2 2/2] usb: dwc3-exynos: Fix compatible strings for the device
2013-01-24 13:45 ` [PATCH v2 2/2] usb: dwc3-exynos: " Vivek Gautam
@ 2013-01-24 21:32 ` Greg KH
2013-01-24 22:32 ` Felipe Balbi
0 siblings, 1 reply; 9+ messages in thread
From: Greg KH @ 2013-01-24 21:32 UTC (permalink / raw)
To: Vivek Gautam
Cc: linux-usb, devicetree-discuss, linux-kernel, linux-samsung-soc,
balbi, stern, kgene.kim, thomas.abraham, rob.herring,
grant.likely, sylvester.nawrocki, dianders, jg1.han, cpgs
On Thu, Jan 24, 2013 at 07:15:30PM +0530, Vivek Gautam wrote:
> Using specific chip in compatible strings. Newer SOCs can claim
> device by using older string in the compatible list.
>
> Signed-off-by: Vivek Gautam <gautam.vivek@samsung.com>
> Acked-by: Grant Likely <grant.likely@secretlab.ca>
> Reviewed-by: Doug Anderson <dianders@chromium.org>
> ---
> drivers/usb/dwc3/dwc3-exynos.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
Felipe, want me to take this one, or will you?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2 2/2] usb: dwc3-exynos: Fix compatible strings for the device
2013-01-24 21:32 ` Greg KH
@ 2013-01-24 22:32 ` Felipe Balbi
0 siblings, 0 replies; 9+ messages in thread
From: Felipe Balbi @ 2013-01-24 22:32 UTC (permalink / raw)
To: Greg KH
Cc: Vivek Gautam, linux-usb, devicetree-discuss, linux-kernel,
linux-samsung-soc, balbi, stern, kgene.kim, thomas.abraham,
rob.herring, grant.likely, sylvester.nawrocki, dianders, jg1.han,
cpgs
[-- Attachment #1: Type: text/plain, Size: 669 bytes --]
Hi,
On Thu, Jan 24, 2013 at 01:32:13PM -0800, Greg KH wrote:
> On Thu, Jan 24, 2013 at 07:15:30PM +0530, Vivek Gautam wrote:
> > Using specific chip in compatible strings. Newer SOCs can claim
> > device by using older string in the compatible list.
> >
> > Signed-off-by: Vivek Gautam <gautam.vivek@samsung.com>
> > Acked-by: Grant Likely <grant.likely@secretlab.ca>
> > Reviewed-by: Doug Anderson <dianders@chromium.org>
> > ---
> > drivers/usb/dwc3/dwc3-exynos.c | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
>
> Felipe, want me to take this one, or will you?
I'll take in few hours after sleeping ;-)
cheers
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2 0/2] usb: exynos: Fix compatible strings used for device
2013-01-24 13:45 [PATCH v2 0/2] usb: exynos: Fix compatible strings used for device Vivek Gautam
2013-01-24 13:45 ` [PATCH v2 1/2] usb: ehci-s5p/ohci-exynos: Fix compatible strings for the device Vivek Gautam
2013-01-24 13:45 ` [PATCH v2 2/2] usb: dwc3-exynos: " Vivek Gautam
@ 2013-01-24 14:01 ` Vivek Gautam
2013-01-25 18:01 ` Kukjin Kim
3 siblings, 0 replies; 9+ messages in thread
From: Vivek Gautam @ 2013-01-24 14:01 UTC (permalink / raw)
To: linux-usb
Cc: devicetree-discuss, linux-kernel, linux-samsung-soc, gregkh,
balbi, stern, kgene.kim, thomas.abraham, rob.herring,
grant.likely, sylvester.nawrocki, dianders, jg1.han, cpgs,
Vivek Gautam
On Thu, Jan 24, 2013 at 7:15 PM, Vivek Gautam <gautam.vivek@samsung.com> wrote:
> Using chip specific compatible string as it should be.
> So fixing this for ehci-s5p, ohci-exynos and dwc3-exynos
> which till now used a generic 'exynos' in their compatible strings.
>
> Changes from v1:
> - Changing compatible string from "samsung,exynos5250-dwc3" to
> "samsung,exynos5250-dwusb3" as per discussion happened in thread:
> [PATCH 0/2] usb: exynos: Fix compatible strings used for device.
>
Based on 'usb-next' branch.
> Vivek Gautam (2):
> usb: ehci-s5p/ohci-exynos: Fix compatible strings for the device
> usb: dwc3-exynos: Fix compatible strings for the device
>
> drivers/usb/dwc3/dwc3-exynos.c | 2 +-
> drivers/usb/host/ehci-s5p.c | 2 +-
> drivers/usb/host/ohci-exynos.c | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
>
> --
> 1.7.6.5
>
--
Thanks & Regards
Vivek
^ permalink raw reply [flat|nested] 9+ messages in thread
* RE: [PATCH v2 0/2] usb: exynos: Fix compatible strings used for device
2013-01-24 13:45 [PATCH v2 0/2] usb: exynos: Fix compatible strings used for device Vivek Gautam
` (2 preceding siblings ...)
2013-01-24 14:01 ` [PATCH v2 0/2] usb: exynos: Fix compatible strings used for device Vivek Gautam
@ 2013-01-25 18:01 ` Kukjin Kim
3 siblings, 0 replies; 9+ messages in thread
From: Kukjin Kim @ 2013-01-25 18:01 UTC (permalink / raw)
To: 'Vivek Gautam', linux-usb
Cc: devicetree-discuss, linux-kernel, linux-samsung-soc, gregkh,
balbi, stern, thomas.abraham, rob.herring, grant.likely,
sylvester.nawrocki, dianders, jg1.han, cpgs
Vivek Gautam wrote:
>
> Using chip specific compatible string as it should be.
> So fixing this for ehci-s5p, ohci-exynos and dwc3-exynos
> which till now used a generic 'exynos' in their compatible strings.
>
> Changes from v1:
> - Changing compatible string from "samsung,exynos5250-dwc3" to
> "samsung,exynos5250-dwusb3" as per discussion happened in
> thread:
> [PATCH 0/2] usb: exynos: Fix compatible strings used for device.
>
> Vivek Gautam (2):
> usb: ehci-s5p/ohci-exynos: Fix compatible strings for the device
> usb: dwc3-exynos: Fix compatible strings for the device
>
> drivers/usb/dwc3/dwc3-exynos.c | 2 +-
> drivers/usb/host/ehci-s5p.c | 2 +-
> drivers/usb/host/ohci-exynos.c | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
>
For now, I'm fine on this series, I'm still thinking we need to sort out the
chip name in compatible for IP though.
Felipe, please go ahead, if you want my ack, feel free to add:
Acked-by: Kukjin Kim <kgene.kim@samsung.com>
Thanks.
- Kukjin
^ permalink raw reply [flat|nested] 9+ messages in thread