linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] sched: fix compilation warning
@ 2012-12-05 17:10 Cong Ding
  2013-01-18 20:47 ` Cong Ding
  0 siblings, 1 reply; 4+ messages in thread
From: Cong Ding @ 2012-12-05 17:10 UTC (permalink / raw)
  To: Ingo Molnar, Peter Zijlstra, linux-kernel; +Cc: Cong Ding

the following compilation warning is caused by Commit-ID:
c566e8e9e44b72b53091da20e2dedefc730f2ee2

kernel/sched/debug.c: In function ‘print_cfs_rq’:
kernel/sched/debug.c:225:2: warning: format ‘%ld’ expects argument of type
‘long int’, but argument 4 has type ‘long long int’ [-Wformat]
kernel/sched/debug.c:225:2: warning: format ‘%ld’ expects argument of type
‘long int’, but argument 3 has type ‘long long int’ [-Wformat]

where function atomic64_read returns long long int, but %ld was used in the
printf

Signed-off-by: Cong Ding <dinggnu@gmail.com>
---
 kernel/sched/debug.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/kernel/sched/debug.c b/kernel/sched/debug.c
index 2cd3c1b..83ec463 100644
--- a/kernel/sched/debug.c
+++ b/kernel/sched/debug.c
@@ -222,7 +222,7 @@ void print_cfs_rq(struct seq_file *m, int cpu, struct cfs_rq *cfs_rq)
 			cfs_rq->runnable_load_avg);
 	SEQ_printf(m, "  .%-30s: %lld\n", "blocked_load_avg",
 			cfs_rq->blocked_load_avg);
-	SEQ_printf(m, "  .%-30s: %ld\n", "tg_load_avg",
+	SEQ_printf(m, "  .%-30s: %lld\n", "tg_load_avg",
 			atomic64_read(&cfs_rq->tg->load_avg));
 	SEQ_printf(m, "  .%-30s: %lld\n", "tg_load_contrib",
 			cfs_rq->tg_load_contrib);
-- 
1.7.4.5


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] sched: fix compilation warning
  2012-12-05 17:10 [PATCH] sched: fix compilation warning Cong Ding
@ 2013-01-18 20:47 ` Cong Ding
  2013-01-19 19:26   ` Randy Dunlap
  0 siblings, 1 reply; 4+ messages in thread
From: Cong Ding @ 2013-01-18 20:47 UTC (permalink / raw)
  To: Ingo Molnar, Peter Zijlstra, Linux Kernel Mailing List; +Cc: Cong Ding

Is this patch still queued or...?

- cong

On Wed, Dec 5, 2012 at 6:10 PM, Cong Ding <dinggnu@gmail.com> wrote:
> the following compilation warning is caused by Commit-ID:
> c566e8e9e44b72b53091da20e2dedefc730f2ee2
>
> kernel/sched/debug.c: In function ‘print_cfs_rq’:
> kernel/sched/debug.c:225:2: warning: format ‘%ld’ expects argument of type
> ‘long int’, but argument 4 has type ‘long long int’ [-Wformat]
> kernel/sched/debug.c:225:2: warning: format ‘%ld’ expects argument of type
> ‘long int’, but argument 3 has type ‘long long int’ [-Wformat]
>
> where function atomic64_read returns long long int, but %ld was used in the
> printf
>
> Signed-off-by: Cong Ding <dinggnu@gmail.com>
> ---
>  kernel/sched/debug.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/kernel/sched/debug.c b/kernel/sched/debug.c
> index 2cd3c1b..83ec463 100644
> --- a/kernel/sched/debug.c
> +++ b/kernel/sched/debug.c
> @@ -222,7 +222,7 @@ void print_cfs_rq(struct seq_file *m, int cpu, struct cfs_rq *cfs_rq)
>                         cfs_rq->runnable_load_avg);
>         SEQ_printf(m, "  .%-30s: %lld\n", "blocked_load_avg",
>                         cfs_rq->blocked_load_avg);
> -       SEQ_printf(m, "  .%-30s: %ld\n", "tg_load_avg",
> +       SEQ_printf(m, "  .%-30s: %lld\n", "tg_load_avg",
>                         atomic64_read(&cfs_rq->tg->load_avg));
>         SEQ_printf(m, "  .%-30s: %lld\n", "tg_load_contrib",
>                         cfs_rq->tg_load_contrib);
> --
> 1.7.4.5
>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] sched: fix compilation warning
  2013-01-18 20:47 ` Cong Ding
@ 2013-01-19 19:26   ` Randy Dunlap
  2013-01-27 13:59     ` [PATCH resend] " Cong Ding
  0 siblings, 1 reply; 4+ messages in thread
From: Randy Dunlap @ 2013-01-19 19:26 UTC (permalink / raw)
  To: Cong Ding; +Cc: Ingo Molnar, Peter Zijlstra, Linux Kernel Mailing List

On 01/18/13 12:47, Cong Ding wrote:
> Is this patch still queued or...?
> 
> - cong

ping.
Can we get this patch or something similar merged, please?


> On Wed, Dec 5, 2012 at 6:10 PM, Cong Ding <dinggnu@gmail.com> wrote:
>> the following compilation warning is caused by Commit-ID:
>> c566e8e9e44b72b53091da20e2dedefc730f2ee2
>>
>> kernel/sched/debug.c: In function ‘print_cfs_rq’:
>> kernel/sched/debug.c:225:2: warning: format ‘%ld’ expects argument of type
>> ‘long int’, but argument 4 has type ‘long long int’ [-Wformat]
>> kernel/sched/debug.c:225:2: warning: format ‘%ld’ expects argument of type
>> ‘long int’, but argument 3 has type ‘long long int’ [-Wformat]
>>
>> where function atomic64_read returns long long int, but %ld was used in the
>> printf
>>
>> Signed-off-by: Cong Ding <dinggnu@gmail.com>
>> ---
>>  kernel/sched/debug.c |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/kernel/sched/debug.c b/kernel/sched/debug.c
>> index 2cd3c1b..83ec463 100644
>> --- a/kernel/sched/debug.c
>> +++ b/kernel/sched/debug.c
>> @@ -222,7 +222,7 @@ void print_cfs_rq(struct seq_file *m, int cpu, struct cfs_rq *cfs_rq)
>>                         cfs_rq->runnable_load_avg);
>>         SEQ_printf(m, "  .%-30s: %lld\n", "blocked_load_avg",
>>                         cfs_rq->blocked_load_avg);
>> -       SEQ_printf(m, "  .%-30s: %ld\n", "tg_load_avg",
>> +       SEQ_printf(m, "  .%-30s: %lld\n", "tg_load_avg",
>>                         atomic64_read(&cfs_rq->tg->load_avg));
>>         SEQ_printf(m, "  .%-30s: %lld\n", "tg_load_contrib",
>>                         cfs_rq->tg_load_contrib);
>> --


-- 
~Randy

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH resend] sched: fix compilation warning
  2013-01-19 19:26   ` Randy Dunlap
@ 2013-01-27 13:59     ` Cong Ding
  0 siblings, 0 replies; 4+ messages in thread
From: Cong Ding @ 2013-01-27 13:59 UTC (permalink / raw)
  To: Ingo Molnar; +Cc: Peter Zijlstra, Linux Kernel Mailing List, Randy Dunlap

the following compilation warning is caused by Commit-ID:
c566e8e9e44b72b53091da20e2dedefc730f2ee2

kernel/sched/debug.c: In function ‘print_cfs_rq’:
kernel/sched/debug.c:225:2: warning: format ‘%ld’ expects argument of type
‘long int’, but argument 4 has type ‘long long int’ [-Wformat]
kernel/sched/debug.c:225:2: warning: format ‘%ld’ expects argument of type
‘long int’, but argument 3 has type ‘long long int’ [-Wformat]

where function atomic64_read returns long long int, but %ld was used in the
printf

Signed-off-by: Cong Ding <dinggnu@gmail.com>
---
resend because no reply for
Message-Id: <1354727440-20157-1-git-send-email-dinggnu@gmail.com>

 kernel/sched/debug.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/sched/debug.c b/kernel/sched/debug.c
index 2cd3c1b..83ec463 100644
--- a/kernel/sched/debug.c
+++ b/kernel/sched/debug.c
@@ -222,7 +222,7 @@ void print_cfs_rq(struct seq_file *m, int cpu, struct cfs_rq *cfs_rq)
 			cfs_rq->runnable_load_avg);
 	SEQ_printf(m, "  .%-30s: %lld\n", "blocked_load_avg",
 			cfs_rq->blocked_load_avg);
-	SEQ_printf(m, "  .%-30s: %ld\n", "tg_load_avg",
+	SEQ_printf(m, "  .%-30s: %lld\n", "tg_load_avg",
 			atomic64_read(&cfs_rq->tg->load_avg));
 	SEQ_printf(m, "  .%-30s: %lld\n", "tg_load_contrib",
 			cfs_rq->tg_load_contrib);
-- 
1.7.10.4


^ permalink raw reply related	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2013-01-27 13:59 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-12-05 17:10 [PATCH] sched: fix compilation warning Cong Ding
2013-01-18 20:47 ` Cong Ding
2013-01-19 19:26   ` Randy Dunlap
2013-01-27 13:59     ` [PATCH resend] " Cong Ding

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).