* [PATCH] ARM: Kirkwood: Add missing linux/i2c.h include
@ 2013-02-05 15:10 Thierry Reding
2013-02-05 15:34 ` Jason Cooper
0 siblings, 1 reply; 4+ messages in thread
From: Thierry Reding @ 2013-02-05 15:10 UTC (permalink / raw)
To: Jason Cooper; +Cc: Andrew Lunn, linux-arm-kernel, linux-kernel
The nsa310 board uses I2C_BOARD_INFO and i2c_register_board_info(), both
of which are defined in the linux/i2c.h header file.
Signed-off-by: Thierry Reding <thierry.reding@avionic-design.de>
---
arch/arm/mach-kirkwood/board-nsa310.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/mach-kirkwood/board-nsa310.c b/arch/arm/mach-kirkwood/board-nsa310.c
index 61c4b18..970174a 100644
--- a/arch/arm/mach-kirkwood/board-nsa310.c
+++ b/arch/arm/mach-kirkwood/board-nsa310.c
@@ -11,6 +11,7 @@
#include <linux/kernel.h>
#include <linux/init.h>
#include <linux/gpio.h>
+#include <linux/i2c.h>
#include <mach/kirkwood.h>
#include <linux/of.h>
#include "common.h"
--
1.8.1.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] ARM: Kirkwood: Add missing linux/i2c.h include
2013-02-05 15:10 [PATCH] ARM: Kirkwood: Add missing linux/i2c.h include Thierry Reding
@ 2013-02-05 15:34 ` Jason Cooper
2013-02-05 15:38 ` Thierry Reding
0 siblings, 1 reply; 4+ messages in thread
From: Jason Cooper @ 2013-02-05 15:34 UTC (permalink / raw)
To: Thierry Reding; +Cc: Andrew Lunn, linux-arm-kernel, linux-kernel
Thierry,
On Tue, Feb 05, 2013 at 04:10:25PM +0100, Thierry Reding wrote:
> The nsa310 board uses I2C_BOARD_INFO and i2c_register_board_info(), both
> of which are defined in the linux/i2c.h header file.
>
> Signed-off-by: Thierry Reding <thierry.reding@avionic-design.de>
> ---
> arch/arm/mach-kirkwood/board-nsa310.c | 1 +
> 1 file changed, 1 insertion(+)
What is this based against? We're in the process of removing this whole
file for v3.9 (pinctrl, mv643xx_eth, and i2c)...
thx,
Jason.
>
> diff --git a/arch/arm/mach-kirkwood/board-nsa310.c b/arch/arm/mach-kirkwood/board-nsa310.c
> index 61c4b18..970174a 100644
> --- a/arch/arm/mach-kirkwood/board-nsa310.c
> +++ b/arch/arm/mach-kirkwood/board-nsa310.c
> @@ -11,6 +11,7 @@
> #include <linux/kernel.h>
> #include <linux/init.h>
> #include <linux/gpio.h>
> +#include <linux/i2c.h>
> #include <mach/kirkwood.h>
> #include <linux/of.h>
> #include "common.h"
> --
> 1.8.1.2
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ARM: Kirkwood: Add missing linux/i2c.h include
2013-02-05 15:34 ` Jason Cooper
@ 2013-02-05 15:38 ` Thierry Reding
2013-02-05 15:52 ` Jason Cooper
0 siblings, 1 reply; 4+ messages in thread
From: Thierry Reding @ 2013-02-05 15:38 UTC (permalink / raw)
To: Jason Cooper; +Cc: Andrew Lunn, linux-arm-kernel, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 714 bytes --]
On Tue, Feb 05, 2013 at 10:34:11AM -0500, Jason Cooper wrote:
> Thierry,
>
> On Tue, Feb 05, 2013 at 04:10:25PM +0100, Thierry Reding wrote:
> > The nsa310 board uses I2C_BOARD_INFO and i2c_register_board_info(), both
> > of which are defined in the linux/i2c.h header file.
> >
> > Signed-off-by: Thierry Reding <thierry.reding@avionic-design.de>
> > ---
> > arch/arm/mach-kirkwood/board-nsa310.c | 1 +
> > 1 file changed, 1 insertion(+)
>
> What is this based against? We're in the process of removing this whole
> file for v3.9 (pinctrl, mv643xx_eth, and i2c)...
It's based on today's linux-next, so if you're going to drop that file
for 3.9 I guess you can ignore the patch.
Thierry
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ARM: Kirkwood: Add missing linux/i2c.h include
2013-02-05 15:38 ` Thierry Reding
@ 2013-02-05 15:52 ` Jason Cooper
0 siblings, 0 replies; 4+ messages in thread
From: Jason Cooper @ 2013-02-05 15:52 UTC (permalink / raw)
To: Thierry Reding; +Cc: Andrew Lunn, linux-arm-kernel, linux-kernel
On Tue, Feb 05, 2013 at 04:38:07PM +0100, Thierry Reding wrote:
> On Tue, Feb 05, 2013 at 10:34:11AM -0500, Jason Cooper wrote:
> > Thierry,
> >
> > On Tue, Feb 05, 2013 at 04:10:25PM +0100, Thierry Reding wrote:
> > > The nsa310 board uses I2C_BOARD_INFO and i2c_register_board_info(), both
> > > of which are defined in the linux/i2c.h header file.
> > >
> > > Signed-off-by: Thierry Reding <thierry.reding@avionic-design.de>
> > > ---
> > > arch/arm/mach-kirkwood/board-nsa310.c | 1 +
> > > 1 file changed, 1 insertion(+)
> >
> > What is this based against? We're in the process of removing this whole
> > file for v3.9 (pinctrl, mv643xx_eth, and i2c)...
>
> It's based on today's linux-next, so if you're going to drop that file
> for 3.9 I guess you can ignore the patch.
ok, thanks.
Jason.
>
> Thierry
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-02-05 15:52 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-02-05 15:10 [PATCH] ARM: Kirkwood: Add missing linux/i2c.h include Thierry Reding
2013-02-05 15:34 ` Jason Cooper
2013-02-05 15:38 ` Thierry Reding
2013-02-05 15:52 ` Jason Cooper
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).