* [PATCH] devicetree: Move NS2 LEDs binding into LEDs directory
@ 2013-02-07 12:22 Grant Likely
2013-02-07 13:21 ` Jason Cooper
0 siblings, 1 reply; 3+ messages in thread
From: Grant Likely @ 2013-02-07 12:22 UTC (permalink / raw)
To: linux-kernel, devicetree-discuss
Cc: Grant Likely, Andrew Lunn, Simon Guinot, Jason Cooper
leds-ns2.txt is a binding for LEDs, not GPIOs. Move the documentation in
with the rest of the LEDs bindings.
Cc: Andrew Lunn <andrew@lunn.ch>
Cc: Simon Guinot <simon.guinot@sequanux.org>
Cc: Jason Cooper <jason@lakedaemon.net>
Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
---
.../devicetree/bindings/gpio/leds-ns2.txt | 26 --------------------
.../devicetree/bindings/leds/leds-ns2.txt | 26 ++++++++++++++++++++
2 files changed, 26 insertions(+), 26 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/gpio/leds-ns2.txt
create mode 100644 Documentation/devicetree/bindings/leds/leds-ns2.txt
diff --git a/Documentation/devicetree/bindings/gpio/leds-ns2.txt b/Documentation/devicetree/bindings/gpio/leds-ns2.txt
deleted file mode 100644
index aef3aca..0000000
--- a/Documentation/devicetree/bindings/gpio/leds-ns2.txt
+++ /dev/null
@@ -1,26 +0,0 @@
-Binding for dual-GPIO LED found on Network Space v2 (and parents).
-
-Required properties:
-- compatible: "lacie,ns2-leds".
-
-Each LED is represented as a sub-node of the ns2-leds device.
-
-Required sub-node properties:
-- cmd-gpio: Command LED GPIO. See OF device-tree GPIO specification.
-- slow-gpio: Slow LED GPIO. See OF device-tree GPIO specification.
-
-Optional sub-node properties:
-- label: Name for this LED. If omitted, the label is taken from the node name.
-- linux,default-trigger: Trigger assigned to the LED.
-
-Example:
-
-ns2-leds {
- compatible = "lacie,ns2-leds";
-
- blue-sata {
- label = "ns2:blue:sata";
- slow-gpio = <&gpio0 29 0>;
- cmd-gpio = <&gpio0 30 0>;
- };
-};
diff --git a/Documentation/devicetree/bindings/leds/leds-ns2.txt b/Documentation/devicetree/bindings/leds/leds-ns2.txt
new file mode 100644
index 0000000..aef3aca
--- /dev/null
+++ b/Documentation/devicetree/bindings/leds/leds-ns2.txt
@@ -0,0 +1,26 @@
+Binding for dual-GPIO LED found on Network Space v2 (and parents).
+
+Required properties:
+- compatible: "lacie,ns2-leds".
+
+Each LED is represented as a sub-node of the ns2-leds device.
+
+Required sub-node properties:
+- cmd-gpio: Command LED GPIO. See OF device-tree GPIO specification.
+- slow-gpio: Slow LED GPIO. See OF device-tree GPIO specification.
+
+Optional sub-node properties:
+- label: Name for this LED. If omitted, the label is taken from the node name.
+- linux,default-trigger: Trigger assigned to the LED.
+
+Example:
+
+ns2-leds {
+ compatible = "lacie,ns2-leds";
+
+ blue-sata {
+ label = "ns2:blue:sata";
+ slow-gpio = <&gpio0 29 0>;
+ cmd-gpio = <&gpio0 30 0>;
+ };
+};
--
1.7.10.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] devicetree: Move NS2 LEDs binding into LEDs directory
2013-02-07 12:22 [PATCH] devicetree: Move NS2 LEDs binding into LEDs directory Grant Likely
@ 2013-02-07 13:21 ` Jason Cooper
2013-02-08 22:05 ` Grant Likely
0 siblings, 1 reply; 3+ messages in thread
From: Jason Cooper @ 2013-02-07 13:21 UTC (permalink / raw)
To: Grant Likely; +Cc: linux-kernel, devicetree-discuss, Andrew Lunn, Simon Guinot
On Thu, Feb 07, 2013 at 12:22:56PM +0000, Grant Likely wrote:
> leds-ns2.txt is a binding for LEDs, not GPIOs. Move the documentation in
> with the rest of the LEDs bindings.
>
> Cc: Andrew Lunn <andrew@lunn.ch>
> Cc: Simon Guinot <simon.guinot@sequanux.org>
> Cc: Jason Cooper <jason@lakedaemon.net>
> Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
> ---
> .../devicetree/bindings/gpio/leds-ns2.txt | 26 --------------------
> .../devicetree/bindings/leds/leds-ns2.txt | 26 ++++++++++++++++++++
> 2 files changed, 26 insertions(+), 26 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/gpio/leds-ns2.txt
> create mode 100644 Documentation/devicetree/bindings/leds/leds-ns2.txt
Acked-by: Jason Cooper <jason@lakedaemon.net>
or, if you want, I can queue it up. Just let me know.
thx,
Jason.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] devicetree: Move NS2 LEDs binding into LEDs directory
2013-02-07 13:21 ` Jason Cooper
@ 2013-02-08 22:05 ` Grant Likely
0 siblings, 0 replies; 3+ messages in thread
From: Grant Likely @ 2013-02-08 22:05 UTC (permalink / raw)
To: Jason Cooper; +Cc: linux-kernel, devicetree-discuss, Andrew Lunn, Simon Guinot
On Thu, 7 Feb 2013 08:21:18 -0500, Jason Cooper <jason@lakedaemon.net> wrote:
> On Thu, Feb 07, 2013 at 12:22:56PM +0000, Grant Likely wrote:
> > leds-ns2.txt is a binding for LEDs, not GPIOs. Move the documentation in
> > with the rest of the LEDs bindings.
> >
> > Cc: Andrew Lunn <andrew@lunn.ch>
> > Cc: Simon Guinot <simon.guinot@sequanux.org>
> > Cc: Jason Cooper <jason@lakedaemon.net>
> > Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
> > ---
> > .../devicetree/bindings/gpio/leds-ns2.txt | 26 --------------------
> > .../devicetree/bindings/leds/leds-ns2.txt | 26 ++++++++++++++++++++
> > 2 files changed, 26 insertions(+), 26 deletions(-)
> > delete mode 100644 Documentation/devicetree/bindings/gpio/leds-ns2.txt
> > create mode 100644 Documentation/devicetree/bindings/leds/leds-ns2.txt
>
> Acked-by: Jason Cooper <jason@lakedaemon.net>
>
> or, if you want, I can queue it up. Just let me know.
No, I got it. It was trivial so I committed it directly without waiting
for review comments.
g.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-02-08 22:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-02-07 12:22 [PATCH] devicetree: Move NS2 LEDs binding into LEDs directory Grant Likely
2013-02-07 13:21 ` Jason Cooper
2013-02-08 22:05 ` Grant Likely
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).