[PATCH] s390: Add missing PAGE_SHARED as an alias for PAGE_RW

[PATCH] s390: Add missing PAGE_SHARED as an alias for PAGE_RW

[Geert Uytterhoeven]

s390 allmodconfig:

drivers/gpu/drm/udl/udl_fb.c:237:52: error: 'PAGE_SHARED' undeclared (first use in this function)
drivers/media/pci/zoran/zoran_driver.c:2955:14: error: 'PAGE_SHARED' undeclared (first use in this function)
drivers/media/usb/cpia2/cpia2_core.c:2405:66: error: 'PAGE_SHARED' undeclared (first use in this function)
drivers/video/udlfb.c:337:52: error: 'PAGE_SHARED' undeclared (first use in this function)
drivers/video/smscufx.c:795:52: error: 'PAGE_SHARED' undeclared (first use in this function)
drivers/video/vfb.c:431:52: error: 'PAGE_SHARED' undeclared (first use in this function)

According to an email from Martin a few years ago, the equivalent define
for s390 is PAGE_RW, so make PAGE_SHARED an alias for PAGE_RW.

Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
 arch/s390/include/asm/pgtable.h |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/arch/s390/include/asm/pgtable.h b/arch/s390/include/asm/pgtable.h
index 098adbb..0ca3e62 100644
--- a/arch/s390/include/asm/pgtable.h
+++ b/arch/s390/include/asm/pgtable.h
@@ -386,6 +386,7 @@ extern unsigned long MODULES_END;
 
 #define PAGE_KERNEL	PAGE_RW
 #define PAGE_COPY	PAGE_RO
+#define PAGE_SHARED	PAGE_RW
 
 /*
  * On s390 the page table entry has an invalid bit and a read-only bit.
-- 
1.7.0.4

Re: [PATCH] s390: Add missing PAGE_SHARED as an alias for PAGE_RW

[Heiko Carstens]

On Sat, Feb 09, 2013 at 06:54:45PM +0100, Geert Uytterhoeven wrote:
> s390 allmodconfig:
> 
> drivers/gpu/drm/udl/udl_fb.c:237:52: error: 'PAGE_SHARED' undeclared (first use in this function)
> drivers/media/pci/zoran/zoran_driver.c:2955:14: error: 'PAGE_SHARED' undeclared (first use in this function)
> drivers/media/usb/cpia2/cpia2_core.c:2405:66: error: 'PAGE_SHARED' undeclared (first use in this function)
> drivers/video/udlfb.c:337:52: error: 'PAGE_SHARED' undeclared (first use in this function)
> drivers/video/smscufx.c:795:52: error: 'PAGE_SHARED' undeclared (first use in this function)
> drivers/video/vfb.c:431:52: error: 'PAGE_SHARED' undeclared (first use in this function)
> 
> According to an email from Martin a few years ago, the equivalent define
> for s390 is PAGE_RW, so make PAGE_SHARED an alias for PAGE_RW.
> 
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> ---
>  arch/s390/include/asm/pgtable.h |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/s390/include/asm/pgtable.h b/arch/s390/include/asm/pgtable.h
> index 098adbb..0ca3e62 100644
> --- a/arch/s390/include/asm/pgtable.h
> +++ b/arch/s390/include/asm/pgtable.h
> @@ -386,6 +386,7 @@ extern unsigned long MODULES_END;
> 
>  #define PAGE_KERNEL	PAGE_RW
>  #define PAGE_COPY	PAGE_RO
> +#define PAGE_SHARED	PAGE_RW

Thanks Geert. A similar patch however is already in linux-next, together
with a whole bunch of other patches which try to make s390's allmodconfig
compile again after PCI, HAS_DMA and HAS_IOMEM got enabled by our new PCI
code.

Re: [PATCH] s390: Add missing PAGE_SHARED as an alias for PAGE_RW

[Geert Uytterhoeven]

Hi Heiko,

On Mon, Feb 11, 2013 at 10:11 AM, Heiko Carstens
<heiko.carstens@de.ibm.com> wrote:
> Thanks Geert. A similar patch however is already in linux-next, together
> with a whole bunch of other patches which try to make s390's allmodconfig
> compile again after PCI, HAS_DMA and HAS_IOMEM got enabled by our new PCI
> code.

Cool!

Will you select HAVE_GENERIC_HARDIRQS soon, too?

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH] s390: Add missing PAGE_SHARED as an alias for PAGE_RW

[Heiko Carstens]

On Tue, Feb 12, 2013 at 10:20:22AM +0100, Geert Uytterhoeven wrote:
> Hi Heiko,
> 
> On Mon, Feb 11, 2013 at 10:11 AM, Heiko Carstens
> <heiko.carstens@de.ibm.com> wrote:
> > Thanks Geert. A similar patch however is already in linux-next, together
> > with a whole bunch of other patches which try to make s390's allmodconfig
> > compile again after PCI, HAS_DMA and HAS_IOMEM got enabled by our new PCI
> > code.
> 
> Cool!
> 
> Will you select HAVE_GENERIC_HARDIRQS soon, too?

I discussed that just with Martin, and looking at the code it doesn't look
like we want to have GENERIC_HARDIRQS.
If we would select that option it looks like we need to special case the
common generic hardirqs code quite a lot, which is something we certainly
do not want.
However that's our result after looking 5 minutes into the code ;)
So, if at all, it's not going to happen soon.