Re: [regression] external HDD in USB3 enclosure cannot be dynamically removed (Re: Linux 3.7.5)

From: Matthias Schniedermeyer <ms@citd.de>
To: Sarah Sharp <sarah.a.sharp@linux.intel.com>
Cc: "Holger Hoffstätte" <holger.hoffstaette@googlemail.com>,
	"Jonathan Nieder" <jrnieder@gmail.com>,
	stable@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-usb@vger.kernel.org, "Greg KH" <gregkh@linuxfoundation.org>,
	"Tilman Schmidt" <tilman@imap.cc>
Subject: Re: [regression] external HDD in USB3 enclosure cannot be dynamically removed (Re: Linux 3.7.5)
Date: Wed, 13 Feb 2013 21:04:13 +0100	[thread overview]
Message-ID: <20130213200413.GA17648@citd.de> (raw)
In-Reply-To: <20130213193303.GH8427@xanatos>

[-- Attachment #1: Type: text/plain, Size: 1720 bytes --]

On 13.02.2013 11:33, Sarah Sharp wrote:
> On Wed, Feb 13, 2013 at 06:16:56PM +0100, Matthias Schniedermeyer wrote:
> > On 13.02.2013 09:28, Holger Hoffstätte wrote:
> > > On 12.02.2013 21:42, Sarah Sharp wrote:
> > > > [..]
> > > > There was a further set of patches queued for 3.9 to deal with connected
> > > > devices going to the Inactive state, but they looked like they were too
> > > > big for stable:
> > > > 
> > > > d3b9d7a USB: Fix connected device switch to Inactive state.
> > > > a24a607 USB: Rip out recursive call on warm port reset.
> > > > 2d4fa94 USB: Prepare for refactoring by adding extra udev checks.
> > > > 0fe51aa USB: Don't use EHCI port sempahore for USB 3.0 hubs.
> > > > 
> > > > Can you retry with Greg's usb-next branch?
> > > > 
> > > > git clone git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git -b usb-next
> > > > 
> > > > If that fixes your problem, we should either get those additional
> > > > patches into 3.8 and the stable trees, or do a revert of the whole
> > > > series and just let 3.9 carry the full patchset.
> > > 
> > > Good news! This one does indeed work as expected - the device can be
> > > removed and is gone for good. Upstream & Stable plz :)
> > 
> > That kernel fixes the problem for me too.
> 
> Great!
> 
> Holger and Matthias, can you double check that cherry picking just those
> four patches on top of 3.7.7 or 3.8 works as well?

3.7.7 + those 4 patches workes for me.

As i'm not very firm in git i generated separate diffs for each commit 
and applying them in the order 2d4fa94 0fe51aa d3b9d7a a24a607 worked 
without hunks dropped.

I have attached `git diff` against vanilla 3.7.7, so you can check that 
i got it right.

-- 

Matthias

[-- Attachment #2: combined.diff.gz --]
[-- Type: application/octet-stream, Size: 2241 bytes --]