From: Grant Likely <grant.likely@secretlab.ca>
To: Thierry Reding <thierry.reding@avionic-design.de>
Cc: Rob Herring <rob.herring@calxeda.com>,
Andrew Murray <andrew.murray@arm.com>,
Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
devicetree-discuss@lists.ozlabs.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/4] of/pci: Add of_pci_parse_bus_range() function
Date: Wed, 13 Feb 2013 22:58:44 +0000 [thread overview]
Message-ID: <20130213225844.B79093E3557@localhost> (raw)
In-Reply-To: <1360570940-17086-5-git-send-email-thierry.reding@avionic-design.de>
On Mon, 11 Feb 2013 09:22:20 +0100, Thierry Reding <thierry.reding@avionic-design.de> wrote:
> This function can be used to parse a bus-range property as specified by
> device nodes representing PCI bridges.
>
> Signed-off-by: Thierry Reding <thierry.reding@avionic-design.de>
Ditto for this one. We can wait on it until there is a user.
> ---
> drivers/of/of_pci.c | 25 +++++++++++++++++++++++++
> include/linux/of_pci.h | 1 +
> 2 files changed, 26 insertions(+)
>
> diff --git a/drivers/of/of_pci.c b/drivers/of/of_pci.c
> index d6e6de5..fb92ded 100644
> --- a/drivers/of/of_pci.c
> +++ b/drivers/of/of_pci.c
> @@ -85,3 +85,28 @@ int of_pci_get_devfn(struct device_node *np)
> return (be32_to_cpup(reg) >> 8) & 0xff;
> }
> EXPORT_SYMBOL_GPL(of_pci_get_devfn);
> +
> +/**
> + * of_pci_parse_bus_range() - parse the bus-range property of a PCI device
> + * @node: device node
> + * @res: address to a struct resource to return the bus-range
> + *
> + * Returns 0 on success or a negative error-code on failure.
> + */
> +int of_pci_parse_bus_range(struct device_node *node, struct resource *res)
> +{
> + const __be32 *values;
> + int len;
> +
> + values = of_get_property(node, "bus-range", &len);
> + if (!values || len < sizeof(*values) * 2)
> + return -EINVAL;
> +
> + res->name = node->name;
> + res->start = be32_to_cpup(values++);
> + res->end = be32_to_cpup(values);
> + res->flags = IORESOURCE_BUS;
Is there precedence for using struct resource for passing around the PCI
bus range values? Who will be the user of this function?
g.
next prev parent reply other threads:[~2013-02-13 22:59 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-11 8:22 [PATCH 0/4] Various PCI-related device tree helpers Thierry Reding
2013-02-11 8:22 ` [PATCH 1/4] of/pci: Provide support for parsing PCI DT ranges property Thierry Reding
2013-02-11 19:43 ` Rob Herring
2013-02-12 6:45 ` Thierry Reding
2013-02-13 14:23 ` Rob Herring
2013-02-13 14:25 ` Thierry Reding
2013-02-13 19:54 ` Rob Herring
2013-02-13 21:29 ` Thierry Reding
2013-02-13 22:09 ` Grant Likely
2013-02-14 7:05 ` Thierry Reding
2013-02-13 22:53 ` Grant Likely
2013-02-14 16:53 ` Andrew Murray
2013-02-14 19:17 ` Thierry Reding
2013-02-15 4:52 ` Thomas Petazzoni
2013-02-15 13:16 ` Linus Walleij
2013-02-18 9:38 ` Andrew Murray
2013-02-11 8:22 ` [PATCH v2 2/4] of/pci: Add of_pci_get_devfn() function Thierry Reding
2013-02-13 22:59 ` Grant Likely
2013-02-14 6:52 ` Thierry Reding
2013-02-11 8:22 ` [PATCH 3/4] of/pci: Add of_pci_get_bus() function Thierry Reding
2013-02-13 22:56 ` Grant Likely
2013-02-14 6:52 ` Thierry Reding
2013-02-11 8:22 ` [PATCH 4/4] of/pci: Add of_pci_parse_bus_range() function Thierry Reding
2013-02-13 22:58 ` Grant Likely [this message]
2013-02-14 6:52 ` Thierry Reding
2013-02-13 13:48 ` [PATCH 0/4] Various PCI-related device tree helpers Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130213225844.B79093E3557@localhost \
--to=grant.likely@secretlab.ca \
--cc=andrew.murray@arm.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rob.herring@calxeda.com \
--cc=thierry.reding@avionic-design.de \
--cc=thomas.petazzoni@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).