* Re: + futex-avoid-kernel-taint-caused-by-get_robust_list.patch added to -mm tree
[not found] <20130215222653.B8B115A41F0@corp2gmr1-2.hot.corp.google.com>
@ 2013-02-15 22:44 ` Richard Weinberger
2013-02-15 22:58 ` Andrew Morton
2013-02-16 7:02 ` Cyrill Gorcunov
0 siblings, 2 replies; 4+ messages in thread
From: Richard Weinberger @ 2013-02-15 22:44 UTC (permalink / raw)
To: akpm
Cc: linux-kernel, paul.gortmaker, davej, keescook, stable, tglx,
gorcunov, ebiederm
Am Fri, 15 Feb 2013 14:26:52 -0800
schrieb akpm@linux-foundation.org:
> ------------------------------------------------------
> From: Paul Gortmaker <paul.gortmaker@windriver.com>
> Subject: futex: avoid kernel taint caused by get_robust_list
>
> Commit ec0c4274e33c0373e4 ("futex: Mark get_robust_list as
> deprecated") added these two WARN_ONCE calls.
>
> However, WARN_ONCE taints the kernel, and we shouldn't be allowing any
> user who wanders by to do this. For example, the system fuzzer
> "trinity" uses the tainted state as a metric for when to stop,
> assuming that it has caused significant wreckage (and indeed that
> tool is what actually led me to this change).
>
> The ability to deprecate this code has been called into question[1],
> but if that remains to be finalized, then making this change in the
> interim seems to make sense.
Do we really want to remove this system call in 2013?
Note, Documentation/feature-removal-schedule.txt is gone...
CRIU folks, I guess you still need the call?
Or have you found an alternative way to get the robost list?
As stated in [0], I'd simply revert commit ec0c4274 ("futex: Mark
get_robust_list as deprecated")
Thanks,
//richard
[0] http://permalink.gmane.org/gmane.linux.kernel.hardened.devel/506
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: + futex-avoid-kernel-taint-caused-by-get_robust_list.patch added to -mm tree
2013-02-15 22:44 ` + futex-avoid-kernel-taint-caused-by-get_robust_list.patch added to -mm tree Richard Weinberger
@ 2013-02-15 22:58 ` Andrew Morton
2013-02-16 7:02 ` Cyrill Gorcunov
1 sibling, 0 replies; 4+ messages in thread
From: Andrew Morton @ 2013-02-15 22:58 UTC (permalink / raw)
To: Richard Weinberger
Cc: linux-kernel, paul.gortmaker, davej, keescook, stable, tglx,
gorcunov, ebiederm
On Fri, 15 Feb 2013 23:44:44 +0100
Richard Weinberger <richard@nod.at> wrote:
> As stated in [0], I'd simply revert commit ec0c4274 ("futex: Mark
> get_robust_list as deprecated")
Too much talk, not enough patches. I typed it all in again.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: + futex-avoid-kernel-taint-caused-by-get_robust_list.patch added to -mm tree
2013-02-15 22:44 ` + futex-avoid-kernel-taint-caused-by-get_robust_list.patch added to -mm tree Richard Weinberger
2013-02-15 22:58 ` Andrew Morton
@ 2013-02-16 7:02 ` Cyrill Gorcunov
2013-02-18 8:55 ` Thomas Gleixner
1 sibling, 1 reply; 4+ messages in thread
From: Cyrill Gorcunov @ 2013-02-16 7:02 UTC (permalink / raw)
To: Richard Weinberger
Cc: akpm, linux-kernel, paul.gortmaker, davej, keescook, stable,
tglx, ebiederm
On Fri, Feb 15, 2013 at 11:44:44PM +0100, Richard Weinberger wrote:
> > The ability to deprecate this code has been called into question[1],
> > but if that remains to be finalized, then making this change in the
> > interim seems to make sense.
>
> Do we really want to remove this system call in 2013?
> Note, Documentation/feature-removal-schedule.txt is gone...
>
> CRIU folks, I guess you still need the call?
> Or have you found an alternative way to get the robost list?
Yes, we need this call and we use it.
> As stated in [0], I'd simply revert commit ec0c4274 ("futex: Mark
> get_robust_list as deprecated")
Thanks!
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: + futex-avoid-kernel-taint-caused-by-get_robust_list.patch added to -mm tree
2013-02-16 7:02 ` Cyrill Gorcunov
@ 2013-02-18 8:55 ` Thomas Gleixner
0 siblings, 0 replies; 4+ messages in thread
From: Thomas Gleixner @ 2013-02-18 8:55 UTC (permalink / raw)
To: Cyrill Gorcunov
Cc: Richard Weinberger, Andrew Morton, LKML, paul.gortmaker, davej,
keescook, stable, Eric W. Biederman
On Sat, 16 Feb 2013, Cyrill Gorcunov wrote:
> On Fri, Feb 15, 2013 at 11:44:44PM +0100, Richard Weinberger wrote:
> > > The ability to deprecate this code has been called into question[1],
> > > but if that remains to be finalized, then making this change in the
> > > interim seems to make sense.
> >
> > Do we really want to remove this system call in 2013?
> > Note, Documentation/feature-removal-schedule.txt is gone...
> >
> > CRIU folks, I guess you still need the call?
> > Or have you found an alternative way to get the robost list?
>
> Yes, we need this call and we use it.
>
> > As stated in [0], I'd simply revert commit ec0c4274 ("futex: Mark
> > get_robust_list as deprecated")
>
> Thanks!
I take the revert via tip and queue it for 3.9
Thanks,
tglx
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-02-18 8:55 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20130215222653.B8B115A41F0@corp2gmr1-2.hot.corp.google.com>
2013-02-15 22:44 ` + futex-avoid-kernel-taint-caused-by-get_robust_list.patch added to -mm tree Richard Weinberger
2013-02-15 22:58 ` Andrew Morton
2013-02-16 7:02 ` Cyrill Gorcunov
2013-02-18 8:55 ` Thomas Gleixner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).