From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Jiri Kosina <jkosina@suse.cz>
Cc: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Johan Hedberg <johan.hedberg@gmail.com>,
David Herrmann <dh.herrmann@googlemail.com>,
linux-api@vger.kernel.org, linux-input@vger.kernel.org,
RavindranathX Doddi <ravindranathx.doddi@intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel@vger.kernel.org,
Marcel Holtmann <marcel@holtmann.org>
Subject: Re: uhid: broken interface: 32/64-bit compatibility
Date: Mon, 18 Feb 2013 10:40:35 -0800 [thread overview]
Message-ID: <20130218184035.GB15167@core.coreip.homeip.net> (raw)
In-Reply-To: <alpine.LNX.2.00.1302181121460.17024@pobox.suse.cz>
On Mon, Feb 18, 2013 at 11:28:40AM +0100, Jiri Kosina wrote:
> On Fri, 15 Feb 2013, Dmitry Torokhov wrote:
>
> > > Here's my attempt to fix the issue.
> > >
> > > Not sure if tricks with padding in a good idea. We can just use __u64
> > > instead of pointer, but it will require update of userspace to silence
> > > cast warning and will cause warning if you will try to use updated
> > > userspace with old kernel headers.
> > >
> > > Any comments?
> >
> > This does not fix anything really, we simply have to deal with compat
> > interface.
> >
> > Compiled but not tested.
> >
> > Thanks.
>
> Sorry for late response, I have been extremely busy doing some skiing :-)
Sounds good. At least someone has the right priorities ;)
--
Dmitry
next prev parent reply other threads:[~2013-02-18 18:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20130215112911.68A98E0085@blue.fi.intel.com>
2013-02-15 11:46 ` uhid: broken interface: 32/64-bit compatibility David Herrmann
2013-02-15 12:00 ` Johan Hedberg
2013-02-15 13:51 ` Kirill A. Shutemov
2013-02-15 16:40 ` Andy Shevchenko
2013-02-15 20:05 ` Dmitry Torokhov
2013-02-18 10:18 ` Kirill A. Shutemov
2013-02-18 10:28 ` Jiri Kosina
2013-02-18 18:40 ` Dmitry Torokhov [this message]
2013-02-18 18:39 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130218184035.GB15167@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=dh.herrmann@googlemail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jkosina@suse.cz \
--cc=johan.hedberg@gmail.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=ravindranathx.doddi@intel.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).