From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
Cc: Johan Hedberg <johan.hedberg@gmail.com>,
David Herrmann <dh.herrmann@googlemail.com>,
linux-api@vger.kernel.org, linux-input@vger.kernel.org,
Jiri Kosina <jkosina@suse.cz>,
RavindranathX Doddi <ravindranathx.doddi@intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel@vger.kernel.org,
Marcel Holtmann <marcel@holtmann.org>
Subject: Re: uhid: broken interface: 32/64-bit compatibility
Date: Fri, 15 Feb 2013 18:40:27 +0200 [thread overview]
Message-ID: <CAHp75VdC7JnoYwnKRsyr7v3or167OdX8mrv00VK-0YuPhpSFaw@mail.gmail.com> (raw)
In-Reply-To: <20130215135141.1EFCEE0085@blue.fi.intel.com>
> Any comments?
Generic comments. Could you use *_compat instead of *_old_*?
Another idea is do not touch current interface, just append new
function and associated structure to make a smooth transition of the
userspace stuff.
What about documentation (Documentation/hid/uhid.txt)? Could you
update it acordingly?
> Subject: [PATCH] uhid: introduce new create event to fix 32/64-bit
> compatibility issue
>
> Current create event has pointer in payload. It causes problem with
> 32/64-bit compatibility. In particular it's not possible to use 32-bit
> userspace driver with 64-bit kernel.
> This patch deprecates old create event and introduce a new one. The new
> create event has padding for pointer on 32-bit system to extend pointer
> correctly.
>
> Old userspace driver binaries will use old create event. It requires
> simple recompile to switch to new one.
That's what I afraid of. Better to try to avoid any excessive
requirement to the existing userspace.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2013-02-15 16:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20130215112911.68A98E0085@blue.fi.intel.com>
2013-02-15 11:46 ` uhid: broken interface: 32/64-bit compatibility David Herrmann
2013-02-15 12:00 ` Johan Hedberg
2013-02-15 13:51 ` Kirill A. Shutemov
2013-02-15 16:40 ` Andy Shevchenko [this message]
2013-02-15 20:05 ` Dmitry Torokhov
2013-02-18 10:18 ` Kirill A. Shutemov
2013-02-18 10:28 ` Jiri Kosina
2013-02-18 18:40 ` Dmitry Torokhov
2013-02-18 18:39 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHp75VdC7JnoYwnKRsyr7v3or167OdX8mrv00VK-0YuPhpSFaw@mail.gmail.com \
--to=andy.shevchenko@gmail.com \
--cc=dh.herrmann@googlemail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jkosina@suse.cz \
--cc=johan.hedberg@gmail.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=ravindranathx.doddi@intel.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).