* [PATCH] I2C: i2c-pxa - remove incorrect __exit annotations
@ 2013-02-20 8:50 Dmitry Torokhov
2013-02-21 10:01 ` Wolfram Sang
0 siblings, 1 reply; 2+ messages in thread
From: Dmitry Torokhov @ 2013-02-20 8:50 UTC (permalink / raw)
To: Wolfram Sang; +Cc: linux-i2c, linux-kernel
The remove() methods should not be marked __exit unless we are using
platform_driver_probe() which disables unbinding device from driver
via sysfs.
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
---
Compiled only, no hardware.
drivers/i2c/busses/i2c-pxa.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/i2c/busses/i2c-pxa.c b/drivers/i2c/busses/i2c-pxa.c
index 1034d93..4a79e76 100644
--- a/drivers/i2c/busses/i2c-pxa.c
+++ b/drivers/i2c/busses/i2c-pxa.c
@@ -1215,7 +1215,7 @@ emalloc:
return ret;
}
-static int __exit i2c_pxa_remove(struct platform_device *dev)
+static int i2c_pxa_remove(struct platform_device *dev)
{
struct pxa_i2c *i2c = platform_get_drvdata(dev);
@@ -1269,7 +1269,7 @@ static const struct dev_pm_ops i2c_pxa_dev_pm_ops = {
static struct platform_driver i2c_pxa_driver = {
.probe = i2c_pxa_probe,
- .remove = __exit_p(i2c_pxa_remove),
+ .remove = i2c_pxa_remove,
.driver = {
.name = "pxa2xx-i2c",
.owner = THIS_MODULE,
--
1.7.11.7
--
Dmitry
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] I2C: i2c-pxa - remove incorrect __exit annotations
2013-02-20 8:50 [PATCH] I2C: i2c-pxa - remove incorrect __exit annotations Dmitry Torokhov
@ 2013-02-21 10:01 ` Wolfram Sang
0 siblings, 0 replies; 2+ messages in thread
From: Wolfram Sang @ 2013-02-21 10:01 UTC (permalink / raw)
To: Dmitry Torokhov; +Cc: linux-i2c, linux-kernel
On Wed, Feb 20, 2013 at 12:50:10AM -0800, Dmitry Torokhov wrote:
> The remove() methods should not be marked __exit unless we are using
> platform_driver_probe() which disables unbinding device from driver
> via sysfs.
>
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Eeks, I broke this with my very first linux patch years ago :) Applied
to -next, thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-02-21 10:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-02-20 8:50 [PATCH] I2C: i2c-pxa - remove incorrect __exit annotations Dmitry Torokhov
2013-02-21 10:01 ` Wolfram Sang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).