From: Anton Vorontsov <anton@enomsg.org>
To: "Pali Rohár" <pali.rohar@gmail.com>
Cc: Samuel Ortiz <sameo@linux.intel.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] mfd: twl4030-madc: Add support for raw value in twl4030_madc_conversion
Date: Sat, 2 Mar 2013 15:16:26 -0800 [thread overview]
Message-ID: <20130302231626.GA23826@lizard.sbx05280.losalca.wayport.net> (raw)
In-Reply-To: <1360969010-8571-1-git-send-email-pali.rohar@gmail.com>
On Fri, Feb 15, 2013 at 11:56:49PM +0100, Pali Rohár wrote:
> Driver twl4030-madc has hardcoded channel types (10 - battery current,
> 1 - battery temperature) and also conversation data in variable
> twl4030_divider_ratios. These hardcoded channels are incorrect for
> Nokia RX-51 board (where is channel 0 - battery temperature).
>
> For Nokia RX-51 there is rx51_battery power_supply driver which reporting
> battery information via twl4030_madc_conversion. But this driver needs
> raw values (not converted via some hardcoded functions). So this patch
> adding new parameter "raw" to struct twl4030_madc_request which tell
> twl4030-madc driver to not convert values, but rather return raw.
>
> Signed-off-by: Pali Rohár <pali.rohar@gmail.com>
It looks good to me; glancing around, I don't see any better way to do it.
So,
Reviewed-by: Anton Vorontsov <anton@enomsg.org>
Thanks!
Anton
next prev parent reply other threads:[~2013-03-02 23:20 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-15 22:56 [PATCH 1/2] mfd: twl4030-madc: Add support for raw value in twl4030_madc_conversion Pali Rohár
2013-02-15 22:56 ` [PATCH 2/2] power: rx51_battery: Fix reporting correct values Pali Rohár
2013-02-16 21:39 ` Anton Vorontsov
2013-03-02 22:23 ` [PATCH 1/2] mfd: twl4030-madc: Add support for raw value in twl4030_madc_conversion Pali Rohár
2013-03-24 14:03 ` Pali Rohár
2013-04-04 9:32 ` Pali Rohár
2013-04-08 18:15 ` Tony Lindgren
2013-04-10 14:12 ` Pali Rohár
2013-04-10 17:00 ` Tony Lindgren
2013-04-04 9:38 ` Samuel Ortiz
2013-04-08 10:43 ` Pali Rohár
2013-03-02 23:16 ` Anton Vorontsov [this message]
2013-04-08 14:34 ` Samuel Ortiz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130302231626.GA23826@lizard.sbx05280.losalca.wayport.net \
--to=anton@enomsg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pali.rohar@gmail.com \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).