From: Samuel Ortiz <sameo@linux.intel.com>
To: "Pali Rohár" <pali.rohar@gmail.com>
Cc: Anton Vorontsov <cbou@mail.ru>,
linux-kernel@vger.kernel.org, Keerthy <j-keerthy@ti.com>,
Kyle Manna <kyle@kylemanna.com>
Subject: Re: [PATCH 1/2] mfd: twl4030-madc: Add support for raw value in twl4030_madc_conversion
Date: Thu, 4 Apr 2013 11:38:47 +0200 [thread overview]
Message-ID: <20130404093847.GC17363@zurbaran> (raw)
In-Reply-To: <201303022323.06091@pali>
Hi Pali,
On Sat, Mar 02, 2013 at 11:23:05PM +0100, Pali Rohár wrote:
> On Friday 15 February 2013 23:56:49 Pali Rohár wrote:
> > Driver twl4030-madc has hardcoded channel types (10 - battery
> > current, 1 - battery temperature) and also conversation data
> > in variable twl4030_divider_ratios. These hardcoded channels
> > are incorrect for Nokia RX-51 board (where is channel 0 -
> > battery temperature).
> >
> > For Nokia RX-51 there is rx51_battery power_supply driver
> > which reporting battery information via
> > twl4030_madc_conversion. But this driver needs raw values
> > (not converted via some hardcoded functions). So this patch
> > adding new parameter "raw" to struct twl4030_madc_request
> > which tell twl4030-madc driver to not convert values, but
> > rather return raw.
> >
> > Signed-off-by: Pali Rohár <pali.rohar@gmail.com>
> > ---
> > drivers/mfd/twl4030-madc.c | 14 ++++++++++----
> > include/linux/i2c/twl4030-madc.h | 2 ++
> > 2 files changed, 12 insertions(+), 4 deletions(-)
> >
>
> Hello, can somebody review this twl4030-madc patch?
I'll look at all my pending MFD patches starting from tomorrow.
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
next prev parent reply other threads:[~2013-04-04 9:38 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-15 22:56 [PATCH 1/2] mfd: twl4030-madc: Add support for raw value in twl4030_madc_conversion Pali Rohár
2013-02-15 22:56 ` [PATCH 2/2] power: rx51_battery: Fix reporting correct values Pali Rohár
2013-02-16 21:39 ` Anton Vorontsov
2013-03-02 22:23 ` [PATCH 1/2] mfd: twl4030-madc: Add support for raw value in twl4030_madc_conversion Pali Rohár
2013-03-24 14:03 ` Pali Rohár
2013-04-04 9:32 ` Pali Rohár
2013-04-08 18:15 ` Tony Lindgren
2013-04-10 14:12 ` Pali Rohár
2013-04-10 17:00 ` Tony Lindgren
2013-04-04 9:38 ` Samuel Ortiz [this message]
2013-04-08 10:43 ` Pali Rohár
2013-03-02 23:16 ` Anton Vorontsov
2013-04-08 14:34 ` Samuel Ortiz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130404093847.GC17363@zurbaran \
--to=sameo@linux.intel.com \
--cc=cbou@mail.ru \
--cc=j-keerthy@ti.com \
--cc=kyle@kylemanna.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pali.rohar@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).